From: =?UTF-8?q?=C3=81lvaro=20Herrera?= Date: Thu, 2 Apr 2026 20:01:36 +0200 Subject: [PATCH 1/5] don't include bufmgr.h in nbtree.h --- contrib/amcheck/verify_nbtree.c | 1 + contrib/pageinspect/btreefuncs.c | 1 + src/backend/access/nbtree/nbtdedup.c | 1 + src/backend/access/nbtree/nbtinsert.c | 1 + src/backend/access/nbtree/nbtpage.c | 1 + src/backend/access/nbtree/nbtreadpage.c | 1 + src/backend/access/nbtree/nbtsearch.c | 1 + src/backend/access/nbtree/nbtsort.c | 1 + src/backend/access/nbtree/nbtutils.c | 1 + src/include/access/nbtree.h | 7 ++++++- 10 files changed, 15 insertions(+), 1 deletion(-) diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c index b74ab5f7a05..40d191f2f73 100644 --- a/contrib/amcheck/verify_nbtree.c +++ b/contrib/amcheck/verify_nbtree.c @@ -37,6 +37,7 @@ #include "common/pg_prng.h" #include "lib/bloomfilter.h" #include "miscadmin.h" +#include "storage/bufmgr.h" #include "storage/smgr.h" #include "utils/guc.h" #include "utils/memutils.h" diff --git a/contrib/pageinspect/btreefuncs.c b/contrib/pageinspect/btreefuncs.c index 0585b7cee40..4fb2abe4a77 100644 --- a/contrib/pageinspect/btreefuncs.c +++ b/contrib/pageinspect/btreefuncs.c @@ -36,6 +36,7 @@ #include "funcapi.h" #include "miscadmin.h" #include "pageinspect.h" +#include "storage/bufmgr.h" #include "utils/array.h" #include "utils/builtins.h" #include "utils/rel.h" diff --git a/src/backend/access/nbtree/nbtdedup.c b/src/backend/access/nbtree/nbtdedup.c index af7affdf409..73f885a8759 100644 --- a/src/backend/access/nbtree/nbtdedup.c +++ b/src/backend/access/nbtree/nbtdedup.c @@ -19,6 +19,7 @@ #include "access/tableam.h" #include "access/xloginsert.h" #include "miscadmin.h" +#include "storage/bufmgr.h" #include "utils/rel.h" static void _bt_bottomupdel_finish_pending(Page page, BTDedupState state, diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c index c8af97dd23d..71e9777410c 100644 --- a/src/backend/access/nbtree/nbtinsert.c +++ b/src/backend/access/nbtree/nbtinsert.c @@ -24,6 +24,7 @@ #include "common/pg_prng.h" #include "lib/qunique.h" #include "miscadmin.h" +#include "storage/bufmgr.h" #include "storage/lmgr.h" #include "storage/predicate.h" #include "utils/injection_point.h" diff --git a/src/backend/access/nbtree/nbtpage.c b/src/backend/access/nbtree/nbtpage.c index 0547038616e..79810280e13 100644 --- a/src/backend/access/nbtree/nbtpage.c +++ b/src/backend/access/nbtree/nbtpage.c @@ -30,6 +30,7 @@ #include "access/xloginsert.h" #include "common/int.h" #include "miscadmin.h" +#include "storage/bufmgr.h" #include "storage/indexfsm.h" #include "storage/predicate.h" #include "storage/procarray.h" diff --git a/src/backend/access/nbtree/nbtreadpage.c b/src/backend/access/nbtree/nbtreadpage.c index 2ba1ca66023..6c2f5a32085 100644 --- a/src/backend/access/nbtree/nbtreadpage.c +++ b/src/backend/access/nbtree/nbtreadpage.c @@ -20,6 +20,7 @@ #include "access/nbtree.h" #include "access/relscan.h" +#include "storage/bufmgr.h" #include "storage/predicate.h" #include "utils/datum.h" #include "utils/rel.h" diff --git a/src/backend/access/nbtree/nbtsearch.c b/src/backend/access/nbtree/nbtsearch.c index aae6acb7f57..02796230bca 100644 --- a/src/backend/access/nbtree/nbtsearch.c +++ b/src/backend/access/nbtree/nbtsearch.c @@ -21,6 +21,7 @@ #include "executor/instrument_node.h" #include "miscadmin.h" #include "pgstat.h" +#include "storage/bufmgr.h" #include "storage/predicate.h" #include "utils/lsyscache.h" #include "utils/rel.h" diff --git a/src/backend/access/nbtree/nbtsort.c b/src/backend/access/nbtree/nbtsort.c index 756dfa3dcf4..9718f3ef308 100644 --- a/src/backend/access/nbtree/nbtsort.c +++ b/src/backend/access/nbtree/nbtsort.c @@ -51,6 +51,7 @@ #include "executor/instrument.h" #include "miscadmin.h" #include "pgstat.h" +#include "storage/bufmgr.h" #include "storage/bulk_write.h" #include "storage/condition_variable.h" #include "storage/proc.h" diff --git a/src/backend/access/nbtree/nbtutils.c b/src/backend/access/nbtree/nbtutils.c index 732bc750c9e..9f41652bdbe 100644 --- a/src/backend/access/nbtree/nbtutils.c +++ b/src/backend/access/nbtree/nbtutils.c @@ -24,6 +24,7 @@ #include "common/int.h" #include "lib/qunique.h" #include "miscadmin.h" +#include "storage/bufmgr.h" #include "storage/lwlock.h" #include "utils/datum.h" #include "utils/lsyscache.h" diff --git a/src/include/access/nbtree.h b/src/include/access/nbtree.h index bf166bf8ac9..5847cfe7ac0 100644 --- a/src/include/access/nbtree.h +++ b/src/include/access/nbtree.h @@ -22,12 +22,17 @@ #include "catalog/pg_class.h" #include "catalog/pg_index.h" #include "lib/stringinfo.h" -#include "storage/bufmgr.h" #include "storage/dsm.h" #include "storage/shm_toc.h" #include "utils/snapmgr.h" #include "utils/skipsupport.h" +/* + * forward declarations in this file + */ +typedef int Buffer; + + /* There's room for a 16-bit vacuum cycle ID in BTPageOpaqueData */ typedef uint16 BTCycleId; -- 2.47.3 --rmdldozsotr5364u Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0002-don-t-include-bufmgr.h-in-hash.h.patch"