public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
Subject: [PATCH v8 1/5] refactor relation_needs_vacanalyze()
Date: Thu, 2 Apr 2026 13:18:49 -0500
---
src/backend/postmaster/autovacuum.c | 153 ++++++++++++++--------------
1 file changed, 76 insertions(+), 77 deletions(-)
diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
index 6694f485216..590e4c8e44c 100644
--- a/src/backend/postmaster/autovacuum.c
+++ b/src/backend/postmaster/autovacuum.c
@@ -3123,6 +3123,11 @@ relation_needs_vacanalyze(Oid relid,
MultiXactId relminmxid;
MultiXactId multiForceLimit;
+ float4 pcnt_unfrozen = 1;
+ float4 reltuples = classForm->reltuples;
+ int32 relpages = classForm->relpages;
+ int32 relallfrozen = classForm->relallfrozen;
+
Assert(classForm != NULL);
Assert(OidIsValid(relid));
@@ -3263,94 +3268,88 @@ relation_needs_vacanalyze(Oid relid,
* vacuuming only, so don't vacuum (or analyze) anything that's not being
* forced.
*/
- if (tabentry && AutoVacuumingActive())
- {
- float4 pcnt_unfrozen = 1;
- float4 reltuples = classForm->reltuples;
- int32 relpages = classForm->relpages;
- int32 relallfrozen = classForm->relallfrozen;
+ if (!tabentry || !AutoVacuumingActive())
+ return;
- vactuples = tabentry->dead_tuples;
- instuples = tabentry->ins_since_vacuum;
- anltuples = tabentry->mod_since_analyze;
+ vactuples = tabentry->dead_tuples;
+ instuples = tabentry->ins_since_vacuum;
+ anltuples = tabentry->mod_since_analyze;
- /* If the table hasn't yet been vacuumed, take reltuples as zero */
- if (reltuples < 0)
- reltuples = 0;
+ /* If the table hasn't yet been vacuumed, take reltuples as zero */
+ if (reltuples < 0)
+ reltuples = 0;
+ /*
+ * If we have data for relallfrozen, calculate the unfrozen percentage of
+ * the table to modify insert scale factor. This helps us decide whether
+ * or not to vacuum an insert-heavy table based on the number of inserts
+ * to the more "active" part of the table.
+ */
+ if (relpages > 0 && relallfrozen > 0)
+ {
/*
- * If we have data for relallfrozen, calculate the unfrozen percentage
- * of the table to modify insert scale factor. This helps us decide
- * whether or not to vacuum an insert-heavy table based on the number
- * of inserts to the more "active" part of the table.
+ * It could be the stats were updated manually and relallfrozen >
+ * relpages. Clamp relallfrozen to relpages to avoid nonsensical
+ * calculations.
*/
- if (relpages > 0 && relallfrozen > 0)
- {
- /*
- * It could be the stats were updated manually and relallfrozen >
- * relpages. Clamp relallfrozen to relpages to avoid nonsensical
- * calculations.
- */
- relallfrozen = Min(relallfrozen, relpages);
- pcnt_unfrozen = 1 - ((float4) relallfrozen / relpages);
- }
+ relallfrozen = Min(relallfrozen, relpages);
+ pcnt_unfrozen = 1 - ((float4) relallfrozen / relpages);
+ }
- vacthresh = (float4) vac_base_thresh + vac_scale_factor * reltuples;
- if (vac_max_thresh >= 0 && vacthresh > (float4) vac_max_thresh)
- vacthresh = (float4) vac_max_thresh;
+ vacthresh = (float4) vac_base_thresh + vac_scale_factor * reltuples;
+ if (vac_max_thresh >= 0 && vacthresh > (float4) vac_max_thresh)
+ vacthresh = (float4) vac_max_thresh;
- vacinsthresh = (float4) vac_ins_base_thresh +
- vac_ins_scale_factor * reltuples * pcnt_unfrozen;
- anlthresh = (float4) anl_base_thresh + anl_scale_factor * reltuples;
+ vacinsthresh = (float4) vac_ins_base_thresh +
+ vac_ins_scale_factor * reltuples * pcnt_unfrozen;
+ anlthresh = (float4) anl_base_thresh + anl_scale_factor * reltuples;
- /*
- * Determine if this table needs vacuum, and update the score if it
- * does.
- */
- if (vactuples > vacthresh)
- {
- scores->vac = (double) vactuples / Max(vacthresh, 1);
- scores->vac *= autovacuum_vacuum_score_weight;
- scores->max = Max(scores->max, scores->vac);
- *dovacuum = true;
- }
-
- if (vac_ins_base_thresh >= 0 && instuples > vacinsthresh)
- {
- scores->vac_ins = (double) instuples / Max(vacinsthresh, 1);
- scores->vac_ins *= autovacuum_vacuum_insert_score_weight;
- scores->max = Max(scores->max, scores->vac_ins);
- *dovacuum = true;
- }
+ /*
+ * Determine if this table needs vacuum, and update the score if it does.
+ */
+ if (vactuples > vacthresh)
+ {
+ scores->vac = (double) vactuples / Max(vacthresh, 1);
+ scores->vac *= autovacuum_vacuum_score_weight;
+ scores->max = Max(scores->max, scores->vac);
+ *dovacuum = true;
+ }
- /*
- * Determine if this table needs analyze, and update the score if it
- * does. Note that we don't analyze TOAST tables and pg_statistic.
- */
- if (anltuples > anlthresh &&
- relid != StatisticRelationId &&
- classForm->relkind != RELKIND_TOASTVALUE)
- {
- scores->anl = (double) anltuples / Max(anlthresh, 1);
- scores->anl *= autovacuum_analyze_score_weight;
- scores->max = Max(scores->max, scores->anl);
- *doanalyze = true;
- }
+ if (vac_ins_base_thresh >= 0 && instuples > vacinsthresh)
+ {
+ scores->vac_ins = (double) instuples / Max(vacinsthresh, 1);
+ scores->vac_ins *= autovacuum_vacuum_insert_score_weight;
+ scores->max = Max(scores->max, scores->vac_ins);
+ *dovacuum = true;
+ }
- if (vac_ins_base_thresh >= 0)
- elog(DEBUG3, "%s: vac: %.0f (thresh %.0f, score %.2f), ins: %.0f (thresh %.0f, score %.2f), anl: %.0f (thresh %.0f, score %.2f), xid score: %.2f, mxid score: %.2f",
- NameStr(classForm->relname),
- vactuples, vacthresh, scores->vac,
- instuples, vacinsthresh, scores->vac_ins,
- anltuples, anlthresh, scores->anl,
- scores->xid, scores->mxid);
- else
- elog(DEBUG3, "%s: vac: %.0f (thresh %.0f, score %.2f), ins: (disabled), anl: %.0f (thresh %.0f, score %.2f), xid score: %.2f, mxid score: %.2f",
- NameStr(classForm->relname),
- vactuples, vacthresh, scores->vac,
- anltuples, anlthresh, scores->anl,
- scores->xid, scores->mxid);
+ /*
+ * Determine if this table needs analyze, and update the score if it does.
+ * Note that we don't analyze TOAST tables and pg_statistic.
+ */
+ if (anltuples > anlthresh &&
+ relid != StatisticRelationId &&
+ classForm->relkind != RELKIND_TOASTVALUE)
+ {
+ scores->anl = (double) anltuples / Max(anlthresh, 1);
+ scores->anl *= autovacuum_analyze_score_weight;
+ scores->max = Max(scores->max, scores->anl);
+ *doanalyze = true;
}
+
+ if (vac_ins_base_thresh >= 0)
+ elog(DEBUG3, "%s: vac: %.0f (thresh %.0f, score %.2f), ins: %.0f (thresh %.0f, score %.2f), anl: %.0f (thresh %.0f, score %.2f), xid score: %.2f, mxid score: %.2f",
+ NameStr(classForm->relname),
+ vactuples, vacthresh, scores->vac,
+ instuples, vacinsthresh, scores->vac_ins,
+ anltuples, anlthresh, scores->anl,
+ scores->xid, scores->mxid);
+ else
+ elog(DEBUG3, "%s: vac: %.0f (thresh %.0f, score %.2f), ins: (disabled), anl: %.0f (thresh %.0f, score %.2f), xid score: %.2f, mxid score: %.2f",
+ NameStr(classForm->relname),
+ vactuples, vacthresh, scores->vac,
+ anltuples, anlthresh, scores->anl,
+ scores->xid, scores->mxid);
}
/*
--
2.50.1 (Apple Git-155)
--/vKBiHkEvphli8Mi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
filename=v8-0002-always-compute-autovacuum-scores.patch
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [PATCH v8 1/5] refactor relation_needs_vacanalyze()
In-Reply-To: <no-message-id-601572@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox