agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH v7] Fix orderby handling in postgres_fdw 4+ messages / 2 participants [nested] [flat]
* [PATCH v7] Fix orderby handling in postgres_fdw @ 2021-09-06 07:54 Ronan Dunklau <ronan.dunklau@aiven.io> 0 siblings, 0 replies; 4+ messages in thread From: Ronan Dunklau @ 2021-09-06 07:54 UTC (permalink / raw) The logic for pushing down order bys in postgres fdw didn't take into account the specific operator used, and as such a pushed-down order by could return wrong results. --- contrib/postgres_fdw/deparse.c | 156 +++++++++++++----- .../postgres_fdw/expected/postgres_fdw.out | 23 +++ contrib/postgres_fdw/postgres_fdw.c | 28 ++-- contrib/postgres_fdw/postgres_fdw.h | 11 +- contrib/postgres_fdw/sql/postgres_fdw.sql | 8 + src/backend/optimizer/path/equivclass.c | 26 ++- src/include/optimizer/paths.h | 2 + 7 files changed, 187 insertions(+), 67 deletions(-) diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c index d98bd66681..fb1b5f9d9b 100644 --- a/contrib/postgres_fdw/deparse.c +++ b/contrib/postgres_fdw/deparse.c @@ -37,9 +37,11 @@ #include "access/sysattr.h" #include "access/table.h" #include "catalog/pg_aggregate.h" +#include "catalog/pg_amop.h" #include "catalog/pg_collation.h" #include "catalog/pg_namespace.h" #include "catalog/pg_operator.h" +#include "catalog/pg_opfamily.h" #include "catalog/pg_proc.h" #include "catalog/pg_type.h" #include "commands/defrem.h" @@ -47,6 +49,7 @@ #include "nodes/nodeFuncs.h" #include "nodes/plannodes.h" #include "optimizer/optimizer.h" +#include "optimizer/paths.h" #include "optimizer/prep.h" #include "optimizer/tlist.h" #include "parser/parsetree.h" @@ -182,6 +185,8 @@ static void deparseRangeTblRef(StringInfo buf, PlannerInfo *root, Index ignore_rel, List **ignore_conds, List **params_list); static void deparseAggref(Aggref *node, deparse_expr_cxt *context); static void appendGroupByClause(List *tlist, deparse_expr_cxt *context); +static void appendOrderBySuffix(Oid sortop, Oid sortcoltype, bool nulls_first, + deparse_expr_cxt *context); static void appendAggOrderBy(List *orderList, List *targetList, deparse_expr_cxt *context); static void appendFunctionName(Oid funcid, deparse_expr_cxt *context); @@ -1037,6 +1042,41 @@ is_foreign_param(PlannerInfo *root, return false; } +/* + * Returns true if it's safe to push down a sort as described by 'pathkey' to + * the foreign server + */ +bool +is_foreign_pathkey(PlannerInfo *root, + RelOptInfo *baserel, + PathKey *pathkey) +{ + EquivalenceClass *pathkey_ec = pathkey->pk_eclass; + PgFdwRelationInfo *fpinfo = (PgFdwRelationInfo *) baserel->fdw_private; + Expr *em_expr; + + /* + * is_foreign_expr would detect volatile expressions as well, but checking + * ec_has_volatile here saves some cycles. + */ + if (pathkey_ec->ec_has_volatile) + return false; + + /* can't push down the sort if the pathkey's opfamily is not shippable */ + if (!is_shippable(pathkey->pk_opfamily, OperatorFamilyRelationId, fpinfo)) + return false; + + em_expr = find_em_expr_for_rel(pathkey_ec, baserel); + if (em_expr == NULL) + return false; + + /* + * Finally, determine if it's safe to evaluate the found expr on the + * foreign server. + */ + return is_foreign_expr(root, baserel, em_expr); +} + /* * Convert type OID + typmod info into a type name we can ship to the remote * server. Someplace else had better have verified that this type name is @@ -3331,6 +3371,45 @@ deparseAggref(Aggref *node, deparse_expr_cxt *context) appendStringInfoChar(buf, ')'); } +/* + * Append the ASC, DESC, USING <OPERATOR> and NULLS FIRST / NULLS LAST part + * of the ORDER BY clause + */ +static void +appendOrderBySuffix(Oid sortop, Oid sortcoltype, bool nulls_first, + deparse_expr_cxt *context) +{ + StringInfo buf = context->buf; + TypeCacheEntry *typentry; + + typentry = lookup_type_cache(sortcoltype, TYPECACHE_LT_OPR | TYPECACHE_GT_OPR); + + if (sortop == typentry->lt_opr) + appendStringInfoString(buf, " ASC"); + else if (sortop == typentry->gt_opr) + appendStringInfoString(buf, " DESC"); + else + { + HeapTuple opertup; + Form_pg_operator operform; + + appendStringInfoString(buf, " USING "); + + /* Append operator name. */ + opertup = SearchSysCache1(OPEROID, ObjectIdGetDatum(sortop)); + if (!HeapTupleIsValid(opertup)) + elog(ERROR, "cache lookup failed for operator %u", sortop); + operform = (Form_pg_operator) GETSTRUCT(opertup); + deparseOperatorName(buf, operform); + ReleaseSysCache(opertup); + } + + if (nulls_first) + appendStringInfoString(buf, " NULLS FIRST"); + else + appendStringInfoString(buf, " NULLS LAST"); +} + /* * Append ORDER BY within aggregate function. */ @@ -3346,7 +3425,6 @@ appendAggOrderBy(List *orderList, List *targetList, deparse_expr_cxt *context) SortGroupClause *srt = (SortGroupClause *) lfirst(lc); Node *sortexpr; Oid sortcoltype; - TypeCacheEntry *typentry; if (!first) appendStringInfoString(buf, ", "); @@ -3356,32 +3434,8 @@ appendAggOrderBy(List *orderList, List *targetList, deparse_expr_cxt *context) false, context); sortcoltype = exprType(sortexpr); /* See whether operator is default < or > for datatype */ - typentry = lookup_type_cache(sortcoltype, - TYPECACHE_LT_OPR | TYPECACHE_GT_OPR); - if (srt->sortop == typentry->lt_opr) - appendStringInfoString(buf, " ASC"); - else if (srt->sortop == typentry->gt_opr) - appendStringInfoString(buf, " DESC"); - else - { - HeapTuple opertup; - Form_pg_operator operform; - - appendStringInfoString(buf, " USING "); - - /* Append operator name. */ - opertup = SearchSysCache1(OPEROID, ObjectIdGetDatum(srt->sortop)); - if (!HeapTupleIsValid(opertup)) - elog(ERROR, "cache lookup failed for operator %u", srt->sortop); - operform = (Form_pg_operator) GETSTRUCT(opertup); - deparseOperatorName(buf, operform); - ReleaseSysCache(opertup); - } - - if (srt->nulls_first) - appendStringInfoString(buf, " NULLS FIRST"); - else - appendStringInfoString(buf, " NULLS LAST"); + appendOrderBySuffix(srt->sortop, sortcoltype, srt->nulls_first, + context); } } @@ -3486,7 +3540,11 @@ appendOrderByClause(List *pathkeys, bool has_final_sort, foreach(lcell, pathkeys) { PathKey *pathkey = lfirst(lcell); + EquivalenceMember *em; Expr *em_expr; + HeapTuple tuple; + Oid oprid; + bool isNull; if (has_final_sort) { @@ -3494,26 +3552,44 @@ appendOrderByClause(List *pathkeys, bool has_final_sort, * By construction, context->foreignrel is the input relation to * the final sort. */ - em_expr = find_em_expr_for_input_target(context->root, - pathkey->pk_eclass, - context->foreignrel->reltarget); + em = find_em_for_input_target(context->root, + pathkey->pk_eclass, + context->foreignrel->reltarget); } else - em_expr = find_em_expr_for_rel(pathkey->pk_eclass, baserel); + em = find_em_for_rel(pathkey->pk_eclass, baserel); + + em_expr = em->em_expr; + + /* + * Lookup the operator corresponding to the strategy in the opclass. + * The datatype used by the opfamily is not necessarily the same as + * the expression type (for array types for example). + */ + tuple = SearchSysCache4(AMOPSTRATEGY, + ObjectIdGetDatum(pathkey->pk_opfamily), + ObjectIdGetDatum(em->em_datatype), + ObjectIdGetDatum(em->em_datatype), + Int16GetDatum(pathkey->pk_strategy)); + + if (!HeapTupleIsValid(tuple)) + elog(ERROR, "missing operator %d(%u,%u) in opfamily %u", + pathkey->pk_strategy, em->em_datatype, em->em_datatype, + pathkey->pk_opfamily); - Assert(em_expr != NULL); + oprid = DatumGetObjectId(SysCacheGetAttr(AMOPSTRATEGY, tuple, + Anum_pg_amop_amopopr, &isNull)); + ReleaseSysCache(tuple); appendStringInfoString(buf, delim); deparseExpr(em_expr, context); - if (pathkey->pk_strategy == BTLessStrategyNumber) - appendStringInfoString(buf, " ASC"); - else - appendStringInfoString(buf, " DESC"); - if (pathkey->pk_nulls_first) - appendStringInfoString(buf, " NULLS FIRST"); - else - appendStringInfoString(buf, " NULLS LAST"); + /* + * Here we need to use the expression type to compare against the + * default btree sort operator. + */ + appendOrderBySuffix(oprid, exprType((Node *) em_expr), + pathkey->pk_nulls_first, context); delim = ", "; } diff --git a/contrib/postgres_fdw/expected/postgres_fdw.out b/contrib/postgres_fdw/expected/postgres_fdw.out index e3ee30f1aa..1f44c365ef 100644 --- a/contrib/postgres_fdw/expected/postgres_fdw.out +++ b/contrib/postgres_fdw/expected/postgres_fdw.out @@ -3258,6 +3258,19 @@ select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 Remote SQL: SELECT "C 1", c2 FROM "S 1"."T 1" WHERE (("C 1" < 100)) AND ((c2 = 6)) (6 rows) +-- Ensure that we don't push down an ORDER BY with a non-shippable operator +explain (verbose, costs off) +select * from ft2 order by c1 using operator(public.<^); + QUERY PLAN +------------------------------------------------------------------------------- + Sort + Output: c1, c2, c3, c4, c5, c6, c7, c8 + Sort Key: ft2.c1 USING <^ + -> Foreign Scan on public.ft2 + Output: c1, c2, c3, c4, c5, c6, c7, c8 + Remote SQL: SELECT "C 1", c2, c3, c4, c5, c6, c7, c8 FROM "S 1"."T 1" +(6 rows) + -- Update local stats on ft2 ANALYZE ft2; -- Add into extension @@ -3285,6 +3298,16 @@ select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 {6,16,26,36,46,56,66,76,86,96} (1 row) +-- Ensure that the ORDER BY is pushed to the foreign server +explain (verbose, costs off) +select * from ft2 order by c1 using operator(public.<^); + QUERY PLAN +----------------------------------------------------------------------------------------------------------------------------- + Foreign Scan on public.ft2 + Output: c1, c2, c3, c4, c5, c6, c7, c8 + Remote SQL: SELECT "C 1", c2, c3, c4, c5, c6, c7, c8 FROM "S 1"."T 1" ORDER BY "C 1" USING OPERATOR(public.<^) NULLS LAST +(3 rows) + -- Remove from extension alter extension postgres_fdw drop operator class my_op_class using btree; alter extension postgres_fdw drop function my_op_cmp(a int, b int); diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index 4bdab30a73..1dd4779185 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -917,8 +917,6 @@ get_useful_pathkeys_for_relation(PlannerInfo *root, RelOptInfo *rel) foreach(lc, root->query_pathkeys) { PathKey *pathkey = (PathKey *) lfirst(lc); - EquivalenceClass *pathkey_ec = pathkey->pk_eclass; - Expr *em_expr; /* * The planner and executor don't have any clever strategy for @@ -926,13 +924,8 @@ get_useful_pathkeys_for_relation(PlannerInfo *root, RelOptInfo *rel) * getting it to be sorted by all of those pathkeys. We'll just * end up resorting the entire data set. So, unless we can push * down all of the query pathkeys, forget it. - * - * is_foreign_expr would detect volatile expressions as well, but - * checking ec_has_volatile here saves some cycles. */ - if (pathkey_ec->ec_has_volatile || - !(em_expr = find_em_expr_for_rel(pathkey_ec, rel)) || - !is_foreign_expr(root, rel, em_expr)) + if (!is_foreign_pathkey(root, rel, pathkey)) { query_pathkeys_ok = false; break; @@ -6540,9 +6533,9 @@ add_foreign_ordered_paths(PlannerInfo *root, RelOptInfo *input_rel, return; /* Get the sort expression for the pathkey_ec */ - sort_expr = find_em_expr_for_input_target(root, - pathkey_ec, - input_rel->reltarget); + sort_expr = find_em_for_input_target(root, + pathkey_ec, + input_rel->reltarget)->em_expr; /* If it's unsafe to remote, we cannot push down the final sort */ if (!is_foreign_expr(root, input_rel, sort_expr)) @@ -7332,13 +7325,12 @@ conversion_error_callback(void *arg) } /* - * Find an equivalence class member expression to be computed as a sort column - * in the given target. + * Find an equivalence class member to be computed as a sort column in the + * given target. */ -Expr * -find_em_expr_for_input_target(PlannerInfo *root, - EquivalenceClass *ec, - PathTarget *target) +EquivalenceMember * +find_em_for_input_target(PlannerInfo *root, EquivalenceClass *ec, + PathTarget *target) { ListCell *lc1; int i; @@ -7383,7 +7375,7 @@ find_em_expr_for_input_target(PlannerInfo *root, em_expr = ((RelabelType *) em_expr)->arg; if (equal(em_expr, expr)) - return em->em_expr; + return em; } i++; diff --git a/contrib/postgres_fdw/postgres_fdw.h b/contrib/postgres_fdw/postgres_fdw.h index ca83306af9..9930226b6f 100644 --- a/contrib/postgres_fdw/postgres_fdw.h +++ b/contrib/postgres_fdw/postgres_fdw.h @@ -171,6 +171,9 @@ extern bool is_foreign_expr(PlannerInfo *root, extern bool is_foreign_param(PlannerInfo *root, RelOptInfo *baserel, Expr *expr); +extern bool is_foreign_pathkey(PlannerInfo *root, + RelOptInfo *baserel, + PathKey *pathkey); extern void deparseInsertSql(StringInfo buf, RangeTblEntry *rte, Index rtindex, Relation rel, List *targetAttrs, bool doNothing, @@ -213,10 +216,10 @@ extern void deparseTruncateSql(StringInfo buf, DropBehavior behavior, bool restart_seqs); extern void deparseStringLiteral(StringInfo buf, const char *val); -extern Expr *find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel); -extern Expr *find_em_expr_for_input_target(PlannerInfo *root, - EquivalenceClass *ec, - PathTarget *target); +extern EquivalenceMember *find_em_for_rel(EquivalenceClass *ec, RelOptInfo *rel); +extern EquivalenceMember *find_em_for_input_target(PlannerInfo *root, + EquivalenceClass *ec, + PathTarget *target); extern List *build_tlist_to_deparse(RelOptInfo *foreignrel); extern void deparseSelectStmtForRel(StringInfo buf, PlannerInfo *root, RelOptInfo *foreignrel, List *tlist, diff --git a/contrib/postgres_fdw/sql/postgres_fdw.sql b/contrib/postgres_fdw/sql/postgres_fdw.sql index 30b5175da5..1bbe1212c4 100644 --- a/contrib/postgres_fdw/sql/postgres_fdw.sql +++ b/contrib/postgres_fdw/sql/postgres_fdw.sql @@ -902,6 +902,10 @@ create operator class my_op_class for type int using btree family my_op_family a explain (verbose, costs off) select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 and c1 < 100 group by c2; +-- Ensure that we don't push down an ORDER BY with a non-shippable operator +explain (verbose, costs off) +select * from ft2 order by c1 using operator(public.<^); + -- Update local stats on ft2 ANALYZE ft2; @@ -919,6 +923,10 @@ explain (verbose, costs off) select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 and c1 < 100 group by c2; select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 and c1 < 100 group by c2; +-- Ensure that the ORDER BY is pushed to the foreign server +explain (verbose, costs off) +select * from ft2 order by c1 using operator(public.<^); + -- Remove from extension alter extension postgres_fdw drop operator class my_op_class using btree; alter extension postgres_fdw drop function my_op_cmp(a int, b int); diff --git a/src/backend/optimizer/path/equivclass.c b/src/backend/optimizer/path/equivclass.c index 6f1abbe47d..b367f18eab 100644 --- a/src/backend/optimizer/path/equivclass.c +++ b/src/backend/optimizer/path/equivclass.c @@ -932,11 +932,11 @@ is_exprlist_member(Expr *node, List *exprs) } /* - * Find an equivalence class member expression, all of whose Vars, come from - * the indicated relation. + * Find an equivalence class member, all of whose Vars, come from the + * indicated relation. */ -Expr * -find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel) +EquivalenceMember * +find_em_for_rel(EquivalenceClass *ec, RelOptInfo *rel) { ListCell *lc_em; @@ -952,7 +952,7 @@ find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel) * taken entirely from this relation, we'll be content to choose * any one of those. */ - return em->em_expr; + return em; } } @@ -960,6 +960,22 @@ find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel) return NULL; } +/* + * Find an equivalence class member expression, all of whose Vars, come from + * the indicated relation. + */ +Expr * +find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel) +{ + EquivalenceMember *em = find_em_for_rel(ec, rel); + + if (em != NULL) + return em->em_expr; + + return NULL; +} + + /* * relation_can_be_sorted_early * Can this relation be sorted on this EC before the final output step? diff --git a/src/include/optimizer/paths.h b/src/include/optimizer/paths.h index f1d111063c..5a2bbc87e1 100644 --- a/src/include/optimizer/paths.h +++ b/src/include/optimizer/paths.h @@ -144,6 +144,8 @@ extern EquivalenceMember *find_computable_ec_member(PlannerInfo *root, Relids relids, bool require_parallel_safe); extern Expr *find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel); +extern EquivalenceMember *find_em_for_rel(EquivalenceClass *ec, + RelOptInfo *rel); extern bool relation_can_be_sorted_early(PlannerInfo *root, RelOptInfo *rel, EquivalenceClass *ec, bool require_parallel_safe); -- 2.33.0 --nextPart1657077.ZGz24vUy9i-- ^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH v8] Fix orderby handling in postgres_fdw @ 2021-09-06 07:54 Ronan Dunklau <ronan.dunklau@aiven.io> 0 siblings, 0 replies; 4+ messages in thread From: Ronan Dunklau @ 2021-09-06 07:54 UTC (permalink / raw) The logic for pushing down order bys in postgres fdw didn't take into account the specific operator used, and as such a pushed-down order by could return wrong results. This patch looks up the original operator associated to the pathkey opfamily, and checks that it actually exists on the foreign side. If it does, the operator is then used to rebuild an equivalent USING <operator> clause. --- contrib/postgres_fdw/deparse.c | 156 +++++++++++++----- .../postgres_fdw/expected/postgres_fdw.out | 23 +++ contrib/postgres_fdw/postgres_fdw.c | 28 ++-- contrib/postgres_fdw/postgres_fdw.h | 11 +- contrib/postgres_fdw/sql/postgres_fdw.sql | 8 + src/backend/optimizer/path/equivclass.c | 26 ++- src/include/optimizer/paths.h | 2 + 7 files changed, 187 insertions(+), 67 deletions(-) diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c index d98bd66681..fb1b5f9d9b 100644 --- a/contrib/postgres_fdw/deparse.c +++ b/contrib/postgres_fdw/deparse.c @@ -37,9 +37,11 @@ #include "access/sysattr.h" #include "access/table.h" #include "catalog/pg_aggregate.h" +#include "catalog/pg_amop.h" #include "catalog/pg_collation.h" #include "catalog/pg_namespace.h" #include "catalog/pg_operator.h" +#include "catalog/pg_opfamily.h" #include "catalog/pg_proc.h" #include "catalog/pg_type.h" #include "commands/defrem.h" @@ -47,6 +49,7 @@ #include "nodes/nodeFuncs.h" #include "nodes/plannodes.h" #include "optimizer/optimizer.h" +#include "optimizer/paths.h" #include "optimizer/prep.h" #include "optimizer/tlist.h" #include "parser/parsetree.h" @@ -182,6 +185,8 @@ static void deparseRangeTblRef(StringInfo buf, PlannerInfo *root, Index ignore_rel, List **ignore_conds, List **params_list); static void deparseAggref(Aggref *node, deparse_expr_cxt *context); static void appendGroupByClause(List *tlist, deparse_expr_cxt *context); +static void appendOrderBySuffix(Oid sortop, Oid sortcoltype, bool nulls_first, + deparse_expr_cxt *context); static void appendAggOrderBy(List *orderList, List *targetList, deparse_expr_cxt *context); static void appendFunctionName(Oid funcid, deparse_expr_cxt *context); @@ -1037,6 +1042,41 @@ is_foreign_param(PlannerInfo *root, return false; } +/* + * Returns true if it's safe to push down a sort as described by 'pathkey' to + * the foreign server + */ +bool +is_foreign_pathkey(PlannerInfo *root, + RelOptInfo *baserel, + PathKey *pathkey) +{ + EquivalenceClass *pathkey_ec = pathkey->pk_eclass; + PgFdwRelationInfo *fpinfo = (PgFdwRelationInfo *) baserel->fdw_private; + Expr *em_expr; + + /* + * is_foreign_expr would detect volatile expressions as well, but checking + * ec_has_volatile here saves some cycles. + */ + if (pathkey_ec->ec_has_volatile) + return false; + + /* can't push down the sort if the pathkey's opfamily is not shippable */ + if (!is_shippable(pathkey->pk_opfamily, OperatorFamilyRelationId, fpinfo)) + return false; + + em_expr = find_em_expr_for_rel(pathkey_ec, baserel); + if (em_expr == NULL) + return false; + + /* + * Finally, determine if it's safe to evaluate the found expr on the + * foreign server. + */ + return is_foreign_expr(root, baserel, em_expr); +} + /* * Convert type OID + typmod info into a type name we can ship to the remote * server. Someplace else had better have verified that this type name is @@ -3331,6 +3371,45 @@ deparseAggref(Aggref *node, deparse_expr_cxt *context) appendStringInfoChar(buf, ')'); } +/* + * Append the ASC, DESC, USING <OPERATOR> and NULLS FIRST / NULLS LAST part + * of the ORDER BY clause + */ +static void +appendOrderBySuffix(Oid sortop, Oid sortcoltype, bool nulls_first, + deparse_expr_cxt *context) +{ + StringInfo buf = context->buf; + TypeCacheEntry *typentry; + + typentry = lookup_type_cache(sortcoltype, TYPECACHE_LT_OPR | TYPECACHE_GT_OPR); + + if (sortop == typentry->lt_opr) + appendStringInfoString(buf, " ASC"); + else if (sortop == typentry->gt_opr) + appendStringInfoString(buf, " DESC"); + else + { + HeapTuple opertup; + Form_pg_operator operform; + + appendStringInfoString(buf, " USING "); + + /* Append operator name. */ + opertup = SearchSysCache1(OPEROID, ObjectIdGetDatum(sortop)); + if (!HeapTupleIsValid(opertup)) + elog(ERROR, "cache lookup failed for operator %u", sortop); + operform = (Form_pg_operator) GETSTRUCT(opertup); + deparseOperatorName(buf, operform); + ReleaseSysCache(opertup); + } + + if (nulls_first) + appendStringInfoString(buf, " NULLS FIRST"); + else + appendStringInfoString(buf, " NULLS LAST"); +} + /* * Append ORDER BY within aggregate function. */ @@ -3346,7 +3425,6 @@ appendAggOrderBy(List *orderList, List *targetList, deparse_expr_cxt *context) SortGroupClause *srt = (SortGroupClause *) lfirst(lc); Node *sortexpr; Oid sortcoltype; - TypeCacheEntry *typentry; if (!first) appendStringInfoString(buf, ", "); @@ -3356,32 +3434,8 @@ appendAggOrderBy(List *orderList, List *targetList, deparse_expr_cxt *context) false, context); sortcoltype = exprType(sortexpr); /* See whether operator is default < or > for datatype */ - typentry = lookup_type_cache(sortcoltype, - TYPECACHE_LT_OPR | TYPECACHE_GT_OPR); - if (srt->sortop == typentry->lt_opr) - appendStringInfoString(buf, " ASC"); - else if (srt->sortop == typentry->gt_opr) - appendStringInfoString(buf, " DESC"); - else - { - HeapTuple opertup; - Form_pg_operator operform; - - appendStringInfoString(buf, " USING "); - - /* Append operator name. */ - opertup = SearchSysCache1(OPEROID, ObjectIdGetDatum(srt->sortop)); - if (!HeapTupleIsValid(opertup)) - elog(ERROR, "cache lookup failed for operator %u", srt->sortop); - operform = (Form_pg_operator) GETSTRUCT(opertup); - deparseOperatorName(buf, operform); - ReleaseSysCache(opertup); - } - - if (srt->nulls_first) - appendStringInfoString(buf, " NULLS FIRST"); - else - appendStringInfoString(buf, " NULLS LAST"); + appendOrderBySuffix(srt->sortop, sortcoltype, srt->nulls_first, + context); } } @@ -3486,7 +3540,11 @@ appendOrderByClause(List *pathkeys, bool has_final_sort, foreach(lcell, pathkeys) { PathKey *pathkey = lfirst(lcell); + EquivalenceMember *em; Expr *em_expr; + HeapTuple tuple; + Oid oprid; + bool isNull; if (has_final_sort) { @@ -3494,26 +3552,44 @@ appendOrderByClause(List *pathkeys, bool has_final_sort, * By construction, context->foreignrel is the input relation to * the final sort. */ - em_expr = find_em_expr_for_input_target(context->root, - pathkey->pk_eclass, - context->foreignrel->reltarget); + em = find_em_for_input_target(context->root, + pathkey->pk_eclass, + context->foreignrel->reltarget); } else - em_expr = find_em_expr_for_rel(pathkey->pk_eclass, baserel); + em = find_em_for_rel(pathkey->pk_eclass, baserel); + + em_expr = em->em_expr; + + /* + * Lookup the operator corresponding to the strategy in the opclass. + * The datatype used by the opfamily is not necessarily the same as + * the expression type (for array types for example). + */ + tuple = SearchSysCache4(AMOPSTRATEGY, + ObjectIdGetDatum(pathkey->pk_opfamily), + ObjectIdGetDatum(em->em_datatype), + ObjectIdGetDatum(em->em_datatype), + Int16GetDatum(pathkey->pk_strategy)); + + if (!HeapTupleIsValid(tuple)) + elog(ERROR, "missing operator %d(%u,%u) in opfamily %u", + pathkey->pk_strategy, em->em_datatype, em->em_datatype, + pathkey->pk_opfamily); - Assert(em_expr != NULL); + oprid = DatumGetObjectId(SysCacheGetAttr(AMOPSTRATEGY, tuple, + Anum_pg_amop_amopopr, &isNull)); + ReleaseSysCache(tuple); appendStringInfoString(buf, delim); deparseExpr(em_expr, context); - if (pathkey->pk_strategy == BTLessStrategyNumber) - appendStringInfoString(buf, " ASC"); - else - appendStringInfoString(buf, " DESC"); - if (pathkey->pk_nulls_first) - appendStringInfoString(buf, " NULLS FIRST"); - else - appendStringInfoString(buf, " NULLS LAST"); + /* + * Here we need to use the expression type to compare against the + * default btree sort operator. + */ + appendOrderBySuffix(oprid, exprType((Node *) em_expr), + pathkey->pk_nulls_first, context); delim = ", "; } diff --git a/contrib/postgres_fdw/expected/postgres_fdw.out b/contrib/postgres_fdw/expected/postgres_fdw.out index e3ee30f1aa..1f44c365ef 100644 --- a/contrib/postgres_fdw/expected/postgres_fdw.out +++ b/contrib/postgres_fdw/expected/postgres_fdw.out @@ -3258,6 +3258,19 @@ select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 Remote SQL: SELECT "C 1", c2 FROM "S 1"."T 1" WHERE (("C 1" < 100)) AND ((c2 = 6)) (6 rows) +-- Ensure that we don't push down an ORDER BY with a non-shippable operator +explain (verbose, costs off) +select * from ft2 order by c1 using operator(public.<^); + QUERY PLAN +------------------------------------------------------------------------------- + Sort + Output: c1, c2, c3, c4, c5, c6, c7, c8 + Sort Key: ft2.c1 USING <^ + -> Foreign Scan on public.ft2 + Output: c1, c2, c3, c4, c5, c6, c7, c8 + Remote SQL: SELECT "C 1", c2, c3, c4, c5, c6, c7, c8 FROM "S 1"."T 1" +(6 rows) + -- Update local stats on ft2 ANALYZE ft2; -- Add into extension @@ -3285,6 +3298,16 @@ select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 {6,16,26,36,46,56,66,76,86,96} (1 row) +-- Ensure that the ORDER BY is pushed to the foreign server +explain (verbose, costs off) +select * from ft2 order by c1 using operator(public.<^); + QUERY PLAN +----------------------------------------------------------------------------------------------------------------------------- + Foreign Scan on public.ft2 + Output: c1, c2, c3, c4, c5, c6, c7, c8 + Remote SQL: SELECT "C 1", c2, c3, c4, c5, c6, c7, c8 FROM "S 1"."T 1" ORDER BY "C 1" USING OPERATOR(public.<^) NULLS LAST +(3 rows) + -- Remove from extension alter extension postgres_fdw drop operator class my_op_class using btree; alter extension postgres_fdw drop function my_op_cmp(a int, b int); diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index 4bdab30a73..1dd4779185 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -917,8 +917,6 @@ get_useful_pathkeys_for_relation(PlannerInfo *root, RelOptInfo *rel) foreach(lc, root->query_pathkeys) { PathKey *pathkey = (PathKey *) lfirst(lc); - EquivalenceClass *pathkey_ec = pathkey->pk_eclass; - Expr *em_expr; /* * The planner and executor don't have any clever strategy for @@ -926,13 +924,8 @@ get_useful_pathkeys_for_relation(PlannerInfo *root, RelOptInfo *rel) * getting it to be sorted by all of those pathkeys. We'll just * end up resorting the entire data set. So, unless we can push * down all of the query pathkeys, forget it. - * - * is_foreign_expr would detect volatile expressions as well, but - * checking ec_has_volatile here saves some cycles. */ - if (pathkey_ec->ec_has_volatile || - !(em_expr = find_em_expr_for_rel(pathkey_ec, rel)) || - !is_foreign_expr(root, rel, em_expr)) + if (!is_foreign_pathkey(root, rel, pathkey)) { query_pathkeys_ok = false; break; @@ -6540,9 +6533,9 @@ add_foreign_ordered_paths(PlannerInfo *root, RelOptInfo *input_rel, return; /* Get the sort expression for the pathkey_ec */ - sort_expr = find_em_expr_for_input_target(root, - pathkey_ec, - input_rel->reltarget); + sort_expr = find_em_for_input_target(root, + pathkey_ec, + input_rel->reltarget)->em_expr; /* If it's unsafe to remote, we cannot push down the final sort */ if (!is_foreign_expr(root, input_rel, sort_expr)) @@ -7332,13 +7325,12 @@ conversion_error_callback(void *arg) } /* - * Find an equivalence class member expression to be computed as a sort column - * in the given target. + * Find an equivalence class member to be computed as a sort column in the + * given target. */ -Expr * -find_em_expr_for_input_target(PlannerInfo *root, - EquivalenceClass *ec, - PathTarget *target) +EquivalenceMember * +find_em_for_input_target(PlannerInfo *root, EquivalenceClass *ec, + PathTarget *target) { ListCell *lc1; int i; @@ -7383,7 +7375,7 @@ find_em_expr_for_input_target(PlannerInfo *root, em_expr = ((RelabelType *) em_expr)->arg; if (equal(em_expr, expr)) - return em->em_expr; + return em; } i++; diff --git a/contrib/postgres_fdw/postgres_fdw.h b/contrib/postgres_fdw/postgres_fdw.h index ca83306af9..9930226b6f 100644 --- a/contrib/postgres_fdw/postgres_fdw.h +++ b/contrib/postgres_fdw/postgres_fdw.h @@ -171,6 +171,9 @@ extern bool is_foreign_expr(PlannerInfo *root, extern bool is_foreign_param(PlannerInfo *root, RelOptInfo *baserel, Expr *expr); +extern bool is_foreign_pathkey(PlannerInfo *root, + RelOptInfo *baserel, + PathKey *pathkey); extern void deparseInsertSql(StringInfo buf, RangeTblEntry *rte, Index rtindex, Relation rel, List *targetAttrs, bool doNothing, @@ -213,10 +216,10 @@ extern void deparseTruncateSql(StringInfo buf, DropBehavior behavior, bool restart_seqs); extern void deparseStringLiteral(StringInfo buf, const char *val); -extern Expr *find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel); -extern Expr *find_em_expr_for_input_target(PlannerInfo *root, - EquivalenceClass *ec, - PathTarget *target); +extern EquivalenceMember *find_em_for_rel(EquivalenceClass *ec, RelOptInfo *rel); +extern EquivalenceMember *find_em_for_input_target(PlannerInfo *root, + EquivalenceClass *ec, + PathTarget *target); extern List *build_tlist_to_deparse(RelOptInfo *foreignrel); extern void deparseSelectStmtForRel(StringInfo buf, PlannerInfo *root, RelOptInfo *foreignrel, List *tlist, diff --git a/contrib/postgres_fdw/sql/postgres_fdw.sql b/contrib/postgres_fdw/sql/postgres_fdw.sql index 30b5175da5..1bbe1212c4 100644 --- a/contrib/postgres_fdw/sql/postgres_fdw.sql +++ b/contrib/postgres_fdw/sql/postgres_fdw.sql @@ -902,6 +902,10 @@ create operator class my_op_class for type int using btree family my_op_family a explain (verbose, costs off) select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 and c1 < 100 group by c2; +-- Ensure that we don't push down an ORDER BY with a non-shippable operator +explain (verbose, costs off) +select * from ft2 order by c1 using operator(public.<^); + -- Update local stats on ft2 ANALYZE ft2; @@ -919,6 +923,10 @@ explain (verbose, costs off) select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 and c1 < 100 group by c2; select array_agg(c1 order by c1 using operator(public.<^)) from ft2 where c2 = 6 and c1 < 100 group by c2; +-- Ensure that the ORDER BY is pushed to the foreign server +explain (verbose, costs off) +select * from ft2 order by c1 using operator(public.<^); + -- Remove from extension alter extension postgres_fdw drop operator class my_op_class using btree; alter extension postgres_fdw drop function my_op_cmp(a int, b int); diff --git a/src/backend/optimizer/path/equivclass.c b/src/backend/optimizer/path/equivclass.c index 6f1abbe47d..b367f18eab 100644 --- a/src/backend/optimizer/path/equivclass.c +++ b/src/backend/optimizer/path/equivclass.c @@ -932,11 +932,11 @@ is_exprlist_member(Expr *node, List *exprs) } /* - * Find an equivalence class member expression, all of whose Vars, come from - * the indicated relation. + * Find an equivalence class member, all of whose Vars, come from the + * indicated relation. */ -Expr * -find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel) +EquivalenceMember * +find_em_for_rel(EquivalenceClass *ec, RelOptInfo *rel) { ListCell *lc_em; @@ -952,7 +952,7 @@ find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel) * taken entirely from this relation, we'll be content to choose * any one of those. */ - return em->em_expr; + return em; } } @@ -960,6 +960,22 @@ find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel) return NULL; } +/* + * Find an equivalence class member expression, all of whose Vars, come from + * the indicated relation. + */ +Expr * +find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel) +{ + EquivalenceMember *em = find_em_for_rel(ec, rel); + + if (em != NULL) + return em->em_expr; + + return NULL; +} + + /* * relation_can_be_sorted_early * Can this relation be sorted on this EC before the final output step? diff --git a/src/include/optimizer/paths.h b/src/include/optimizer/paths.h index f1d111063c..5a2bbc87e1 100644 --- a/src/include/optimizer/paths.h +++ b/src/include/optimizer/paths.h @@ -144,6 +144,8 @@ extern EquivalenceMember *find_computable_ec_member(PlannerInfo *root, Relids relids, bool require_parallel_safe); extern Expr *find_em_expr_for_rel(EquivalenceClass *ec, RelOptInfo *rel); +extern EquivalenceMember *find_em_for_rel(EquivalenceClass *ec, + RelOptInfo *rel); extern bool relation_can_be_sorted_early(PlannerInfo *root, RelOptInfo *rel, EquivalenceClass *ec, bool require_parallel_safe); -- 2.33.0 --nextPart4945189.lnZSD0nRIs-- ^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH 2/2] Add has_large_object_privilege function @ 2024-07-02 06:12 Yugo Nagata <nagata@sraoss.co.jp> 0 siblings, 0 replies; 4+ messages in thread From: Yugo Nagata @ 2024-07-02 06:12 UTC (permalink / raw) This function is for checking whether a user has the privilege on a large object. There are three variations whose arguments are combinations of large object OID with user name, user OID, or implicit user (current_user). It returns NULL if not-existing large object id is specified, and false if non-existing user id is specified, and raises an error if non-existing user name is specified. These behavior is similar with has_table_privilege. --- doc/src/sgml/func.sgml | 18 +++ src/backend/utils/adt/acl.c | 140 +++++++++++++++++++ src/include/catalog/pg_proc.dat | 13 ++ src/test/regress/expected/privileges.out | 169 +++++++++++++++++++++++ src/test/regress/sql/privileges.sql | 44 ++++++ 5 files changed, 384 insertions(+) diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index f1f22a1960..e06135ca9a 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -24975,6 +24975,24 @@ SELECT has_function_privilege('joeuser', 'myfunc(int, text)', 'execute'); </para></entry> </row> + <row> + <entry role="func_table_entry"><para role="func_signature"> + <indexterm> + <primary>has_large_object_privilege</primary> + </indexterm> + <function>has_large_object_privilege</function> ( + <optional> <parameter>user</parameter> <type>name</type> or <type>oid</type>, </optional> + <parameter>largeobject</parameter> <type>oid</type>, + <parameter>privilege</parameter> <type>text</type> ) + <returnvalue>boolean</returnvalue> + </para> + <para> + Does user have privilege for large object? + Allowable privilege types are + <literal>SELECT</literal> and <literal>UPDATE</literal>. + </para></entry> + </row> + <row> <entry role="func_table_entry"><para role="func_signature"> <indexterm> diff --git a/src/backend/utils/adt/acl.c b/src/backend/utils/adt/acl.c index d7b39140b3..87f2b6c212 100644 --- a/src/backend/utils/adt/acl.c +++ b/src/backend/utils/adt/acl.c @@ -26,6 +26,7 @@ #include "catalog/pg_foreign_data_wrapper.h" #include "catalog/pg_foreign_server.h" #include "catalog/pg_language.h" +#include "catalog/pg_largeobject.h" #include "catalog/pg_namespace.h" #include "catalog/pg_proc.h" #include "catalog/pg_tablespace.h" @@ -39,6 +40,7 @@ #include "lib/bloomfilter.h" #include "lib/qunique.h" #include "miscadmin.h" +#include "storage/large_object.h" #include "utils/acl.h" #include "utils/array.h" #include "utils/builtins.h" @@ -46,6 +48,7 @@ #include "utils/inval.h" #include "utils/lsyscache.h" #include "utils/memutils.h" +#include "utils/snapmgr.h" #include "utils/syscache.h" #include "utils/varlena.h" @@ -124,6 +127,7 @@ static AclMode convert_tablespace_priv_string(text *priv_type_text); static Oid convert_type_name(text *typename); static AclMode convert_type_priv_string(text *priv_type_text); static AclMode convert_parameter_priv_string(text *priv_text); +static AclMode convert_large_object_priv_string(text *priv_text); static AclMode convert_role_priv_string(text *priv_type_text); static AclResult pg_role_aclcheck(Oid role_oid, Oid roleid, AclMode mode); @@ -4669,6 +4673,142 @@ convert_parameter_priv_string(text *priv_text) return convert_any_priv_string(priv_text, parameter_priv_map); } +/* + * has_large_objec_privilege variants + * These are all named "has_large_object_privilege" at the SQL level. + * They take various combinations of large object OID with + * user name, user OID, or implicit user = current_user. + * + * The result is a boolean value: true if user has been granted + * the indicated privilege or false if not. + */ + +/* + * has_large_object_privilege_name_id + * Check user privileges on a large object given + * name username, large object oid, and text priv name. + */ +Datum +has_large_object_privilege_name_id(PG_FUNCTION_ARGS) +{ + Name username = PG_GETARG_NAME(0); + Oid roleid = get_role_oid_or_public(NameStr(*username)); + Oid lobjId = PG_GETARG_OID(1); + text *priv_type_text = PG_GETARG_TEXT_PP(2); + AclMode mode; + AclResult aclresult; + Snapshot snapshot = NULL; + + mode = convert_large_object_priv_string(priv_type_text); + + if (mode & ACL_UPDATE) + snapshot = NULL; + else + snapshot = GetActiveSnapshot(); + + if (!LargeObjectExistsWithSnapshot(lobjId, snapshot)) + PG_RETURN_NULL(); + + if (lo_compat_privileges) + PG_RETURN_BOOL(true); + + aclresult = pg_largeobject_aclcheck_snapshot(lobjId, + roleid, + mode, + snapshot); + + PG_RETURN_BOOL(aclresult == ACLCHECK_OK); +} + +/* +okui chiba * has_large_object_privilege_id + * Check user privileges on a large object given + * large object oid, and text priv name. + * current_user is assumed + */ +Datum +has_large_object_privilege_id(PG_FUNCTION_ARGS) +{ + Oid lobjId = PG_GETARG_OID(0); + Oid roleid = GetUserId(); + text *priv_type_text = PG_GETARG_TEXT_PP(1); + AclMode mode; + AclResult aclresult; + Snapshot snapshot = NULL; + + mode = convert_large_object_priv_string(priv_type_text); + + if (mode & ACL_UPDATE) + snapshot = NULL; + else + snapshot = GetActiveSnapshot(); + + if (!LargeObjectExistsWithSnapshot(lobjId, snapshot)) + PG_RETURN_NULL(); + + if (lo_compat_privileges) + PG_RETURN_BOOL(true); + + aclresult = pg_largeobject_aclcheck_snapshot(lobjId, + roleid, + mode, + snapshot); + + PG_RETURN_BOOL(aclresult == ACLCHECK_OK); +} + +/* + * has_large_object_privilege_id_id + * Check user privileges on a large object given + * roleid, large object oid, and text priv name. + */ +Datum +has_large_object_privilege_id_id(PG_FUNCTION_ARGS) +{ + Oid roleid = PG_GETARG_OID(0); + Oid lobjId = PG_GETARG_OID(1); + text *priv_type_text = PG_GETARG_TEXT_PP(2); + AclMode mode; + AclResult aclresult; + Snapshot snapshot = NULL; + + mode = convert_large_object_priv_string(priv_type_text); + + if (mode & ACL_UPDATE) + snapshot = NULL; + else + snapshot = GetActiveSnapshot(); + + if (!LargeObjectExistsWithSnapshot(lobjId, snapshot)) + PG_RETURN_NULL(); + + if (lo_compat_privileges) + PG_RETURN_BOOL(true); + + aclresult = pg_largeobject_aclcheck_snapshot(lobjId, + roleid, + mode, + snapshot); + + PG_RETURN_BOOL(aclresult == ACLCHECK_OK); +} + +/* + * convert_large_object_priv_string + * Convert text string to AclMode value. + */ +static AclMode +convert_large_object_priv_string(text *priv_text) +{ + static const priv_map parameter_priv_map[] = { + {"SELECT", ACL_SELECT}, + {"UPDATE", ACL_UPDATE}, + {NULL, 0} + }; + + return convert_any_priv_string(priv_text, parameter_priv_map); +} + /* * pg_has_role variants * These are all named "pg_has_role" at the SQL level. diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index d4ac578ae6..5b0ef8df68 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -5300,6 +5300,19 @@ prorettype => 'bool', proargtypes => 'oid text', prosrc => 'has_any_column_privilege_id' }, +{ oid => '4551', descr => 'user privilege on large objct by username, large object oid', + proname => 'has_large_object_privilege', procost => '10', provolatile => 's', + prorettype => 'bool', proargtypes => 'name oid text', + prosrc => 'has_large_object_privilege_name_id' }, +{ oid => '4552', descr => 'current privilege on large objct by large object oid', + proname => 'has_large_object_privilege', procost => '10', provolatile => 's', + prorettype => 'bool', proargtypes => 'oid text', + prosrc => 'has_large_object_privilege_id' }, +{ oid => '4553', descr => 'user privilege on large objct by user oid, large object oid', + proname => 'has_large_object_privilege', procost => '10', provolatile => 's', + prorettype => 'bool', proargtypes => 'oid oid text', + prosrc => 'has_large_object_privilege_id_id' }, + { oid => '3355', descr => 'I/O', proname => 'pg_ndistinct_in', prorettype => 'pg_ndistinct', proargtypes => 'cstring', prosrc => 'pg_ndistinct_in' }, diff --git a/src/test/regress/expected/privileges.out b/src/test/regress/expected/privileges.out index eb4b762ea1..7933601590 100644 --- a/src/test/regress/expected/privileges.out +++ b/src/test/regress/expected/privileges.out @@ -2024,10 +2024,167 @@ SELECT lo_truncate(lo_open(2001, x'20000'::int), 10); 0 (1 row) +-- has_large_object_privilege function +-- superuser +\c - +SELECT has_large_object_privilege(1001, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1003, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1004, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1001, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1003, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1004, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +-- not-existing large object +SELECT has_large_object_privilege(9999, 'SELECT'); -- NULL + has_large_object_privilege +---------------------------- + +(1 row) + +-- not-existing user +SELECT has_large_object_privilege(-99999, 1001, 'SELECT'); -- false + has_large_object_privilege +---------------------------- + t +(1 row) + +-- non-superuser +SET SESSION AUTHORIZATION regress_priv_user2; +SELECT has_large_object_privilege(1001, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'SELECT'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege(1003, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1004, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1001, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'UPDATE'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege(1003, 'UPDATE'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege(1004, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 1001, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 1003, 'SELECT'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 1005, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 1005, 'UPDATE'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 2001, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + -- compatibility mode in largeobject permission \c - SET lo_compat_privileges = false; -- default setting SET SESSION AUTHORIZATION regress_priv_user4; +SELECT has_large_object_privilege(1002, 'SELECT'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege(1002, 'UPDATE'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + SELECT loread(lo_open(1002, x'40000'::int), 32); -- to be denied ERROR: permission denied for large object 1002 SELECT lowrite(lo_open(1002, x'20000'::int), 'abcd'); -- to be denied @@ -2047,6 +2204,18 @@ ERROR: permission denied for function lo_import \c - SET lo_compat_privileges = true; -- compatibility mode SET SESSION AUTHORIZATION regress_priv_user4; +SELECT has_large_object_privilege(1002, 'SELECT'); -- true + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'UPDATE'); -- true + has_large_object_privilege +---------------------------- + t +(1 row) + SELECT loread(lo_open(1002, x'40000'::int), 32); loread -------- diff --git a/src/test/regress/sql/privileges.sql b/src/test/regress/sql/privileges.sql index eeb4c00292..6b509e993a 100644 --- a/src/test/regress/sql/privileges.sql +++ b/src/test/regress/sql/privileges.sql @@ -1318,11 +1318,52 @@ SELECT loread(lo_open(1005, x'40000'::int), 32); SELECT lo_truncate(lo_open(1005, x'20000'::int), 10); -- to be denied SELECT lo_truncate(lo_open(2001, x'20000'::int), 10); +-- has_large_object_privilege function + +-- superuser +\c - +SELECT has_large_object_privilege(1001, 'SELECT'); +SELECT has_large_object_privilege(1002, 'SELECT'); +SELECT has_large_object_privilege(1003, 'SELECT'); +SELECT has_large_object_privilege(1004, 'SELECT'); + +SELECT has_large_object_privilege(1001, 'UPDATE'); +SELECT has_large_object_privilege(1002, 'UPDATE'); +SELECT has_large_object_privilege(1003, 'UPDATE'); +SELECT has_large_object_privilege(1004, 'UPDATE'); + +-- not-existing large object +SELECT has_large_object_privilege(9999, 'SELECT'); -- NULL +-- not-existing user +SELECT has_large_object_privilege(-99999, 1001, 'SELECT'); -- false + +-- non-superuser +SET SESSION AUTHORIZATION regress_priv_user2; +SELECT has_large_object_privilege(1001, 'SELECT'); +SELECT has_large_object_privilege(1002, 'SELECT'); -- false +SELECT has_large_object_privilege(1003, 'SELECT'); +SELECT has_large_object_privilege(1004, 'SELECT'); + +SELECT has_large_object_privilege(1001, 'UPDATE'); +SELECT has_large_object_privilege(1002, 'UPDATE'); -- false +SELECT has_large_object_privilege(1003, 'UPDATE'); -- false +SELECT has_large_object_privilege(1004, 'UPDATE'); + +SELECT has_large_object_privilege('regress_priv_user3', 1001, 'SELECT'); +SELECT has_large_object_privilege('regress_priv_user3', 1003, 'SELECT'); -- false +SELECT has_large_object_privilege('regress_priv_user3', 1005, 'SELECT'); + +SELECT has_large_object_privilege('regress_priv_user3', 1005, 'UPDATE'); -- false +SELECT has_large_object_privilege('regress_priv_user3', 2001, 'UPDATE'); + -- compatibility mode in largeobject permission \c - SET lo_compat_privileges = false; -- default setting SET SESSION AUTHORIZATION regress_priv_user4; +SELECT has_large_object_privilege(1002, 'SELECT'); -- false +SELECT has_large_object_privilege(1002, 'UPDATE'); -- false + SELECT loread(lo_open(1002, x'40000'::int), 32); -- to be denied SELECT lowrite(lo_open(1002, x'20000'::int), 'abcd'); -- to be denied SELECT lo_truncate(lo_open(1002, x'20000'::int), 10); -- to be denied @@ -1336,6 +1377,9 @@ SELECT lo_import('/dev/null', 2003); -- to be denied SET lo_compat_privileges = true; -- compatibility mode SET SESSION AUTHORIZATION regress_priv_user4; +SELECT has_large_object_privilege(1002, 'SELECT'); -- true +SELECT has_large_object_privilege(1002, 'UPDATE'); -- true + SELECT loread(lo_open(1002, x'40000'::int), 32); SELECT lowrite(lo_open(1002, x'20000'::int), 'abcd'); SELECT lo_truncate(lo_open(1002, x'20000'::int), 10); -- 2.25.1 --Multipart=_Tue__2_Jul_2024_16_34_44_+0900_Lpc86p3xobkG.QGS Content-Type: text/x-diff; name="0001-Deduplicate-codes-of-LargeObjectExists-and-mvLargeOb.patch" Content-Disposition: attachment; filename="0001-Deduplicate-codes-of-LargeObjectExists-and-mvLargeOb.patch" Content-Transfer-Encoding: 7bit ^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH 2/2] Add has_large_object_privilege function @ 2024-07-02 06:12 Yugo Nagata <nagata@sraoss.co.jp> 0 siblings, 0 replies; 4+ messages in thread From: Yugo Nagata @ 2024-07-02 06:12 UTC (permalink / raw) This function is for checking whether a user has the privilege on a large object. There are three variations whose arguments are combinations of large object OID with user name, user OID, or implicit user (current_user). It returns NULL if not-existing large object id is specified, and false if non-existing user id is specified, and raises an error if non-existing user name is specified. These behavior is similar with has_table_privilege. --- doc/src/sgml/func.sgml | 18 +++ src/backend/utils/adt/acl.c | 140 +++++++++++++++++++ src/include/catalog/pg_proc.dat | 13 ++ src/test/regress/expected/privileges.out | 169 +++++++++++++++++++++++ src/test/regress/sql/privileges.sql | 44 ++++++ 5 files changed, 384 insertions(+) diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index f1f22a1960..e06135ca9a 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -24975,6 +24975,24 @@ SELECT has_function_privilege('joeuser', 'myfunc(int, text)', 'execute'); </para></entry> </row> + <row> + <entry role="func_table_entry"><para role="func_signature"> + <indexterm> + <primary>has_large_object_privilege</primary> + </indexterm> + <function>has_large_object_privilege</function> ( + <optional> <parameter>user</parameter> <type>name</type> or <type>oid</type>, </optional> + <parameter>largeobject</parameter> <type>oid</type>, + <parameter>privilege</parameter> <type>text</type> ) + <returnvalue>boolean</returnvalue> + </para> + <para> + Does user have privilege for large object? + Allowable privilege types are + <literal>SELECT</literal> and <literal>UPDATE</literal>. + </para></entry> + </row> + <row> <entry role="func_table_entry"><para role="func_signature"> <indexterm> diff --git a/src/backend/utils/adt/acl.c b/src/backend/utils/adt/acl.c index d7b39140b3..87f2b6c212 100644 --- a/src/backend/utils/adt/acl.c +++ b/src/backend/utils/adt/acl.c @@ -26,6 +26,7 @@ #include "catalog/pg_foreign_data_wrapper.h" #include "catalog/pg_foreign_server.h" #include "catalog/pg_language.h" +#include "catalog/pg_largeobject.h" #include "catalog/pg_namespace.h" #include "catalog/pg_proc.h" #include "catalog/pg_tablespace.h" @@ -39,6 +40,7 @@ #include "lib/bloomfilter.h" #include "lib/qunique.h" #include "miscadmin.h" +#include "storage/large_object.h" #include "utils/acl.h" #include "utils/array.h" #include "utils/builtins.h" @@ -46,6 +48,7 @@ #include "utils/inval.h" #include "utils/lsyscache.h" #include "utils/memutils.h" +#include "utils/snapmgr.h" #include "utils/syscache.h" #include "utils/varlena.h" @@ -124,6 +127,7 @@ static AclMode convert_tablespace_priv_string(text *priv_type_text); static Oid convert_type_name(text *typename); static AclMode convert_type_priv_string(text *priv_type_text); static AclMode convert_parameter_priv_string(text *priv_text); +static AclMode convert_large_object_priv_string(text *priv_text); static AclMode convert_role_priv_string(text *priv_type_text); static AclResult pg_role_aclcheck(Oid role_oid, Oid roleid, AclMode mode); @@ -4669,6 +4673,142 @@ convert_parameter_priv_string(text *priv_text) return convert_any_priv_string(priv_text, parameter_priv_map); } +/* + * has_large_objec_privilege variants + * These are all named "has_large_object_privilege" at the SQL level. + * They take various combinations of large object OID with + * user name, user OID, or implicit user = current_user. + * + * The result is a boolean value: true if user has been granted + * the indicated privilege or false if not. + */ + +/* + * has_large_object_privilege_name_id + * Check user privileges on a large object given + * name username, large object oid, and text priv name. + */ +Datum +has_large_object_privilege_name_id(PG_FUNCTION_ARGS) +{ + Name username = PG_GETARG_NAME(0); + Oid roleid = get_role_oid_or_public(NameStr(*username)); + Oid lobjId = PG_GETARG_OID(1); + text *priv_type_text = PG_GETARG_TEXT_PP(2); + AclMode mode; + AclResult aclresult; + Snapshot snapshot = NULL; + + mode = convert_large_object_priv_string(priv_type_text); + + if (mode & ACL_UPDATE) + snapshot = NULL; + else + snapshot = GetActiveSnapshot(); + + if (!LargeObjectExistsWithSnapshot(lobjId, snapshot)) + PG_RETURN_NULL(); + + if (lo_compat_privileges) + PG_RETURN_BOOL(true); + + aclresult = pg_largeobject_aclcheck_snapshot(lobjId, + roleid, + mode, + snapshot); + + PG_RETURN_BOOL(aclresult == ACLCHECK_OK); +} + +/* +okui chiba * has_large_object_privilege_id + * Check user privileges on a large object given + * large object oid, and text priv name. + * current_user is assumed + */ +Datum +has_large_object_privilege_id(PG_FUNCTION_ARGS) +{ + Oid lobjId = PG_GETARG_OID(0); + Oid roleid = GetUserId(); + text *priv_type_text = PG_GETARG_TEXT_PP(1); + AclMode mode; + AclResult aclresult; + Snapshot snapshot = NULL; + + mode = convert_large_object_priv_string(priv_type_text); + + if (mode & ACL_UPDATE) + snapshot = NULL; + else + snapshot = GetActiveSnapshot(); + + if (!LargeObjectExistsWithSnapshot(lobjId, snapshot)) + PG_RETURN_NULL(); + + if (lo_compat_privileges) + PG_RETURN_BOOL(true); + + aclresult = pg_largeobject_aclcheck_snapshot(lobjId, + roleid, + mode, + snapshot); + + PG_RETURN_BOOL(aclresult == ACLCHECK_OK); +} + +/* + * has_large_object_privilege_id_id + * Check user privileges on a large object given + * roleid, large object oid, and text priv name. + */ +Datum +has_large_object_privilege_id_id(PG_FUNCTION_ARGS) +{ + Oid roleid = PG_GETARG_OID(0); + Oid lobjId = PG_GETARG_OID(1); + text *priv_type_text = PG_GETARG_TEXT_PP(2); + AclMode mode; + AclResult aclresult; + Snapshot snapshot = NULL; + + mode = convert_large_object_priv_string(priv_type_text); + + if (mode & ACL_UPDATE) + snapshot = NULL; + else + snapshot = GetActiveSnapshot(); + + if (!LargeObjectExistsWithSnapshot(lobjId, snapshot)) + PG_RETURN_NULL(); + + if (lo_compat_privileges) + PG_RETURN_BOOL(true); + + aclresult = pg_largeobject_aclcheck_snapshot(lobjId, + roleid, + mode, + snapshot); + + PG_RETURN_BOOL(aclresult == ACLCHECK_OK); +} + +/* + * convert_large_object_priv_string + * Convert text string to AclMode value. + */ +static AclMode +convert_large_object_priv_string(text *priv_text) +{ + static const priv_map parameter_priv_map[] = { + {"SELECT", ACL_SELECT}, + {"UPDATE", ACL_UPDATE}, + {NULL, 0} + }; + + return convert_any_priv_string(priv_text, parameter_priv_map); +} + /* * pg_has_role variants * These are all named "pg_has_role" at the SQL level. diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index d4ac578ae6..5b0ef8df68 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -5300,6 +5300,19 @@ prorettype => 'bool', proargtypes => 'oid text', prosrc => 'has_any_column_privilege_id' }, +{ oid => '4551', descr => 'user privilege on large objct by username, large object oid', + proname => 'has_large_object_privilege', procost => '10', provolatile => 's', + prorettype => 'bool', proargtypes => 'name oid text', + prosrc => 'has_large_object_privilege_name_id' }, +{ oid => '4552', descr => 'current privilege on large objct by large object oid', + proname => 'has_large_object_privilege', procost => '10', provolatile => 's', + prorettype => 'bool', proargtypes => 'oid text', + prosrc => 'has_large_object_privilege_id' }, +{ oid => '4553', descr => 'user privilege on large objct by user oid, large object oid', + proname => 'has_large_object_privilege', procost => '10', provolatile => 's', + prorettype => 'bool', proargtypes => 'oid oid text', + prosrc => 'has_large_object_privilege_id_id' }, + { oid => '3355', descr => 'I/O', proname => 'pg_ndistinct_in', prorettype => 'pg_ndistinct', proargtypes => 'cstring', prosrc => 'pg_ndistinct_in' }, diff --git a/src/test/regress/expected/privileges.out b/src/test/regress/expected/privileges.out index eb4b762ea1..7933601590 100644 --- a/src/test/regress/expected/privileges.out +++ b/src/test/regress/expected/privileges.out @@ -2024,10 +2024,167 @@ SELECT lo_truncate(lo_open(2001, x'20000'::int), 10); 0 (1 row) +-- has_large_object_privilege function +-- superuser +\c - +SELECT has_large_object_privilege(1001, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1003, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1004, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1001, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1003, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1004, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +-- not-existing large object +SELECT has_large_object_privilege(9999, 'SELECT'); -- NULL + has_large_object_privilege +---------------------------- + +(1 row) + +-- not-existing user +SELECT has_large_object_privilege(-99999, 1001, 'SELECT'); -- false + has_large_object_privilege +---------------------------- + t +(1 row) + +-- non-superuser +SET SESSION AUTHORIZATION regress_priv_user2; +SELECT has_large_object_privilege(1001, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'SELECT'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege(1003, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1004, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1001, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'UPDATE'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege(1003, 'UPDATE'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege(1004, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 1001, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 1003, 'SELECT'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 1005, 'SELECT'); + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 1005, 'UPDATE'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege('regress_priv_user3', 2001, 'UPDATE'); + has_large_object_privilege +---------------------------- + t +(1 row) + -- compatibility mode in largeobject permission \c - SET lo_compat_privileges = false; -- default setting SET SESSION AUTHORIZATION regress_priv_user4; +SELECT has_large_object_privilege(1002, 'SELECT'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + +SELECT has_large_object_privilege(1002, 'UPDATE'); -- false + has_large_object_privilege +---------------------------- + f +(1 row) + SELECT loread(lo_open(1002, x'40000'::int), 32); -- to be denied ERROR: permission denied for large object 1002 SELECT lowrite(lo_open(1002, x'20000'::int), 'abcd'); -- to be denied @@ -2047,6 +2204,18 @@ ERROR: permission denied for function lo_import \c - SET lo_compat_privileges = true; -- compatibility mode SET SESSION AUTHORIZATION regress_priv_user4; +SELECT has_large_object_privilege(1002, 'SELECT'); -- true + has_large_object_privilege +---------------------------- + t +(1 row) + +SELECT has_large_object_privilege(1002, 'UPDATE'); -- true + has_large_object_privilege +---------------------------- + t +(1 row) + SELECT loread(lo_open(1002, x'40000'::int), 32); loread -------- diff --git a/src/test/regress/sql/privileges.sql b/src/test/regress/sql/privileges.sql index eeb4c00292..6b509e993a 100644 --- a/src/test/regress/sql/privileges.sql +++ b/src/test/regress/sql/privileges.sql @@ -1318,11 +1318,52 @@ SELECT loread(lo_open(1005, x'40000'::int), 32); SELECT lo_truncate(lo_open(1005, x'20000'::int), 10); -- to be denied SELECT lo_truncate(lo_open(2001, x'20000'::int), 10); +-- has_large_object_privilege function + +-- superuser +\c - +SELECT has_large_object_privilege(1001, 'SELECT'); +SELECT has_large_object_privilege(1002, 'SELECT'); +SELECT has_large_object_privilege(1003, 'SELECT'); +SELECT has_large_object_privilege(1004, 'SELECT'); + +SELECT has_large_object_privilege(1001, 'UPDATE'); +SELECT has_large_object_privilege(1002, 'UPDATE'); +SELECT has_large_object_privilege(1003, 'UPDATE'); +SELECT has_large_object_privilege(1004, 'UPDATE'); + +-- not-existing large object +SELECT has_large_object_privilege(9999, 'SELECT'); -- NULL +-- not-existing user +SELECT has_large_object_privilege(-99999, 1001, 'SELECT'); -- false + +-- non-superuser +SET SESSION AUTHORIZATION regress_priv_user2; +SELECT has_large_object_privilege(1001, 'SELECT'); +SELECT has_large_object_privilege(1002, 'SELECT'); -- false +SELECT has_large_object_privilege(1003, 'SELECT'); +SELECT has_large_object_privilege(1004, 'SELECT'); + +SELECT has_large_object_privilege(1001, 'UPDATE'); +SELECT has_large_object_privilege(1002, 'UPDATE'); -- false +SELECT has_large_object_privilege(1003, 'UPDATE'); -- false +SELECT has_large_object_privilege(1004, 'UPDATE'); + +SELECT has_large_object_privilege('regress_priv_user3', 1001, 'SELECT'); +SELECT has_large_object_privilege('regress_priv_user3', 1003, 'SELECT'); -- false +SELECT has_large_object_privilege('regress_priv_user3', 1005, 'SELECT'); + +SELECT has_large_object_privilege('regress_priv_user3', 1005, 'UPDATE'); -- false +SELECT has_large_object_privilege('regress_priv_user3', 2001, 'UPDATE'); + -- compatibility mode in largeobject permission \c - SET lo_compat_privileges = false; -- default setting SET SESSION AUTHORIZATION regress_priv_user4; +SELECT has_large_object_privilege(1002, 'SELECT'); -- false +SELECT has_large_object_privilege(1002, 'UPDATE'); -- false + SELECT loread(lo_open(1002, x'40000'::int), 32); -- to be denied SELECT lowrite(lo_open(1002, x'20000'::int), 'abcd'); -- to be denied SELECT lo_truncate(lo_open(1002, x'20000'::int), 10); -- to be denied @@ -1336,6 +1377,9 @@ SELECT lo_import('/dev/null', 2003); -- to be denied SET lo_compat_privileges = true; -- compatibility mode SET SESSION AUTHORIZATION regress_priv_user4; +SELECT has_large_object_privilege(1002, 'SELECT'); -- true +SELECT has_large_object_privilege(1002, 'UPDATE'); -- true + SELECT loread(lo_open(1002, x'40000'::int), 32); SELECT lowrite(lo_open(1002, x'20000'::int), 'abcd'); SELECT lo_truncate(lo_open(1002, x'20000'::int), 10); -- 2.25.1 --Multipart=_Tue__2_Jul_2024_16_34_44_+0900_Lpc86p3xobkG.QGS Content-Type: text/x-diff; name="0001-Deduplicate-codes-of-LargeObjectExists-and-mvLargeOb.patch" Content-Disposition: attachment; filename="0001-Deduplicate-codes-of-LargeObjectExists-and-mvLargeOb.patch" Content-Transfer-Encoding: 7bit ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-07-02 06:12 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-06 07:54 [PATCH v7] Fix orderby handling in postgres_fdw Ronan Dunklau <ronan.dunklau@aiven.io> 2021-09-06 07:54 [PATCH v8] Fix orderby handling in postgres_fdw Ronan Dunklau <ronan.dunklau@aiven.io> 2024-07-02 06:12 [PATCH 2/2] Add has_large_object_privilege function Yugo Nagata <nagata@sraoss.co.jp> 2024-07-02 06:12 [PATCH 2/2] Add has_large_object_privilege function Yugo Nagata <nagata@sraoss.co.jp>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox