agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH v3] retry ftruncate 3+ messages / 2 participants [nested] [flat]
* [PATCH v3] retry ftruncate @ 2022-07-01 15:16 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 3+ messages in thread From: Alvaro Herrera @ 2022-07-01 15:16 UTC (permalink / raw) --- src/backend/storage/ipc/dsm_impl.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/backend/storage/ipc/dsm_impl.c b/src/backend/storage/ipc/dsm_impl.c index 82b7978aeb..145a02204b 100644 --- a/src/backend/storage/ipc/dsm_impl.c +++ b/src/backend/storage/ipc/dsm_impl.c @@ -417,8 +417,19 @@ dsm_impl_posix_resize(int fd, off_t size) { int rc; - /* Truncate (or extend) the file to the requested size. */ - rc = ftruncate(fd, size); + /* + * Truncate (or extend) the file to the requested size. If we're + * interrupted by a signal, retry; have caller handle any other error. + */ + for (;;) + { + errno = 0; + rc = ftruncate(fd, size); + if (rc == 0) + break; + if (errno != EINTR) + return rc; + } /* * On Linux, a shm_open fd is backed by a tmpfs file. After resizing with -- 2.30.2 --f4m3wynkw6a6l5ma-- ^ permalink raw reply [nested|flat] 3+ messages in thread
* [PATCH v2] retry ftruncate @ 2022-07-01 15:16 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 3+ messages in thread From: Alvaro Herrera @ 2022-07-01 15:16 UTC (permalink / raw) --- src/backend/storage/ipc/dsm_impl.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/backend/storage/ipc/dsm_impl.c b/src/backend/storage/ipc/dsm_impl.c index 873867e856..4f35e7e3d1 100644 --- a/src/backend/storage/ipc/dsm_impl.c +++ b/src/backend/storage/ipc/dsm_impl.c @@ -362,8 +362,21 @@ dsm_impl_posix_resize(int fd, off_t size) { int rc; - /* Truncate (or extend) the file to the requested size. */ - rc = ftruncate(fd, size); + /* + * Truncate (or extend) the file to the requested size. We may get + * interrupted. If so, just retry unless there is an interrupt pending. + * This avoids the possibility of looping forever if another backend is + * repeatedly trying to interrupt us. + */ + for (;;) + { + errno = 0; + rc = ftruncate(fd, size); + if (rc == 0) + break; + if (errno != EINTR || ProcDiePending || QueryCancelPending) + return rc; + } /* * On Linux, a shm_open fd is backed by a tmpfs file. After resizing with -- 2.30.2 --knr42z5qyvhth5as-- ^ permalink raw reply [nested|flat] 3+ messages in thread
* [PATCH v9a 18/22] ci: Only use pwsh, not pwsh and powershell @ 2026-06-03 17:49 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 3+ messages in thread From: Andres Freund @ 2026-06-03 17:49 UTC (permalink / raw) --- .github/workflows/pg-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pg-ci.yml b/.github/workflows/pg-ci.yml index fa347847e02..3d8845bbda6 100644 --- a/.github/workflows/pg-ci.yml +++ b/.github/workflows/pg-ci.yml @@ -747,7 +747,7 @@ jobs: steps: - &windows_disable_defender_step name: Disable Windows Defender - shell: powershell + shell: pwsh run: | Set-MpPreference -DisableRealtimeMonitoring $true -SubmitSamplesConsent NeverSend -MAPSReporting Disable # Verify Defender status @@ -933,7 +933,7 @@ jobs: # robocopy returns 0-7 on success (with various "files copied" bits # set) and 8+ on real failure, so we have to translate its exit code. - name: Relocate MSYS2 to D - shell: powershell + shell: pwsh run: | robocopy C:\msys64 D:\msys64 /E /MT:16 /NJS /NJH /NFL /NDL /NP if ($LASTEXITCODE -ge 8) { exit $LASTEXITCODE } -- 2.54.0.380.gc69baaf57b --lyfxwjjve3vodszg Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v9a-0019-ci-windows-mingw-also-setup-hosts-file.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-06-03 17:49 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-07-01 15:16 [PATCH v3] retry ftruncate Alvaro Herrera <alvherre@alvh.no-ip.org> 2022-07-01 15:16 [PATCH v2] retry ftruncate Alvaro Herrera <alvherre@alvh.no-ip.org> 2026-06-03 17:49 [PATCH v9a 18/22] ci: Only use pwsh, not pwsh and powershell Andres Freund <andres@anarazel.de>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox