agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH v68 16/31] pgstat: add pg_stat_exists_stat() for easier testing. 4+ messages / 2 participants [nested] [flat]
* [PATCH v68 16/31] pgstat: add pg_stat_exists_stat() for easier testing. @ 2022-04-02 21:21 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2022-04-02 21:21 UTC (permalink / raw) Useful for tests. Author: Melanie Plageman <melanieplageman@gmail.com> --- src/include/catalog/pg_proc.dat | 6 ++++++ src/include/pgstat.h | 2 ++ src/backend/catalog/system_functions.sql | 2 ++ src/backend/postmaster/pgstat.c | 9 +++++++++ src/backend/utils/adt/pgstatfuncs.c | 17 +++++++++++++++++ 5 files changed, 36 insertions(+) diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index 12526c599e0..948e6504da0 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -5376,6 +5376,12 @@ proargmodes => '{i,o,o,o,o,o,o,o,o,o,o}', proargnames => '{slot_name,slot_name,spill_txns,spill_count,spill_bytes,stream_txns,stream_count,stream_bytes,total_txns,total_bytes,stats_reset}', prosrc => 'pg_stat_get_replication_slot' }, + +{ oid => '8384', descr => 'statistics: check if a stats object exists', + proname => 'pg_stat_exists_stat', provolatile => 'v', proparallel => 'r', + prorettype => 'bool', proargtypes => 'text oid oid', + prosrc => 'pg_stat_exists_stat' }, + { oid => '8523', descr => 'statistics: information about subscription stats', proname => 'pg_stat_get_subscription_stats', provolatile => 's', proparallel => 'r', diff --git a/src/include/pgstat.h b/src/include/pgstat.h index 3481ba5e262..fae3186c8eb 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -438,6 +438,8 @@ extern TimestampTz pgstat_get_stat_snapshot_timestamp(bool *have_snapshot); /* helpers */ extern PgStat_Kind pgstat_kind_from_str(char *kind_str); +extern bool pgstat_exists_entry(PgStat_Kind kind, Oid dboid, Oid objoid); + /* * Functions in pgstat_archiver.c diff --git a/src/backend/catalog/system_functions.sql b/src/backend/catalog/system_functions.sql index 81bac6f5812..07386f97f95 100644 --- a/src/backend/catalog/system_functions.sql +++ b/src/backend/catalog/system_functions.sql @@ -639,6 +639,8 @@ REVOKE EXECUTE ON FUNCTION pg_stat_reset_single_function_counters(oid) FROM publ REVOKE EXECUTE ON FUNCTION pg_stat_reset_replication_slot(text) FROM public; +REVOKE EXECUTE ON FUNCTION pg_stat_exists_stat(text, oid, oid) FROM public; + REVOKE EXECUTE ON FUNCTION pg_stat_reset_subscription_stats(oid) FROM public; REVOKE EXECUTE ON FUNCTION lo_import(text) FROM public; diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c index 0a0d64be829..8d619d114b2 100644 --- a/src/backend/postmaster/pgstat.c +++ b/src/backend/postmaster/pgstat.c @@ -835,6 +835,15 @@ pgstat_get_stat_snapshot_timestamp(bool *have_snapshot) return 0; } +bool +pgstat_exists_entry(PgStat_Kind kind, Oid dboid, Oid objoid) +{ + if (pgstat_kind_info_for(kind)->fixed_amount) + return true; + + return pgstat_get_entry_ref(kind, dboid, objoid, false, NULL) != NULL; +} + /* * Ensure snapshot for a kind of global stats exist. * diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index caaf0c5a672..2660bd1eb07 100644 --- a/src/backend/utils/adt/pgstatfuncs.c +++ b/src/backend/utils/adt/pgstatfuncs.c @@ -2395,3 +2395,20 @@ pg_stat_get_subscription_stats(PG_FUNCTION_ARGS) /* Returns the record as Datum */ PG_RETURN_DATUM(HeapTupleGetDatum(heap_form_tuple(tupdesc, values, nulls))); } + +/* + * Checks for presence of stats for object with provided kind, database oid, + * object oid. + * + * This is useful for regression tests, but not much more. + */ +Datum +pg_stat_exists_stat(PG_FUNCTION_ARGS) +{ + char *stats_type = text_to_cstring(PG_GETARG_TEXT_P(0)); + Oid dboid = PG_GETARG_OID(1); + Oid objoid = PG_GETARG_OID(2); + PgStat_Kind kind = pgstat_kind_from_str(stats_type); + + PG_RETURN_BOOL(pgstat_exists_entry(kind, dboid, objoid)); +} -- 2.35.1.677.gabf474a5dd --c4n45bccvxafocvc Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v68-0017-pgstat-wip-only-reset-pgstat-data-after-crash-re.patch" ^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH v69 13/28] pgstat: add pg_stat_exists_stat() for easier testing. @ 2022-04-02 21:21 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2022-04-02 21:21 UTC (permalink / raw) Useful for tests. Author: Melanie Plageman <melanieplageman@gmail.com> --- src/include/catalog/pg_proc.dat | 6 ++++++ src/include/pgstat.h | 2 ++ src/backend/catalog/system_functions.sql | 2 ++ src/backend/postmaster/pgstat.c | 9 +++++++++ src/backend/utils/adt/pgstatfuncs.c | 17 +++++++++++++++++ 5 files changed, 36 insertions(+) diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index 12526c599e0..948e6504da0 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -5376,6 +5376,12 @@ proargmodes => '{i,o,o,o,o,o,o,o,o,o,o}', proargnames => '{slot_name,slot_name,spill_txns,spill_count,spill_bytes,stream_txns,stream_count,stream_bytes,total_txns,total_bytes,stats_reset}', prosrc => 'pg_stat_get_replication_slot' }, + +{ oid => '8384', descr => 'statistics: check if a stats object exists', + proname => 'pg_stat_exists_stat', provolatile => 'v', proparallel => 'r', + prorettype => 'bool', proargtypes => 'text oid oid', + prosrc => 'pg_stat_exists_stat' }, + { oid => '8523', descr => 'statistics: information about subscription stats', proname => 'pg_stat_get_subscription_stats', provolatile => 's', proparallel => 'r', diff --git a/src/include/pgstat.h b/src/include/pgstat.h index 8386fb5f10d..79e5a579d03 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -438,6 +438,8 @@ extern TimestampTz pgstat_get_stat_snapshot_timestamp(bool *have_snapshot); /* helpers */ extern PgStat_Kind pgstat_kind_from_str(char *kind_str); +extern bool pgstat_exists_entry(PgStat_Kind kind, Oid dboid, Oid objoid); + /* * Functions in pgstat_archiver.c diff --git a/src/backend/catalog/system_functions.sql b/src/backend/catalog/system_functions.sql index 81bac6f5812..07386f97f95 100644 --- a/src/backend/catalog/system_functions.sql +++ b/src/backend/catalog/system_functions.sql @@ -639,6 +639,8 @@ REVOKE EXECUTE ON FUNCTION pg_stat_reset_single_function_counters(oid) FROM publ REVOKE EXECUTE ON FUNCTION pg_stat_reset_replication_slot(text) FROM public; +REVOKE EXECUTE ON FUNCTION pg_stat_exists_stat(text, oid, oid) FROM public; + REVOKE EXECUTE ON FUNCTION pg_stat_reset_subscription_stats(oid) FROM public; REVOKE EXECUTE ON FUNCTION lo_import(text) FROM public; diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c index bafbcff1eef..6727dc26db5 100644 --- a/src/backend/postmaster/pgstat.c +++ b/src/backend/postmaster/pgstat.c @@ -891,6 +891,15 @@ pgstat_get_stat_snapshot_timestamp(bool *have_snapshot) return 0; } +bool +pgstat_exists_entry(PgStat_Kind kind, Oid dboid, Oid objoid) +{ + if (pgstat_kind_info_for(kind)->fixed_amount) + return true; + + return pgstat_get_entry_ref(kind, dboid, objoid, false, NULL) != NULL; +} + /* * Ensure snapshot for a kind of global stats exist. * diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index caaf0c5a672..2660bd1eb07 100644 --- a/src/backend/utils/adt/pgstatfuncs.c +++ b/src/backend/utils/adt/pgstatfuncs.c @@ -2395,3 +2395,20 @@ pg_stat_get_subscription_stats(PG_FUNCTION_ARGS) /* Returns the record as Datum */ PG_RETURN_DATUM(HeapTupleGetDatum(heap_form_tuple(tupdesc, values, nulls))); } + +/* + * Checks for presence of stats for object with provided kind, database oid, + * object oid. + * + * This is useful for regression tests, but not much more. + */ +Datum +pg_stat_exists_stat(PG_FUNCTION_ARGS) +{ + char *stats_type = text_to_cstring(PG_GETARG_TEXT_P(0)); + Oid dboid = PG_GETARG_OID(1); + Oid objoid = PG_GETARG_OID(2); + PgStat_Kind kind = pgstat_kind_from_str(stats_type); + + PG_RETURN_BOOL(pgstat_exists_entry(kind, dboid, objoid)); +} -- 2.35.1.677.gabf474a5dd --be3jiks7ge4r32o3 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v69-0014-pgstat-test-transaction-behaviour-2PC-function-s.patch" ^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH v70 17/27] pgstat: add pg_stat_exists_stat() for easier testing. @ 2022-04-02 21:21 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2022-04-02 21:21 UTC (permalink / raw) Useful for tests. ATODO: bump catversion. Author: Melanie Plageman <melanieplageman@gmail.com> --- src/include/catalog/pg_proc.dat | 6 ++++++ src/include/pgstat.h | 2 ++ src/backend/catalog/system_functions.sql | 2 ++ src/backend/utils/activity/pgstat.c | 9 +++++++++ src/backend/utils/adt/pgstatfuncs.c | 17 +++++++++++++++++ 5 files changed, 36 insertions(+) diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat index 12526c599e0..948e6504da0 100644 --- a/src/include/catalog/pg_proc.dat +++ b/src/include/catalog/pg_proc.dat @@ -5376,6 +5376,12 @@ proargmodes => '{i,o,o,o,o,o,o,o,o,o,o}', proargnames => '{slot_name,slot_name,spill_txns,spill_count,spill_bytes,stream_txns,stream_count,stream_bytes,total_txns,total_bytes,stats_reset}', prosrc => 'pg_stat_get_replication_slot' }, + +{ oid => '8384', descr => 'statistics: check if a stats object exists', + proname => 'pg_stat_exists_stat', provolatile => 'v', proparallel => 'r', + prorettype => 'bool', proargtypes => 'text oid oid', + prosrc => 'pg_stat_exists_stat' }, + { oid => '8523', descr => 'statistics: information about subscription stats', proname => 'pg_stat_get_subscription_stats', provolatile => 's', proparallel => 'r', diff --git a/src/include/pgstat.h b/src/include/pgstat.h index 4ed8ef887ec..3de316912cf 100644 --- a/src/include/pgstat.h +++ b/src/include/pgstat.h @@ -438,6 +438,8 @@ extern TimestampTz pgstat_get_stat_snapshot_timestamp(bool *have_snapshot); /* helpers */ extern PgStat_Kind pgstat_kind_from_str(char *kind_str); +extern bool pgstat_exists_entry(PgStat_Kind kind, Oid dboid, Oid objoid); + /* * Functions in pgstat_archiver.c diff --git a/src/backend/catalog/system_functions.sql b/src/backend/catalog/system_functions.sql index 81bac6f5812..07386f97f95 100644 --- a/src/backend/catalog/system_functions.sql +++ b/src/backend/catalog/system_functions.sql @@ -639,6 +639,8 @@ REVOKE EXECUTE ON FUNCTION pg_stat_reset_single_function_counters(oid) FROM publ REVOKE EXECUTE ON FUNCTION pg_stat_reset_replication_slot(text) FROM public; +REVOKE EXECUTE ON FUNCTION pg_stat_exists_stat(text, oid, oid) FROM public; + REVOKE EXECUTE ON FUNCTION pg_stat_reset_subscription_stats(oid) FROM public; REVOKE EXECUTE ON FUNCTION lo_import(text) FROM public; diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c index 855f8cfa22b..5d6cae20a4d 100644 --- a/src/backend/utils/activity/pgstat.c +++ b/src/backend/utils/activity/pgstat.c @@ -868,6 +868,15 @@ pgstat_get_stat_snapshot_timestamp(bool *have_snapshot) return 0; } +bool +pgstat_exists_entry(PgStat_Kind kind, Oid dboid, Oid objoid) +{ + if (pgstat_kind_info_for(kind)->fixed_amount) + return true; + + return pgstat_get_entry_ref(kind, dboid, objoid, false, NULL) != NULL; +} + /* * Ensure snapshot for a kind of global stats exist. * diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index caaf0c5a672..2660bd1eb07 100644 --- a/src/backend/utils/adt/pgstatfuncs.c +++ b/src/backend/utils/adt/pgstatfuncs.c @@ -2395,3 +2395,20 @@ pg_stat_get_subscription_stats(PG_FUNCTION_ARGS) /* Returns the record as Datum */ PG_RETURN_DATUM(HeapTupleGetDatum(heap_form_tuple(tupdesc, values, nulls))); } + +/* + * Checks for presence of stats for object with provided kind, database oid, + * object oid. + * + * This is useful for regression tests, but not much more. + */ +Datum +pg_stat_exists_stat(PG_FUNCTION_ARGS) +{ + char *stats_type = text_to_cstring(PG_GETARG_TEXT_P(0)); + Oid dboid = PG_GETARG_OID(1); + Oid objoid = PG_GETARG_OID(2); + PgStat_Kind kind = pgstat_kind_from_str(stats_type); + + PG_RETURN_BOOL(pgstat_exists_entry(kind, dboid, objoid)); +} -- 2.35.1.677.gabf474a5dd --vl7on5vfmrsyxmos Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v70-0018-pgstat-test-transaction-behaviour-2PC-function-s.patch" ^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH v3 7/7] Allow to print raw parse tree. @ 2023-07-26 10:49 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Tatsuo Ishii @ 2023-07-26 10:49 UTC (permalink / raw) --- src/backend/tcop/postgres.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index 36cc99ec9c..c01e90f735 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -653,6 +653,10 @@ pg_parse_query(const char *query_string) } #endif + if (Debug_print_parse) + elog_node_display(LOG, "raw parse tree", raw_parsetree_list, + Debug_pretty_print); + TRACE_POSTGRESQL_QUERY_PARSE_DONE(query_string); return raw_parsetree_list; -- 2.25.1 ----Next_Part(Wed_Jul_26_21_21_34_2023_317)---- ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-07-26 10:49 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-04-02 21:21 [PATCH v68 16/31] pgstat: add pg_stat_exists_stat() for easier testing. Andres Freund <andres@anarazel.de> 2022-04-02 21:21 [PATCH v69 13/28] pgstat: add pg_stat_exists_stat() for easier testing. Andres Freund <andres@anarazel.de> 2022-04-02 21:21 [PATCH v70 17/27] pgstat: add pg_stat_exists_stat() for easier testing. Andres Freund <andres@anarazel.de> 2023-07-26 10:49 [PATCH v3 7/7] Allow to print raw parse tree. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox