Date: Wed, 1 Jul 2026 21:36:23 +0200
From: Erik Wienhold <ewie@ewie.name>
To: pgsql-hackers@lists.postgresql.org
Subject: psql: Fix \df tab completion for procedures
Message-ID: <10fbfdfe-80f6-4ef9-b8b3-f7be0eb53a50@ewie.name>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="5rsvev5qaoortkiw"
Content-Disposition: inline
Archived-At: 
 <https://www.postgresql.org/message-id/10fbfdfe-80f6-4ef9-b8b3-f7be0eb53a50%40ewie.name>
Precedence: bulk


--5rsvev5qaoortkiw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Here's a patch that fixes the tab completion for \df to also consider
procedures, in effect every kind of routine.

I guess this was just missed in commits fb421231daa and 05e85d35afb.

-- 
Erik Wienhold

--5rsvev5qaoortkiw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v1-0001-psql-Fix-df-tab-completion-for-procedures.patch"

From 1be80c34cb53825a7f0e04a09b2e6c9b391103e3 Mon Sep 17 00:00:00 2001
From: Erik Wienhold <ewie@ewie.name>
Date: Sat, 22 Nov 2025 15:42:06 +0100
Subject: [PATCH v1] psql: Fix \df tab completion for procedures

\df also covers procedures since fb421231daa.  But the tab completion
logic was never changed to align with that.  Fix this along the lines of
05e85d35afb.
---
 src/bin/psql/tab-complete.in.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 072b98bea08..8f81f5bf035 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -5669,7 +5669,7 @@ match_previous_words(int pattern_id,
 	else if (TailMatchesCS("\\dew*"))
 		COMPLETE_WITH_QUERY(Query_for_list_of_fdws);
 	else if (TailMatchesCS("\\df*"))
-		COMPLETE_WITH_VERSIONED_SCHEMA_QUERY(Query_for_list_of_functions);
+		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines);
 	else if (HeadMatchesCS("\\df*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_datatypes);
 
-- 
2.55.0


--5rsvev5qaoortkiw--