agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feed[PATCH v28 01/11] Add a syntax to create Incrementally Maintainable Materialized Views
388+ messages / 2 participants
[nested] [flat]
* [PATCH v28 01/11] Add a syntax to create Incrementally Maintainable Materialized Views
@ 2019-12-20 01:05 Yugo Nagata <nagata@sraoss.co.jp>
0 siblings, 0 replies; 388+ messages in thread
From: Yugo Nagata @ 2019-12-20 01:05 UTC (permalink / raw)
Allow to create Incrementally Maintainable Materialized View (IMMV)
by using INCREMENTAL option in CREATE MATERIALIZED VIEW command
as follow:
CREATE [INCREMANTAL] MATERIALIZED VIEW xxxxx AS SELECT ....;
---
src/backend/parser/gram.y | 32 +++++++++++++++++++++-----------
src/include/nodes/primnodes.h | 1 +
src/include/parser/kwlist.h | 1 +
3 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 39ab7eac0d..3534b37f81 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -465,6 +465,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
%type <range> OptTempTableName
%type <into> into_clause create_as_target create_mv_target
+%type <boolean> incremental
%type <defelt> createfunc_opt_item common_func_opt_item dostmt_opt_item
%type <fun_param> func_arg func_arg_with_default table_func_column aggr_arg
@@ -721,7 +722,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
HANDLER HAVING HEADER_P HOLD HOUR_P
IDENTITY_P IF_P ILIKE IMMEDIATE IMMUTABLE IMPLICIT_P IMPORT_P IN_P INCLUDE
- INCLUDING INCREMENT INDENT INDEX INDEXES INHERIT INHERITS INITIALLY INLINE_P
+ INCLUDING INCREMENT INCREMENTAL INDENT INDEX INDEXES INHERIT INHERITS INITIALLY INLINE_P
INNER_P INOUT INPUT_P INSENSITIVE INSERT INSTEAD INT_P INTEGER
INTERSECT INTERVAL INTO INVOKER IS ISNULL ISOLATION
@@ -4637,32 +4638,34 @@ opt_with_data:
*****************************************************************************/
CreateMatViewStmt:
- CREATE OptNoLog MATERIALIZED VIEW create_mv_target AS SelectStmt opt_with_data
+ CREATE OptNoLog incremental MATERIALIZED VIEW create_mv_target AS SelectStmt opt_with_data
{
CreateTableAsStmt *ctas = makeNode(CreateTableAsStmt);
- ctas->query = $7;
- ctas->into = $5;
+ ctas->query = $8;
+ ctas->into = $6;
ctas->objtype = OBJECT_MATVIEW;
ctas->is_select_into = false;
ctas->if_not_exists = false;
/* cram additional flags into the IntoClause */
- $5->rel->relpersistence = $2;
- $5->skipData = !($8);
+ $6->rel->relpersistence = $2;
+ $6->skipData = !($9);
+ $6->ivm = $3;
$$ = (Node *) ctas;
}
- | CREATE OptNoLog MATERIALIZED VIEW IF_P NOT EXISTS create_mv_target AS SelectStmt opt_with_data
+ | CREATE OptNoLog incremental MATERIALIZED VIEW IF_P NOT EXISTS create_mv_target AS SelectStmt opt_with_data
{
CreateTableAsStmt *ctas = makeNode(CreateTableAsStmt);
- ctas->query = $10;
- ctas->into = $8;
+ ctas->query = $11;
+ ctas->into = $9;
ctas->objtype = OBJECT_MATVIEW;
ctas->is_select_into = false;
ctas->if_not_exists = true;
/* cram additional flags into the IntoClause */
- $8->rel->relpersistence = $2;
- $8->skipData = !($11);
+ $9->rel->relpersistence = $2;
+ $9->skipData = !($12);
+ $9->ivm = $3;
$$ = (Node *) ctas;
}
;
@@ -4679,9 +4682,14 @@ create_mv_target:
$$->tableSpaceName = $5;
$$->viewQuery = NULL; /* filled at analysis time */
$$->skipData = false; /* might get changed later */
+ $$->ivm = false;
}
;
+incremental: INCREMENTAL { $$ = true; }
+ | /*EMPTY*/ { $$ = false; }
+ ;
+
OptNoLog: UNLOGGED { $$ = RELPERSISTENCE_UNLOGGED; }
| /*EMPTY*/ { $$ = RELPERSISTENCE_PERMANENT; }
;
@@ -17055,6 +17063,7 @@ unreserved_keyword:
| INCLUDE
| INCLUDING
| INCREMENT
+ | INCREMENTAL
| INDENT
| INDEX
| INDEXES
@@ -17621,6 +17630,7 @@ bare_label_keyword:
| INCLUDE
| INCLUDING
| INCREMENT
+ | INCREMENTAL
| INDENT
| INDEX
| INDEXES
diff --git a/src/include/nodes/primnodes.h b/src/include/nodes/primnodes.h
index 792a743f72..e87a105707 100644
--- a/src/include/nodes/primnodes.h
+++ b/src/include/nodes/primnodes.h
@@ -146,6 +146,7 @@ typedef struct IntoClause
/* materialized view's SELECT query */
Node *viewQuery pg_node_attr(query_jumble_ignore);
bool skipData; /* true for WITH NO DATA */
+ bool ivm; /* true for WITH IVM */
} IntoClause;
diff --git a/src/include/parser/kwlist.h b/src/include/parser/kwlist.h
index f5b2e61ca5..a3fbfedbf4 100644
--- a/src/include/parser/kwlist.h
+++ b/src/include/parser/kwlist.h
@@ -207,6 +207,7 @@ PG_KEYWORD("in", IN_P, RESERVED_KEYWORD, BARE_LABEL)
PG_KEYWORD("include", INCLUDE, UNRESERVED_KEYWORD, BARE_LABEL)
PG_KEYWORD("including", INCLUDING, UNRESERVED_KEYWORD, BARE_LABEL)
PG_KEYWORD("increment", INCREMENT, UNRESERVED_KEYWORD, BARE_LABEL)
+PG_KEYWORD("incremental", INCREMENTAL, UNRESERVED_KEYWORD, BARE_LABEL)
PG_KEYWORD("indent", INDENT, UNRESERVED_KEYWORD, BARE_LABEL)
PG_KEYWORD("index", INDEX, UNRESERVED_KEYWORD, BARE_LABEL)
PG_KEYWORD("indexes", INDEXES, UNRESERVED_KEYWORD, BARE_LABEL)
--
2.25.1
--Multipart=_Thu__1_Jun_2023_23_59_09_+0900_/G5+8nG46.f1T42K
Content-Type: text/x-diff;
name="v28-0002-Add-relisivm-column-to-pg_class-system-catalog.patch"
Content-Disposition: attachment;
filename="v28-0002-Add-relisivm-column-to-pg_class-system-catalog.patch"
Content-Transfer-Encoding: 7bit
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
* [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid
@ 2026-03-12 15:09 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 388+ messages in thread
From: Álvaro Herrera @ 2026-03-12 15:09 UTC (permalink / raw)
---
src/backend/commands/cluster.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index af47354e382..29440fb75cd 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -2814,7 +2814,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* Whether we could read new record or not, keep checking if
* 'lsn_upto' was specified.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
{
SpinLockAcquire(&shared->mutex);
lsn_upto = shared->lsn_upto;
@@ -2822,7 +2822,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
done = shared->done;
SpinLockRelease(&shared->mutex);
}
- if (!XLogRecPtrIsInvalid(lsn_upto) &&
+ if (XLogRecPtrIsValid(lsn_upto) &&
ctx->reader->EndRecPtr >= lsn_upto)
break;
@@ -2846,7 +2846,7 @@ decode_concurrent_changes(LogicalDecodingContext *ctx,
* If lsn_upto is valid, WAL records having LSN lower than that
* should already have been flushed to disk.
*/
- if (XLogRecPtrIsInvalid(lsn_upto))
+ if (!XLogRecPtrIsValid(lsn_upto))
timeout = 100L;
res = WaitForLSN(WAIT_LSN_TYPE_PRIMARY_FLUSH,
ctx->reader->EndRecPtr + 1,
@@ -4039,7 +4039,7 @@ repack_worker_internal(dsm_segment *seg)
* anything in the shared memory until we have serialized the snapshot.
*/
SpinLockAcquire(&shared->mutex);
- Assert(XLogRecPtrIsInvalid(shared->lsn_upto));
+ Assert(!XLogRecPtrIsValid(shared->lsn_upto));
sfs = &shared->sfs;
SpinLockRelease(&shared->mutex);
--
2.47.3
--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
filename="0005-document-store_change-somewhat-more.nocfbot.txt"
^ permalink raw reply [nested|flat] 388+ messages in thread
end of thread, other threads:[~2026-03-12 15:09 UTC | newest]
Thread overview: 388+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-12-20 01:05 [PATCH v28 01/11] Add a syntax to create Incrementally Maintainable Materialized Views Yugo Nagata <nagata@sraoss.co.jp>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
2026-03-12 15:09 [PATCH 4/9] XLogRecPtrIsInvalid -> XLogRecPtrIsValid Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox