agora inbox for [email protected]help / color / mirror / Atom feed
[PATCH v5 2/3] remove check hooks for GUCs that contribute to MaxBackends 59+ messages / 3 participants [nested] [flat]
* [PATCH v5 2/3] remove check hooks for GUCs that contribute to MaxBackends @ 2024-06-19 18:39 Nathan Bossart <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Nathan Bossart @ 2024-06-19 18:39 UTC (permalink / raw) --- src/backend/utils/init/postinit.c | 57 ++++------------------------- src/backend/utils/misc/guc_tables.c | 8 ++-- src/include/utils/guc_hooks.h | 6 --- 3 files changed, 11 insertions(+), 60 deletions(-) diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c index 0805398e24..8a629982c4 100644 --- a/src/backend/utils/init/postinit.c +++ b/src/backend/utils/init/postinit.c @@ -580,57 +580,14 @@ InitializeMaxBackends(void) MaxBackends = MaxConnections + autovacuum_max_workers + 1 + max_worker_processes + max_wal_senders; - /* internal error because the values were all checked previously */ if (MaxBackends > MAX_BACKENDS) - elog(ERROR, "too many backends configured"); -} - -/* - * GUC check_hook for max_connections - */ -bool -check_max_connections(int *newval, void **extra, GucSource source) -{ - if (*newval + autovacuum_max_workers + 1 + - max_worker_processes + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for autovacuum_max_workers - */ -bool -check_autovacuum_max_workers(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + *newval + 1 + - max_worker_processes + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for max_worker_processes - */ -bool -check_max_worker_processes(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + autovacuum_max_workers + 1 + - *newval + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for max_wal_senders - */ -bool -check_max_wal_senders(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + autovacuum_max_workers + 1 + - max_worker_processes + *newval > MAX_BACKENDS) - return false; - return true; + ereport(ERROR, + (errcode(ERRCODE_INVALID_PARAMETER_VALUE), + errmsg("too many backends configured"), + errdetail("\"max_connections\" (%d) plus \"autovacuum_max_workers\" (%d) plus \"max_worker_processes\" (%d) plus \"max_wal_senders\" (%d) must be less than %d.", + MaxConnections, autovacuum_max_workers, + max_worker_processes, max_wal_senders, + MAX_BACKENDS - 1))); } /* diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index 80e77cbac9..57df7767ad 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -2208,7 +2208,7 @@ struct config_int ConfigureNamesInt[] = }, &MaxConnections, 100, 1, MAX_BACKENDS, - check_max_connections, NULL, NULL + NULL, NULL, NULL }, { @@ -2935,7 +2935,7 @@ struct config_int ConfigureNamesInt[] = }, &max_wal_senders, 10, 0, MAX_BACKENDS, - check_max_wal_senders, NULL, NULL + NULL, NULL, NULL }, { @@ -3165,7 +3165,7 @@ struct config_int ConfigureNamesInt[] = }, &max_worker_processes, 8, 0, MAX_BACKENDS, - check_max_worker_processes, NULL, NULL + NULL, NULL, NULL }, { @@ -3399,7 +3399,7 @@ struct config_int ConfigureNamesInt[] = }, &autovacuum_max_workers, 3, 1, MAX_BACKENDS, - check_autovacuum_max_workers, NULL, NULL + NULL, NULL, NULL }, { diff --git a/src/include/utils/guc_hooks.h b/src/include/utils/guc_hooks.h index d64dc5fcdb..6304f0679b 100644 --- a/src/include/utils/guc_hooks.h +++ b/src/include/utils/guc_hooks.h @@ -29,8 +29,6 @@ extern bool check_application_name(char **newval, void **extra, GucSource source); extern void assign_application_name(const char *newval, void *extra); extern const char *show_archive_command(void); -extern bool check_autovacuum_max_workers(int *newval, void **extra, - GucSource source); extern bool check_autovacuum_work_mem(int *newval, void **extra, GucSource source); extern bool check_vacuum_buffer_usage_limit(int *newval, void **extra, @@ -84,13 +82,9 @@ extern const char *show_log_timezone(void); extern bool check_maintenance_io_concurrency(int *newval, void **extra, GucSource source); extern void assign_maintenance_io_concurrency(int newval, void *extra); -extern bool check_max_connections(int *newval, void **extra, GucSource source); -extern bool check_max_wal_senders(int *newval, void **extra, GucSource source); extern bool check_max_slot_wal_keep_size(int *newval, void **extra, GucSource source); extern void assign_max_wal_size(int newval, void *extra); -extern bool check_max_worker_processes(int *newval, void **extra, - GucSource source); extern bool check_max_stack_depth(int *newval, void **extra, GucSource source); extern void assign_max_stack_depth(int newval, void *extra); extern bool check_multixact_member_buffers(int *newval, void **extra, -- 2.39.3 (Apple Git-146) --wPBE4Nn73k3cOM/e Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="v5-0003-allow-changing-autovacuum_max_workers-without-res.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH v1 1/1] remove check hooks for GUCs that contribute to MaxBackends @ 2024-06-19 18:39 Nathan Bossart <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Nathan Bossart @ 2024-06-19 18:39 UTC (permalink / raw) --- src/backend/utils/init/postinit.c | 57 ++++------------------------- src/backend/utils/misc/guc_tables.c | 8 ++-- src/include/utils/guc_hooks.h | 6 --- 3 files changed, 11 insertions(+), 60 deletions(-) diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c index 0805398e24..8a629982c4 100644 --- a/src/backend/utils/init/postinit.c +++ b/src/backend/utils/init/postinit.c @@ -580,57 +580,14 @@ InitializeMaxBackends(void) MaxBackends = MaxConnections + autovacuum_max_workers + 1 + max_worker_processes + max_wal_senders; - /* internal error because the values were all checked previously */ if (MaxBackends > MAX_BACKENDS) - elog(ERROR, "too many backends configured"); -} - -/* - * GUC check_hook for max_connections - */ -bool -check_max_connections(int *newval, void **extra, GucSource source) -{ - if (*newval + autovacuum_max_workers + 1 + - max_worker_processes + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for autovacuum_max_workers - */ -bool -check_autovacuum_max_workers(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + *newval + 1 + - max_worker_processes + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for max_worker_processes - */ -bool -check_max_worker_processes(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + autovacuum_max_workers + 1 + - *newval + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for max_wal_senders - */ -bool -check_max_wal_senders(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + autovacuum_max_workers + 1 + - max_worker_processes + *newval > MAX_BACKENDS) - return false; - return true; + ereport(ERROR, + (errcode(ERRCODE_INVALID_PARAMETER_VALUE), + errmsg("too many backends configured"), + errdetail("\"max_connections\" (%d) plus \"autovacuum_max_workers\" (%d) plus \"max_worker_processes\" (%d) plus \"max_wal_senders\" (%d) must be less than %d.", + MaxConnections, autovacuum_max_workers, + max_worker_processes, max_wal_senders, + MAX_BACKENDS - 1))); } /* diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index 46c258be28..07b575894d 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -2207,7 +2207,7 @@ struct config_int ConfigureNamesInt[] = }, &MaxConnections, 100, 1, MAX_BACKENDS, - check_max_connections, NULL, NULL + NULL, NULL, NULL }, { @@ -2923,7 +2923,7 @@ struct config_int ConfigureNamesInt[] = }, &max_wal_senders, 10, 0, MAX_BACKENDS, - check_max_wal_senders, NULL, NULL + NULL, NULL, NULL }, { @@ -3153,7 +3153,7 @@ struct config_int ConfigureNamesInt[] = }, &max_worker_processes, 8, 0, MAX_BACKENDS, - check_max_worker_processes, NULL, NULL + NULL, NULL, NULL }, { @@ -3387,7 +3387,7 @@ struct config_int ConfigureNamesInt[] = }, &autovacuum_max_workers, 3, 1, MAX_BACKENDS, - check_autovacuum_max_workers, NULL, NULL + NULL, NULL, NULL }, { diff --git a/src/include/utils/guc_hooks.h b/src/include/utils/guc_hooks.h index d64dc5fcdb..6304f0679b 100644 --- a/src/include/utils/guc_hooks.h +++ b/src/include/utils/guc_hooks.h @@ -29,8 +29,6 @@ extern bool check_application_name(char **newval, void **extra, GucSource source); extern void assign_application_name(const char *newval, void *extra); extern const char *show_archive_command(void); -extern bool check_autovacuum_max_workers(int *newval, void **extra, - GucSource source); extern bool check_autovacuum_work_mem(int *newval, void **extra, GucSource source); extern bool check_vacuum_buffer_usage_limit(int *newval, void **extra, @@ -84,13 +82,9 @@ extern const char *show_log_timezone(void); extern bool check_maintenance_io_concurrency(int *newval, void **extra, GucSource source); extern void assign_maintenance_io_concurrency(int newval, void *extra); -extern bool check_max_connections(int *newval, void **extra, GucSource source); -extern bool check_max_wal_senders(int *newval, void **extra, GucSource source); extern bool check_max_slot_wal_keep_size(int *newval, void **extra, GucSource source); extern void assign_max_wal_size(int newval, void *extra); -extern bool check_max_worker_processes(int *newval, void **extra, - GucSource source); extern bool check_max_stack_depth(int *newval, void **extra, GucSource source); extern void assign_max_stack_depth(int newval, void *extra); extern bool check_multixact_member_buffers(int *newval, void **extra, -- 2.39.3 (Apple Git-146) --4rSPnp6/pm7uSOZW-- ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH v1 1/1] remove check hooks for GUCs that contribute to MaxBackends @ 2024-06-19 18:39 Nathan Bossart <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Nathan Bossart @ 2024-06-19 18:39 UTC (permalink / raw) --- src/backend/utils/init/postinit.c | 57 ++++------------------------- src/backend/utils/misc/guc_tables.c | 8 ++-- src/include/utils/guc_hooks.h | 6 --- 3 files changed, 11 insertions(+), 60 deletions(-) diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c index 0805398e24..8a629982c4 100644 --- a/src/backend/utils/init/postinit.c +++ b/src/backend/utils/init/postinit.c @@ -580,57 +580,14 @@ InitializeMaxBackends(void) MaxBackends = MaxConnections + autovacuum_max_workers + 1 + max_worker_processes + max_wal_senders; - /* internal error because the values were all checked previously */ if (MaxBackends > MAX_BACKENDS) - elog(ERROR, "too many backends configured"); -} - -/* - * GUC check_hook for max_connections - */ -bool -check_max_connections(int *newval, void **extra, GucSource source) -{ - if (*newval + autovacuum_max_workers + 1 + - max_worker_processes + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for autovacuum_max_workers - */ -bool -check_autovacuum_max_workers(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + *newval + 1 + - max_worker_processes + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for max_worker_processes - */ -bool -check_max_worker_processes(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + autovacuum_max_workers + 1 + - *newval + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for max_wal_senders - */ -bool -check_max_wal_senders(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + autovacuum_max_workers + 1 + - max_worker_processes + *newval > MAX_BACKENDS) - return false; - return true; + ereport(ERROR, + (errcode(ERRCODE_INVALID_PARAMETER_VALUE), + errmsg("too many backends configured"), + errdetail("\"max_connections\" (%d) plus \"autovacuum_max_workers\" (%d) plus \"max_worker_processes\" (%d) plus \"max_wal_senders\" (%d) must be less than %d.", + MaxConnections, autovacuum_max_workers, + max_worker_processes, max_wal_senders, + MAX_BACKENDS - 1))); } /* diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index 46c258be28..07b575894d 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -2207,7 +2207,7 @@ struct config_int ConfigureNamesInt[] = }, &MaxConnections, 100, 1, MAX_BACKENDS, - check_max_connections, NULL, NULL + NULL, NULL, NULL }, { @@ -2923,7 +2923,7 @@ struct config_int ConfigureNamesInt[] = }, &max_wal_senders, 10, 0, MAX_BACKENDS, - check_max_wal_senders, NULL, NULL + NULL, NULL, NULL }, { @@ -3153,7 +3153,7 @@ struct config_int ConfigureNamesInt[] = }, &max_worker_processes, 8, 0, MAX_BACKENDS, - check_max_worker_processes, NULL, NULL + NULL, NULL, NULL }, { @@ -3387,7 +3387,7 @@ struct config_int ConfigureNamesInt[] = }, &autovacuum_max_workers, 3, 1, MAX_BACKENDS, - check_autovacuum_max_workers, NULL, NULL + NULL, NULL, NULL }, { diff --git a/src/include/utils/guc_hooks.h b/src/include/utils/guc_hooks.h index d64dc5fcdb..6304f0679b 100644 --- a/src/include/utils/guc_hooks.h +++ b/src/include/utils/guc_hooks.h @@ -29,8 +29,6 @@ extern bool check_application_name(char **newval, void **extra, GucSource source); extern void assign_application_name(const char *newval, void *extra); extern const char *show_archive_command(void); -extern bool check_autovacuum_max_workers(int *newval, void **extra, - GucSource source); extern bool check_autovacuum_work_mem(int *newval, void **extra, GucSource source); extern bool check_vacuum_buffer_usage_limit(int *newval, void **extra, @@ -84,13 +82,9 @@ extern const char *show_log_timezone(void); extern bool check_maintenance_io_concurrency(int *newval, void **extra, GucSource source); extern void assign_maintenance_io_concurrency(int newval, void *extra); -extern bool check_max_connections(int *newval, void **extra, GucSource source); -extern bool check_max_wal_senders(int *newval, void **extra, GucSource source); extern bool check_max_slot_wal_keep_size(int *newval, void **extra, GucSource source); extern void assign_max_wal_size(int newval, void *extra); -extern bool check_max_worker_processes(int *newval, void **extra, - GucSource source); extern bool check_max_stack_depth(int *newval, void **extra, GucSource source); extern void assign_max_stack_depth(int newval, void *extra); extern bool check_multixact_member_buffers(int *newval, void **extra, -- 2.39.3 (Apple Git-146) --4rSPnp6/pm7uSOZW-- ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH v5 2/3] remove check hooks for GUCs that contribute to MaxBackends @ 2024-06-19 18:39 Nathan Bossart <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Nathan Bossart @ 2024-06-19 18:39 UTC (permalink / raw) --- src/backend/utils/init/postinit.c | 57 ++++------------------------- src/backend/utils/misc/guc_tables.c | 8 ++-- src/include/utils/guc_hooks.h | 6 --- 3 files changed, 11 insertions(+), 60 deletions(-) diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c index 0805398e24..8a629982c4 100644 --- a/src/backend/utils/init/postinit.c +++ b/src/backend/utils/init/postinit.c @@ -580,57 +580,14 @@ InitializeMaxBackends(void) MaxBackends = MaxConnections + autovacuum_max_workers + 1 + max_worker_processes + max_wal_senders; - /* internal error because the values were all checked previously */ if (MaxBackends > MAX_BACKENDS) - elog(ERROR, "too many backends configured"); -} - -/* - * GUC check_hook for max_connections - */ -bool -check_max_connections(int *newval, void **extra, GucSource source) -{ - if (*newval + autovacuum_max_workers + 1 + - max_worker_processes + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for autovacuum_max_workers - */ -bool -check_autovacuum_max_workers(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + *newval + 1 + - max_worker_processes + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for max_worker_processes - */ -bool -check_max_worker_processes(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + autovacuum_max_workers + 1 + - *newval + max_wal_senders > MAX_BACKENDS) - return false; - return true; -} - -/* - * GUC check_hook for max_wal_senders - */ -bool -check_max_wal_senders(int *newval, void **extra, GucSource source) -{ - if (MaxConnections + autovacuum_max_workers + 1 + - max_worker_processes + *newval > MAX_BACKENDS) - return false; - return true; + ereport(ERROR, + (errcode(ERRCODE_INVALID_PARAMETER_VALUE), + errmsg("too many backends configured"), + errdetail("\"max_connections\" (%d) plus \"autovacuum_max_workers\" (%d) plus \"max_worker_processes\" (%d) plus \"max_wal_senders\" (%d) must be less than %d.", + MaxConnections, autovacuum_max_workers, + max_worker_processes, max_wal_senders, + MAX_BACKENDS - 1))); } /* diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c index 80e77cbac9..57df7767ad 100644 --- a/src/backend/utils/misc/guc_tables.c +++ b/src/backend/utils/misc/guc_tables.c @@ -2208,7 +2208,7 @@ struct config_int ConfigureNamesInt[] = }, &MaxConnections, 100, 1, MAX_BACKENDS, - check_max_connections, NULL, NULL + NULL, NULL, NULL }, { @@ -2935,7 +2935,7 @@ struct config_int ConfigureNamesInt[] = }, &max_wal_senders, 10, 0, MAX_BACKENDS, - check_max_wal_senders, NULL, NULL + NULL, NULL, NULL }, { @@ -3165,7 +3165,7 @@ struct config_int ConfigureNamesInt[] = }, &max_worker_processes, 8, 0, MAX_BACKENDS, - check_max_worker_processes, NULL, NULL + NULL, NULL, NULL }, { @@ -3399,7 +3399,7 @@ struct config_int ConfigureNamesInt[] = }, &autovacuum_max_workers, 3, 1, MAX_BACKENDS, - check_autovacuum_max_workers, NULL, NULL + NULL, NULL, NULL }, { diff --git a/src/include/utils/guc_hooks.h b/src/include/utils/guc_hooks.h index d64dc5fcdb..6304f0679b 100644 --- a/src/include/utils/guc_hooks.h +++ b/src/include/utils/guc_hooks.h @@ -29,8 +29,6 @@ extern bool check_application_name(char **newval, void **extra, GucSource source); extern void assign_application_name(const char *newval, void *extra); extern const char *show_archive_command(void); -extern bool check_autovacuum_max_workers(int *newval, void **extra, - GucSource source); extern bool check_autovacuum_work_mem(int *newval, void **extra, GucSource source); extern bool check_vacuum_buffer_usage_limit(int *newval, void **extra, @@ -84,13 +82,9 @@ extern const char *show_log_timezone(void); extern bool check_maintenance_io_concurrency(int *newval, void **extra, GucSource source); extern void assign_maintenance_io_concurrency(int newval, void *extra); -extern bool check_max_connections(int *newval, void **extra, GucSource source); -extern bool check_max_wal_senders(int *newval, void **extra, GucSource source); extern bool check_max_slot_wal_keep_size(int *newval, void **extra, GucSource source); extern void assign_max_wal_size(int newval, void *extra); -extern bool check_max_worker_processes(int *newval, void **extra, - GucSource source); extern bool check_max_stack_depth(int *newval, void **extra, GucSource source); extern void assign_max_stack_depth(int newval, void *extra); extern bool check_multixact_member_buffers(int *newval, void **extra, -- 2.39.3 (Apple Git-146) --wPBE4Nn73k3cOM/e Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="v5-0003-allow-changing-autovacuum_max_workers-without-res.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 5/7] Use BulkInsertState when copying data to the new heap. @ 2026-03-11 14:20 Antonin Houska <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Antonin Houska @ 2026-03-11 14:20 UTC (permalink / raw) It should make the copying more efficient. Besides that, buffer access strategy is involved this way. This diff reverts the changes done in previous parts of the series to reform_and_rewrite_tuple() and introduces a separate function heap_insert_for_repack(). --- src/backend/access/heap/heapam_handler.c | 110 +++++++++++++++-------- 1 file changed, 72 insertions(+), 38 deletions(-) diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c index ae0b011f6c1..ee763c995f0 100644 --- a/src/backend/access/heap/heapam_handler.c +++ b/src/backend/access/heap/heapam_handler.c @@ -50,6 +50,11 @@ static void reform_and_rewrite_tuple(HeapTuple tuple, Relation OldHeap, Relation NewHeap, Datum *values, bool *isnull, RewriteState rwstate); +static void heap_insert_for_repack(HeapTuple tuple, Relation OldHeap, + Relation NewHeap, Datum *values, bool *isnull, + BulkInsertState bistate); +static HeapTuple reform_tuple(HeapTuple tuple, Relation OldHeap, + Relation NewHeap, Datum *values, bool *isnull); static bool SampleHeapTupleVisible(TableScanDesc scan, Buffer buffer, HeapTuple tuple, @@ -703,6 +708,7 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap, double *tups_recently_dead) { RewriteState rwstate = NULL; + BulkInsertState bistate = NULL; IndexScanDesc indexScan; TableScanDesc tableScan; HeapScanDesc heapScan; @@ -738,6 +744,8 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap, if (!concurrent) rwstate = begin_heap_rewrite(OldHeap, NewHeap, OldestXmin, *xid_cutoff, *multi_cutoff); + else + bistate = GetBulkInsertState(); /* Set up sorting if wanted */ @@ -967,8 +975,12 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap, }; int64 ct_val[2]; - reform_and_rewrite_tuple(tuple, OldHeap, NewHeap, - values, isnull, rwstate); + if (!concurrent) + reform_and_rewrite_tuple(tuple, OldHeap, NewHeap, + values, isnull, rwstate); + else + heap_insert_for_repack(tuple, OldHeap, NewHeap, + values, isnull, bistate); /* * In indexscan mode and also VACUUM FULL, report increase in @@ -1016,10 +1028,15 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap, break; n_tuples += 1; - reform_and_rewrite_tuple(tuple, - OldHeap, NewHeap, - values, isnull, - rwstate); + if (!concurrent) + reform_and_rewrite_tuple(tuple, + OldHeap, NewHeap, + values, isnull, + rwstate); + else + heap_insert_for_repack(tuple, OldHeap, NewHeap, + values, isnull, bistate); + /* Report n_tuples */ pgstat_progress_update_param(PROGRESS_REPACK_HEAP_TUPLES_INSERTED, n_tuples); @@ -1031,6 +1048,8 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap, /* Write out any remaining tuples, and fsync if needed */ if (rwstate) end_heap_rewrite(rwstate); + if (bistate) + FreeBulkInsertState(bistate); /* Clean up */ pfree(values); @@ -2423,56 +2442,71 @@ heapam_scan_sample_next_tuple(TableScanDesc scan, SampleScanState *scanstate, * SET WITHOUT OIDS. * * So, we must reconstruct the tuple from component Datums. - * - * If rwstate=NULL, use simple_heap_insert() instead of rewriting - in that - * case we still need to deform/form the tuple. TODO Shouldn't we rename the - * function, as might not do any rewrite? */ static void reform_and_rewrite_tuple(HeapTuple tuple, Relation OldHeap, Relation NewHeap, Datum *values, bool *isnull, RewriteState rwstate) +{ + HeapTuple copiedTuple; + + copiedTuple = reform_tuple(tuple, OldHeap, NewHeap, values, isnull); + + /* The heap rewrite module does the rest */ + rewrite_heap_tuple(rwstate, tuple, copiedTuple); + + heap_freetuple(copiedTuple); +} + +/* + * Insert tuple when processing REPACK CONCURRENTLY. + * + * rewriteheap.c is not used in the CONCURRENTLY case because it'd be + * difficult to do the same in the catch-up phase (as the logical + * decoding does not provide us with sufficient visibility + * information). Thus we must use heap_insert() both during the + * catch-up and here. + * + * We pass the NO_LOGICAL flag to heap_insert() in order to skip logical + * decoding: as soon as REPACK CONCURRENTLY swaps the relation files, it drops + * this relation, so no logical replication subscription should need the data. + * + * BulkInsertState is used because many tuples are inserted in the typical + * case. + */ +static void +heap_insert_for_repack(HeapTuple tuple, Relation OldHeap, Relation NewHeap, + Datum *values, bool *isnull, BulkInsertState bistate) +{ + tuple = reform_tuple(tuple, OldHeap, NewHeap, values, isnull); + + heap_insert(NewHeap, tuple, GetCurrentCommandId(true), + HEAP_INSERT_NO_LOGICAL, bistate); + + heap_freetuple(tuple); +} + +/* + * Deform tuple, set values of dropped columns to NULL, form a new tuple and + * return it. + */ +static HeapTuple +reform_tuple(HeapTuple tuple, Relation OldHeap, Relation NewHeap, + Datum *values, bool *isnull) { TupleDesc oldTupDesc = RelationGetDescr(OldHeap); TupleDesc newTupDesc = RelationGetDescr(NewHeap); - HeapTuple copiedTuple; int i; heap_deform_tuple(tuple, oldTupDesc, values, isnull); - /* Be sure to null out any dropped columns */ for (i = 0; i < newTupDesc->natts; i++) { if (TupleDescCompactAttr(newTupDesc, i)->attisdropped) isnull[i] = true; } - copiedTuple = heap_form_tuple(newTupDesc, values, isnull); - - if (rwstate) - /* The heap rewrite module does the rest */ - rewrite_heap_tuple(rwstate, tuple, copiedTuple); - else - { - /* - * Insert tuple when processing REPACK CONCURRENTLY. - * - * rewriteheap.c is not used in the CONCURRENTLY case because it'd be - * difficult to do the same in the catch-up phase (as the logical - * decoding does not provide us with sufficient visibility - * information). Thus we must use heap_insert() both during the - * catch-up and here. - * - * The following is like simple_heap_insert() except that we pass the - * flag to skip logical decoding: as soon as REPACK CONCURRENTLY swaps - * the relation files, it drops this relation, so no logical - * replication subscription should need the data. - */ - heap_insert(NewHeap, copiedTuple, GetCurrentCommandId(true), - HEAP_INSERT_NO_LOGICAL, NULL); - } - - heap_freetuple(copiedTuple); + return heap_form_tuple(newTupDesc, values, isnull); } /* -- 2.47.3 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v42-0006-Fix-a-few-problems-in-index-build-progress-reporting.patch ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
* [PATCH 3/4] Add missing period to HINT message @ 2026-05-28 02:53 Kyotaro Horiguchi <[email protected]> 0 siblings, 0 replies; 59+ messages in thread From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw) Add a trailing period to a HINT message. --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index f2738c351f9..e81d2eab3fd 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -364,7 +364,7 @@ be_tls_init(bool isServerStart) errcode(ERRCODE_CONFIG_FILE_ERROR), errmsg("no SSL configurations loaded"), /*- translator: The two %s contain filenames */ - errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"", + errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".", "pg_hosts.conf", "postgresql.conf")); goto error; } -- 2.47.3 ----Next_Part(Thu_May_28_12_16_22_2026_214)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch" ^ permalink raw reply [nested|flat] 59+ messages in thread
end of thread, other threads:[~2026-05-28 02:53 UTC | newest] Thread overview: 59+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-06-19 18:39 [PATCH v1 1/1] remove check hooks for GUCs that contribute to MaxBackends Nathan Bossart <[email protected]> 2024-06-19 18:39 [PATCH v5 2/3] remove check hooks for GUCs that contribute to MaxBackends Nathan Bossart <[email protected]> 2024-06-19 18:39 [PATCH v5 2/3] remove check hooks for GUCs that contribute to MaxBackends Nathan Bossart <[email protected]> 2024-06-19 18:39 [PATCH v1 1/1] remove check hooks for GUCs that contribute to MaxBackends Nathan Bossart <[email protected]> 2026-03-11 14:20 [PATCH 5/7] Use BulkInsertState when copying data to the new heap. Antonin Houska <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]> 2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox