agora inbox for [email protected]  

help / color / mirror / Atom feed

[PATCH v8 1/5] Zero initialize instr_time uses causing compiler warnings
55+ messages / 3 participants
[nested] [flat]

* [PATCH v8 1/5] Zero initialize instr_time uses causing compiler warnings
@ 2023-01-16 18:04  Andres Freund <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Andres Freund @ 2023-01-16 18:04 UTC (permalink / raw)

These are all not necessary from a correctness POV. However, in a subsequent
patch instr_time will be simplified to an int64, at which point gcc would
otherwise start to warn about the changed places.

Author:
Reviewed-by:
Discussion: https://postgr.es/m/[email protected]
Backpatch:
---
 src/backend/access/transam/xlog.c   | 4 ++++
 src/backend/storage/buffer/bufmgr.c | 4 ++++
 src/backend/storage/file/buffile.c  | 4 ++++
 src/backend/storage/ipc/latch.c     | 2 ++
 src/bin/psql/common.c               | 6 ++++++
 5 files changed, 20 insertions(+)

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index cc0d9a05d9f..fb4c860bdea 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -2191,6 +2191,8 @@ XLogWrite(XLogwrtRqst WriteRqst, TimeLineID tli, bool flexible)
 				/* Measure I/O timing to write WAL data */
 				if (track_wal_io_timing)
 					INSTR_TIME_SET_CURRENT(start);
+				else
+					INSTR_TIME_SET_ZERO(start);
 
 				pgstat_report_wait_start(WAIT_EVENT_WAL_WRITE);
 				written = pg_pwrite(openLogFile, from, nleft, startoffset);
@@ -8151,6 +8153,8 @@ issue_xlog_fsync(int fd, XLogSegNo segno, TimeLineID tli)
 	/* Measure I/O timing to sync the WAL file */
 	if (track_wal_io_timing)
 		INSTR_TIME_SET_CURRENT(start);
+	else
+		INSTR_TIME_SET_ZERO(start);
 
 	pgstat_report_wait_start(WAIT_EVENT_WAL_SYNC);
 	switch (sync_method)
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 8075828e8a6..800a4248c95 100644
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -1017,6 +1017,8 @@ ReadBuffer_common(SMgrRelation smgr, char relpersistence, ForkNumber forkNum,
 
 			if (track_io_timing)
 				INSTR_TIME_SET_CURRENT(io_start);
+			else
+				INSTR_TIME_SET_ZERO(io_start);
 
 			smgrread(smgr, forkNum, blockNum, (char *) bufBlock);
 
@@ -2902,6 +2904,8 @@ FlushBuffer(BufferDesc *buf, SMgrRelation reln)
 
 	if (track_io_timing)
 		INSTR_TIME_SET_CURRENT(io_start);
+	else
+		INSTR_TIME_SET_ZERO(io_start);
 
 	/*
 	 * bufToWrite is either the shared buffer or a copy, as appropriate.
diff --git a/src/backend/storage/file/buffile.c b/src/backend/storage/file/buffile.c
index c5464b6aa62..0a51624df3b 100644
--- a/src/backend/storage/file/buffile.c
+++ b/src/backend/storage/file/buffile.c
@@ -446,6 +446,8 @@ BufFileLoadBuffer(BufFile *file)
 
 	if (track_io_timing)
 		INSTR_TIME_SET_CURRENT(io_start);
+	else
+		INSTR_TIME_SET_ZERO(io_start);
 
 	/*
 	 * Read whatever we can get, up to a full bufferload.
@@ -525,6 +527,8 @@ BufFileDumpBuffer(BufFile *file)
 
 		if (track_io_timing)
 			INSTR_TIME_SET_CURRENT(io_start);
+		else
+			INSTR_TIME_SET_ZERO(io_start);
 
 		bytestowrite = FileWrite(thisfile,
 								 file->buffer.data + wpos,
diff --git a/src/backend/storage/ipc/latch.c b/src/backend/storage/ipc/latch.c
index d79d71a8515..f4123e7de7e 100644
--- a/src/backend/storage/ipc/latch.c
+++ b/src/backend/storage/ipc/latch.c
@@ -1401,6 +1401,8 @@ WaitEventSetWait(WaitEventSet *set, long timeout,
 		Assert(timeout >= 0 && timeout <= INT_MAX);
 		cur_timeout = timeout;
 	}
+	else
+		INSTR_TIME_SET_ZERO(start_time);
 
 	pgstat_report_wait_start(wait_event_info);
 
diff --git a/src/bin/psql/common.c b/src/bin/psql/common.c
index 00627830c47..f907f5d4e8d 100644
--- a/src/bin/psql/common.c
+++ b/src/bin/psql/common.c
@@ -1276,6 +1276,8 @@ DescribeQuery(const char *query, double *elapsed_msec)
 
 	if (timing)
 		INSTR_TIME_SET_CURRENT(before);
+	else
+		INSTR_TIME_SET_ZERO(before);
 
 	/*
 	 * To parse the query but not execute it, we prepare it, using the unnamed
@@ -1406,6 +1408,8 @@ ExecQueryAndProcessResults(const char *query,
 
 	if (timing)
 		INSTR_TIME_SET_CURRENT(before);
+	else
+		INSTR_TIME_SET_ZERO(before);
 
 	if (pset.bind_flag)
 		success = PQsendQueryParams(pset.db, query, pset.bind_nparams, NULL, (const char * const *) pset.bind_params, NULL, NULL, 0);
@@ -1702,6 +1706,8 @@ ExecQueryUsingCursor(const char *query, double *elapsed_msec)
 
 	if (timing)
 		INSTR_TIME_SET_CURRENT(before);
+	else
+		INSTR_TIME_SET_ZERO(before);
 
 	/* if we're not in a transaction, start one */
 	if (PQtransactionStatus(pset.db) == PQTRANS_IDLE)
-- 
2.38.0


--vt42kbp2j7rjcapp
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v8-0002-instr_time-Represent-time-as-an-int64-on-all-plat.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH v5 2/3] remove check hooks for GUCs that contribute to MaxBackends
@ 2024-06-19 18:39  Nathan Bossart <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Nathan Bossart @ 2024-06-19 18:39 UTC (permalink / raw)

---
 src/backend/utils/init/postinit.c   | 57 ++++-------------------------
 src/backend/utils/misc/guc_tables.c |  8 ++--
 src/include/utils/guc_hooks.h       |  6 ---
 3 files changed, 11 insertions(+), 60 deletions(-)

diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c
index 0805398e24..8a629982c4 100644
--- a/src/backend/utils/init/postinit.c
+++ b/src/backend/utils/init/postinit.c
@@ -580,57 +580,14 @@ InitializeMaxBackends(void)
 	MaxBackends = MaxConnections + autovacuum_max_workers + 1 +
 		max_worker_processes + max_wal_senders;
 
-	/* internal error because the values were all checked previously */
 	if (MaxBackends > MAX_BACKENDS)
-		elog(ERROR, "too many backends configured");
-}
-
-/*
- * GUC check_hook for max_connections
- */
-bool
-check_max_connections(int *newval, void **extra, GucSource source)
-{
-	if (*newval + autovacuum_max_workers + 1 +
-		max_worker_processes + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for autovacuum_max_workers
- */
-bool
-check_autovacuum_max_workers(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + *newval + 1 +
-		max_worker_processes + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for max_worker_processes
- */
-bool
-check_max_worker_processes(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + autovacuum_max_workers + 1 +
-		*newval + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for max_wal_senders
- */
-bool
-check_max_wal_senders(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + autovacuum_max_workers + 1 +
-		max_worker_processes + *newval > MAX_BACKENDS)
-		return false;
-	return true;
+		ereport(ERROR,
+				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+				 errmsg("too many backends configured"),
+				 errdetail("\"max_connections\" (%d) plus \"autovacuum_max_workers\" (%d) plus \"max_worker_processes\" (%d) plus \"max_wal_senders\" (%d) must be less than %d.",
+						   MaxConnections, autovacuum_max_workers,
+						   max_worker_processes, max_wal_senders,
+						   MAX_BACKENDS - 1)));
 }
 
 /*
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index 80e77cbac9..57df7767ad 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -2208,7 +2208,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&MaxConnections,
 		100, 1, MAX_BACKENDS,
-		check_max_connections, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -2935,7 +2935,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&max_wal_senders,
 		10, 0, MAX_BACKENDS,
-		check_max_wal_senders, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -3165,7 +3165,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&max_worker_processes,
 		8, 0, MAX_BACKENDS,
-		check_max_worker_processes, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -3399,7 +3399,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&autovacuum_max_workers,
 		3, 1, MAX_BACKENDS,
-		check_autovacuum_max_workers, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
diff --git a/src/include/utils/guc_hooks.h b/src/include/utils/guc_hooks.h
index d64dc5fcdb..6304f0679b 100644
--- a/src/include/utils/guc_hooks.h
+++ b/src/include/utils/guc_hooks.h
@@ -29,8 +29,6 @@ extern bool check_application_name(char **newval, void **extra,
 								   GucSource source);
 extern void assign_application_name(const char *newval, void *extra);
 extern const char *show_archive_command(void);
-extern bool check_autovacuum_max_workers(int *newval, void **extra,
-										 GucSource source);
 extern bool check_autovacuum_work_mem(int *newval, void **extra,
 									  GucSource source);
 extern bool check_vacuum_buffer_usage_limit(int *newval, void **extra,
@@ -84,13 +82,9 @@ extern const char *show_log_timezone(void);
 extern bool check_maintenance_io_concurrency(int *newval, void **extra,
 											 GucSource source);
 extern void assign_maintenance_io_concurrency(int newval, void *extra);
-extern bool check_max_connections(int *newval, void **extra, GucSource source);
-extern bool check_max_wal_senders(int *newval, void **extra, GucSource source);
 extern bool check_max_slot_wal_keep_size(int *newval, void **extra,
 										 GucSource source);
 extern void assign_max_wal_size(int newval, void *extra);
-extern bool check_max_worker_processes(int *newval, void **extra,
-									   GucSource source);
 extern bool check_max_stack_depth(int *newval, void **extra, GucSource source);
 extern void assign_max_stack_depth(int newval, void *extra);
 extern bool check_multixact_member_buffers(int *newval, void **extra,
-- 
2.39.3 (Apple Git-146)


--wPBE4Nn73k3cOM/e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v5-0003-allow-changing-autovacuum_max_workers-without-res.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH v1 1/1] remove check hooks for GUCs that contribute to MaxBackends
@ 2024-06-19 18:39  Nathan Bossart <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Nathan Bossart @ 2024-06-19 18:39 UTC (permalink / raw)

---
 src/backend/utils/init/postinit.c   | 57 ++++-------------------------
 src/backend/utils/misc/guc_tables.c |  8 ++--
 src/include/utils/guc_hooks.h       |  6 ---
 3 files changed, 11 insertions(+), 60 deletions(-)

diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c
index 0805398e24..8a629982c4 100644
--- a/src/backend/utils/init/postinit.c
+++ b/src/backend/utils/init/postinit.c
@@ -580,57 +580,14 @@ InitializeMaxBackends(void)
 	MaxBackends = MaxConnections + autovacuum_max_workers + 1 +
 		max_worker_processes + max_wal_senders;
 
-	/* internal error because the values were all checked previously */
 	if (MaxBackends > MAX_BACKENDS)
-		elog(ERROR, "too many backends configured");
-}
-
-/*
- * GUC check_hook for max_connections
- */
-bool
-check_max_connections(int *newval, void **extra, GucSource source)
-{
-	if (*newval + autovacuum_max_workers + 1 +
-		max_worker_processes + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for autovacuum_max_workers
- */
-bool
-check_autovacuum_max_workers(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + *newval + 1 +
-		max_worker_processes + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for max_worker_processes
- */
-bool
-check_max_worker_processes(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + autovacuum_max_workers + 1 +
-		*newval + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for max_wal_senders
- */
-bool
-check_max_wal_senders(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + autovacuum_max_workers + 1 +
-		max_worker_processes + *newval > MAX_BACKENDS)
-		return false;
-	return true;
+		ereport(ERROR,
+				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+				 errmsg("too many backends configured"),
+				 errdetail("\"max_connections\" (%d) plus \"autovacuum_max_workers\" (%d) plus \"max_worker_processes\" (%d) plus \"max_wal_senders\" (%d) must be less than %d.",
+						   MaxConnections, autovacuum_max_workers,
+						   max_worker_processes, max_wal_senders,
+						   MAX_BACKENDS - 1)));
 }
 
 /*
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index 46c258be28..07b575894d 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -2207,7 +2207,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&MaxConnections,
 		100, 1, MAX_BACKENDS,
-		check_max_connections, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -2923,7 +2923,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&max_wal_senders,
 		10, 0, MAX_BACKENDS,
-		check_max_wal_senders, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -3153,7 +3153,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&max_worker_processes,
 		8, 0, MAX_BACKENDS,
-		check_max_worker_processes, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -3387,7 +3387,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&autovacuum_max_workers,
 		3, 1, MAX_BACKENDS,
-		check_autovacuum_max_workers, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
diff --git a/src/include/utils/guc_hooks.h b/src/include/utils/guc_hooks.h
index d64dc5fcdb..6304f0679b 100644
--- a/src/include/utils/guc_hooks.h
+++ b/src/include/utils/guc_hooks.h
@@ -29,8 +29,6 @@ extern bool check_application_name(char **newval, void **extra,
 								   GucSource source);
 extern void assign_application_name(const char *newval, void *extra);
 extern const char *show_archive_command(void);
-extern bool check_autovacuum_max_workers(int *newval, void **extra,
-										 GucSource source);
 extern bool check_autovacuum_work_mem(int *newval, void **extra,
 									  GucSource source);
 extern bool check_vacuum_buffer_usage_limit(int *newval, void **extra,
@@ -84,13 +82,9 @@ extern const char *show_log_timezone(void);
 extern bool check_maintenance_io_concurrency(int *newval, void **extra,
 											 GucSource source);
 extern void assign_maintenance_io_concurrency(int newval, void *extra);
-extern bool check_max_connections(int *newval, void **extra, GucSource source);
-extern bool check_max_wal_senders(int *newval, void **extra, GucSource source);
 extern bool check_max_slot_wal_keep_size(int *newval, void **extra,
 										 GucSource source);
 extern void assign_max_wal_size(int newval, void *extra);
-extern bool check_max_worker_processes(int *newval, void **extra,
-									   GucSource source);
 extern bool check_max_stack_depth(int *newval, void **extra, GucSource source);
 extern void assign_max_stack_depth(int newval, void *extra);
 extern bool check_multixact_member_buffers(int *newval, void **extra,
-- 
2.39.3 (Apple Git-146)


--4rSPnp6/pm7uSOZW--





^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH v1 1/1] remove check hooks for GUCs that contribute to MaxBackends
@ 2024-06-19 18:39  Nathan Bossart <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Nathan Bossart @ 2024-06-19 18:39 UTC (permalink / raw)

---
 src/backend/utils/init/postinit.c   | 57 ++++-------------------------
 src/backend/utils/misc/guc_tables.c |  8 ++--
 src/include/utils/guc_hooks.h       |  6 ---
 3 files changed, 11 insertions(+), 60 deletions(-)

diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c
index 0805398e24..8a629982c4 100644
--- a/src/backend/utils/init/postinit.c
+++ b/src/backend/utils/init/postinit.c
@@ -580,57 +580,14 @@ InitializeMaxBackends(void)
 	MaxBackends = MaxConnections + autovacuum_max_workers + 1 +
 		max_worker_processes + max_wal_senders;
 
-	/* internal error because the values were all checked previously */
 	if (MaxBackends > MAX_BACKENDS)
-		elog(ERROR, "too many backends configured");
-}
-
-/*
- * GUC check_hook for max_connections
- */
-bool
-check_max_connections(int *newval, void **extra, GucSource source)
-{
-	if (*newval + autovacuum_max_workers + 1 +
-		max_worker_processes + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for autovacuum_max_workers
- */
-bool
-check_autovacuum_max_workers(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + *newval + 1 +
-		max_worker_processes + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for max_worker_processes
- */
-bool
-check_max_worker_processes(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + autovacuum_max_workers + 1 +
-		*newval + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for max_wal_senders
- */
-bool
-check_max_wal_senders(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + autovacuum_max_workers + 1 +
-		max_worker_processes + *newval > MAX_BACKENDS)
-		return false;
-	return true;
+		ereport(ERROR,
+				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+				 errmsg("too many backends configured"),
+				 errdetail("\"max_connections\" (%d) plus \"autovacuum_max_workers\" (%d) plus \"max_worker_processes\" (%d) plus \"max_wal_senders\" (%d) must be less than %d.",
+						   MaxConnections, autovacuum_max_workers,
+						   max_worker_processes, max_wal_senders,
+						   MAX_BACKENDS - 1)));
 }
 
 /*
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index 46c258be28..07b575894d 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -2207,7 +2207,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&MaxConnections,
 		100, 1, MAX_BACKENDS,
-		check_max_connections, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -2923,7 +2923,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&max_wal_senders,
 		10, 0, MAX_BACKENDS,
-		check_max_wal_senders, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -3153,7 +3153,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&max_worker_processes,
 		8, 0, MAX_BACKENDS,
-		check_max_worker_processes, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -3387,7 +3387,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&autovacuum_max_workers,
 		3, 1, MAX_BACKENDS,
-		check_autovacuum_max_workers, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
diff --git a/src/include/utils/guc_hooks.h b/src/include/utils/guc_hooks.h
index d64dc5fcdb..6304f0679b 100644
--- a/src/include/utils/guc_hooks.h
+++ b/src/include/utils/guc_hooks.h
@@ -29,8 +29,6 @@ extern bool check_application_name(char **newval, void **extra,
 								   GucSource source);
 extern void assign_application_name(const char *newval, void *extra);
 extern const char *show_archive_command(void);
-extern bool check_autovacuum_max_workers(int *newval, void **extra,
-										 GucSource source);
 extern bool check_autovacuum_work_mem(int *newval, void **extra,
 									  GucSource source);
 extern bool check_vacuum_buffer_usage_limit(int *newval, void **extra,
@@ -84,13 +82,9 @@ extern const char *show_log_timezone(void);
 extern bool check_maintenance_io_concurrency(int *newval, void **extra,
 											 GucSource source);
 extern void assign_maintenance_io_concurrency(int newval, void *extra);
-extern bool check_max_connections(int *newval, void **extra, GucSource source);
-extern bool check_max_wal_senders(int *newval, void **extra, GucSource source);
 extern bool check_max_slot_wal_keep_size(int *newval, void **extra,
 										 GucSource source);
 extern void assign_max_wal_size(int newval, void *extra);
-extern bool check_max_worker_processes(int *newval, void **extra,
-									   GucSource source);
 extern bool check_max_stack_depth(int *newval, void **extra, GucSource source);
 extern void assign_max_stack_depth(int newval, void *extra);
 extern bool check_multixact_member_buffers(int *newval, void **extra,
-- 
2.39.3 (Apple Git-146)


--4rSPnp6/pm7uSOZW--





^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH v5 2/3] remove check hooks for GUCs that contribute to MaxBackends
@ 2024-06-19 18:39  Nathan Bossart <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Nathan Bossart @ 2024-06-19 18:39 UTC (permalink / raw)

---
 src/backend/utils/init/postinit.c   | 57 ++++-------------------------
 src/backend/utils/misc/guc_tables.c |  8 ++--
 src/include/utils/guc_hooks.h       |  6 ---
 3 files changed, 11 insertions(+), 60 deletions(-)

diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c
index 0805398e24..8a629982c4 100644
--- a/src/backend/utils/init/postinit.c
+++ b/src/backend/utils/init/postinit.c
@@ -580,57 +580,14 @@ InitializeMaxBackends(void)
 	MaxBackends = MaxConnections + autovacuum_max_workers + 1 +
 		max_worker_processes + max_wal_senders;
 
-	/* internal error because the values were all checked previously */
 	if (MaxBackends > MAX_BACKENDS)
-		elog(ERROR, "too many backends configured");
-}
-
-/*
- * GUC check_hook for max_connections
- */
-bool
-check_max_connections(int *newval, void **extra, GucSource source)
-{
-	if (*newval + autovacuum_max_workers + 1 +
-		max_worker_processes + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for autovacuum_max_workers
- */
-bool
-check_autovacuum_max_workers(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + *newval + 1 +
-		max_worker_processes + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for max_worker_processes
- */
-bool
-check_max_worker_processes(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + autovacuum_max_workers + 1 +
-		*newval + max_wal_senders > MAX_BACKENDS)
-		return false;
-	return true;
-}
-
-/*
- * GUC check_hook for max_wal_senders
- */
-bool
-check_max_wal_senders(int *newval, void **extra, GucSource source)
-{
-	if (MaxConnections + autovacuum_max_workers + 1 +
-		max_worker_processes + *newval > MAX_BACKENDS)
-		return false;
-	return true;
+		ereport(ERROR,
+				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+				 errmsg("too many backends configured"),
+				 errdetail("\"max_connections\" (%d) plus \"autovacuum_max_workers\" (%d) plus \"max_worker_processes\" (%d) plus \"max_wal_senders\" (%d) must be less than %d.",
+						   MaxConnections, autovacuum_max_workers,
+						   max_worker_processes, max_wal_senders,
+						   MAX_BACKENDS - 1)));
 }
 
 /*
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index 80e77cbac9..57df7767ad 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -2208,7 +2208,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&MaxConnections,
 		100, 1, MAX_BACKENDS,
-		check_max_connections, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -2935,7 +2935,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&max_wal_senders,
 		10, 0, MAX_BACKENDS,
-		check_max_wal_senders, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -3165,7 +3165,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&max_worker_processes,
 		8, 0, MAX_BACKENDS,
-		check_max_worker_processes, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
@@ -3399,7 +3399,7 @@ struct config_int ConfigureNamesInt[] =
 		},
 		&autovacuum_max_workers,
 		3, 1, MAX_BACKENDS,
-		check_autovacuum_max_workers, NULL, NULL
+		NULL, NULL, NULL
 	},
 
 	{
diff --git a/src/include/utils/guc_hooks.h b/src/include/utils/guc_hooks.h
index d64dc5fcdb..6304f0679b 100644
--- a/src/include/utils/guc_hooks.h
+++ b/src/include/utils/guc_hooks.h
@@ -29,8 +29,6 @@ extern bool check_application_name(char **newval, void **extra,
 								   GucSource source);
 extern void assign_application_name(const char *newval, void *extra);
 extern const char *show_archive_command(void);
-extern bool check_autovacuum_max_workers(int *newval, void **extra,
-										 GucSource source);
 extern bool check_autovacuum_work_mem(int *newval, void **extra,
 									  GucSource source);
 extern bool check_vacuum_buffer_usage_limit(int *newval, void **extra,
@@ -84,13 +82,9 @@ extern const char *show_log_timezone(void);
 extern bool check_maintenance_io_concurrency(int *newval, void **extra,
 											 GucSource source);
 extern void assign_maintenance_io_concurrency(int newval, void *extra);
-extern bool check_max_connections(int *newval, void **extra, GucSource source);
-extern bool check_max_wal_senders(int *newval, void **extra, GucSource source);
 extern bool check_max_slot_wal_keep_size(int *newval, void **extra,
 										 GucSource source);
 extern void assign_max_wal_size(int newval, void *extra);
-extern bool check_max_worker_processes(int *newval, void **extra,
-									   GucSource source);
 extern bool check_max_stack_depth(int *newval, void **extra, GucSource source);
 extern void assign_max_stack_depth(int newval, void *extra);
 extern bool check_multixact_member_buffers(int *newval, void **extra,
-- 
2.39.3 (Apple Git-146)


--wPBE4Nn73k3cOM/e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v5-0003-allow-changing-autovacuum_max_workers-without-res.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

* [PATCH 3/4] Add missing period to HINT message
@ 2026-05-28 02:53  Kyotaro Horiguchi <[email protected]>
  0 siblings, 0 replies; 55+ messages in thread

From: Kyotaro Horiguchi @ 2026-05-28 02:53 UTC (permalink / raw)

Add a trailing period to a HINT message.
---
 src/backend/libpq/be-secure-openssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index f2738c351f9..e81d2eab3fd 100644
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -364,7 +364,7 @@ be_tls_init(bool isServerStart)
 				errcode(ERRCODE_CONFIG_FILE_ERROR),
 				errmsg("no SSL configurations loaded"),
 		/*- translator: The two %s contain filenames */
-				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\"",
+				errhint("If ssl_sni is enabled then add configuration to \"%s\", else \"%s\".",
 						"pg_hosts.conf", "postgresql.conf"));
 		goto error;
 	}
-- 
2.47.3


----Next_Part(Thu_May_28_12_16_22_2026_214)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0004-Use-singular-datachecksum-consistently-in-process-na.patch"



^ permalink  raw  reply  [nested|flat] 55+ messages in thread

end of thread, other threads:[~2026-05-28 02:53 UTC | newest]

Thread overview: 55+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-01-16 18:04 [PATCH v8 1/5] Zero initialize instr_time uses causing compiler warnings Andres Freund <[email protected]>
2024-06-19 18:39 [PATCH v1 1/1] remove check hooks for GUCs that contribute to MaxBackends Nathan Bossart <[email protected]>
2024-06-19 18:39 [PATCH v5 2/3] remove check hooks for GUCs that contribute to MaxBackends Nathan Bossart <[email protected]>
2024-06-19 18:39 [PATCH v5 2/3] remove check hooks for GUCs that contribute to MaxBackends Nathan Bossart <[email protected]>
2024-06-19 18:39 [PATCH v1 1/1] remove check hooks for GUCs that contribute to MaxBackends Nathan Bossart <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>
2026-05-28 02:53 [PATCH 3/4] Add missing period to HINT message Kyotaro Horiguchi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox