agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Arseny Sher <sher-ars@yandex.ru>
Subject: [PATCH 2/2] Stop demanding that top xact must be seen before subxact in decoding.
Date: Wed, 23 Oct 2019 15:56:46 +0300
Manifested as
ERROR: subtransaction logged without previous top-level txn record
this check forbids legit behaviours like
- First xl_xact_assignment record is beyond reading, i.e. earlier
restart_lsn.
- After restart_lsn there is some change of a subxact.
- After that, there is second xl_xact_assignment (for another subxact)
revealing relationship between top and first subxact.
Such transaction won't be streamed anyway because we hadn't seen it in full;
confirmed_flush_lsn must be past all these records. Saying for sure whether xact
of some record encountered after snapshot was deserialized can be streamed or
not requires to know whether it wrote something before deserialization point --
if yes, it hasn't been seen in full and can't be decoded. Snapshot doesn't have
such info, so there is no easy way to relax the check.
---
src/backend/replication/logical/reorderbuffer.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index 8ce28ad629..6faba6077e 100644
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -778,9 +778,6 @@ ReorderBufferAssignChild(ReorderBuffer *rb, TransactionId xid,
txn = ReorderBufferTXNByXid(rb, xid, true, &new_top, lsn, true);
subtxn = ReorderBufferTXNByXid(rb, subxid, true, &new_sub, lsn, false);
- if (new_top && !new_sub)
- elog(ERROR, "subtransaction logged without previous top-level txn record");
-
if (!new_sub)
{
if (subtxn->is_known_as_subxact)
--
2.11.0
--=-=-=
Content-Type: text/plain
--
Arseny Sher
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--=-=-=--
view thread (7+ messages) latest in thread
Message-ID: <no-message-id-710745@localhost>
Permalink: ../../no-message-id-710745@localhost/
Also on: postgresql.org/message-id/no-message-id-710745@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sher-ars@yandex.ru
Subject: Re: [PATCH 2/2] Stop demanding that top xact must be seen before subxact in decoding.
In-Reply-To: <no-message-id-710745@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox