agora inbox for [email protected]
help / color / mirror / Atom feedFrom: Álvaro Herrera <[email protected]>
Subject: [PATCH v5] Log a note at program start when running in dry-run mode
Date: Tue, 11 Nov 2025 09:54:19 +0100
Users might get some peace of mind knowing their data is not being
destroyed or whatever.
Author: Peter Smith <[email protected]>
Reviewed-by: Álvaro Herrera <[email protected]>
Discussion: https://postgr.es/m/CAHut+PsvQJQnQO0KT0S2oegenkvJ8FUuY-QS5syyqmT24R2xFQ@mail.gmail.com
---
src/bin/pg_archivecleanup/pg_archivecleanup.c | 4 ++++
src/bin/pg_basebackup/pg_createsubscriber.c | 5 +++++
src/bin/pg_combinebackup/pg_combinebackup.c | 4 ++++
src/bin/pg_resetwal/pg_resetwal.c | 4 ++++
src/bin/pg_rewind/pg_rewind.c | 10 ++++++----
5 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/src/bin/pg_archivecleanup/pg_archivecleanup.c b/src/bin/pg_archivecleanup/pg_archivecleanup.c
index c25348bcb85..ab686b4748c 100644
--- a/src/bin/pg_archivecleanup/pg_archivecleanup.c
+++ b/src/bin/pg_archivecleanup/pg_archivecleanup.c
@@ -375,6 +375,10 @@ main(int argc, char **argv)
exit(2);
}
+ if (dryrun)
+ pg_log_info("Executing in dry-run mode.\n"
+ "No files will be removed.");
+
/*
* Check archive exists and other initialization if required.
*/
diff --git a/src/bin/pg_basebackup/pg_createsubscriber.c b/src/bin/pg_basebackup/pg_createsubscriber.c
index df41836e70f..cc4be5d6ef4 100644
--- a/src/bin/pg_basebackup/pg_createsubscriber.c
+++ b/src/bin/pg_basebackup/pg_createsubscriber.c
@@ -2305,6 +2305,11 @@ main(int argc, char **argv)
pg_log_error_hint("Try \"%s --help\" for more information.", progname);
exit(1);
}
+
+ if (dry_run)
+ pg_log_info("Executing in dry-run mode.\n"
+ "The target directory will not be modified.");
+
pg_log_info("validating publisher connection string");
pub_base_conninfo = get_base_conninfo(opt.pub_conninfo_str,
&dbname_conninfo);
diff --git a/src/bin/pg_combinebackup/pg_combinebackup.c b/src/bin/pg_combinebackup/pg_combinebackup.c
index 3a325127209..c9bf0a9e105 100644
--- a/src/bin/pg_combinebackup/pg_combinebackup.c
+++ b/src/bin/pg_combinebackup/pg_combinebackup.c
@@ -242,6 +242,10 @@ main(int argc, char *argv[])
if (opt.no_manifest)
opt.manifest_checksums = CHECKSUM_TYPE_NONE;
+ if (opt.dry_run)
+ pg_log_info("Executing in dry-run mode.\n"
+ "The target directory will not be modified.");
+
/* Check that the platform supports the requested copy method. */
if (opt.copy_method == COPY_METHOD_CLONE)
{
diff --git a/src/bin/pg_resetwal/pg_resetwal.c b/src/bin/pg_resetwal/pg_resetwal.c
index a89d72fc5cf..dd5d279521e 100644
--- a/src/bin/pg_resetwal/pg_resetwal.c
+++ b/src/bin/pg_resetwal/pg_resetwal.c
@@ -397,6 +397,10 @@ main(int argc, char *argv[])
exit(1);
}
+ if (noupdate)
+ pg_log_info("Executing in dry-run mode.\n"
+ "Nothing will be modified.");
+
/*
* Attempt to read the existing pg_control file
*/
diff --git a/src/bin/pg_rewind/pg_rewind.c b/src/bin/pg_rewind/pg_rewind.c
index 27c514f934a..e9364d04f76 100644
--- a/src/bin/pg_rewind/pg_rewind.c
+++ b/src/bin/pg_rewind/pg_rewind.c
@@ -300,10 +300,12 @@ main(int argc, char **argv)
atexit(disconnect_atexit);
- /*
- * Ok, we have all the options and we're ready to start. First, connect to
- * remote server.
- */
+ /* Ok, we have all the options and we're ready to start. */
+ if (dry_run)
+ pg_log_info("Executing in dry-run mode.\n"
+ "The target directory will not be modified.");
+
+ /* First, connect to remote server. */
if (connstr_source)
{
conn = PQconnectdb(connstr_source);
--
2.47.3
--ibfr3ah5qy6tcbhw--
view thread (58+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [PATCH v5] Log a note at program start when running in dry-run mode
In-Reply-To: <no-message-id-716771@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox