[PATCH v1] Add more debugging information when dropping twice pgstats entry

agora inbox for [email protected]  
help / color / mirror / Atom feed

[PATCH v1] Add more debugging information when dropping twice pgstats entry
218+ messages / 2 participants
[nested] [flat]

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH v1] Add more debugging information when dropping twice pgstats entry
@ 2025-08-07 07:58  Bertrand Drouvot <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Bertrand Drouvot @ 2025-08-07 07:58 UTC (permalink / raw)

Dropping twice a pgstats entry should not happen, still the error generated
is missing the "generation" counter that has been added in 818119afccd3.

This commit adds it as it could be helpful for debugging.
---
 src/backend/utils/activity/pgstat_shmem.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 100.0% src/backend/utils/activity/

diff --git a/src/backend/utils/activity/pgstat_shmem.c b/src/backend/utils/activity/pgstat_shmem.c
index 53e7d534270..cca4277f234 100644
--- a/src/backend/utils/activity/pgstat_shmem.c
+++ b/src/backend/utils/activity/pgstat_shmem.c
@@ -874,11 +874,12 @@ pgstat_drop_entry_internal(PgStatShared_HashEntry *shent,
 	 */
 	if (shent->dropped)
 		elog(ERROR,
-			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u",
+			 "trying to drop stats entry already dropped: kind=%s dboid=%u objid=%" PRIu64 " refcount=%u generation=%u",
 			 pgstat_get_kind_info(shent->key.kind)->name,
 			 shent->key.dboid,
 			 shent->key.objid,
-			 pg_atomic_read_u32(&shent->refcount));
+			 pg_atomic_read_u32(&shent->refcount),
+			 pg_atomic_read_u32(&shent->generation));
 	shent->dropped = true;
 
 	/* release refcount marking entry as not dropped */
-- 
2.34.1


--cBfK+H365tIcgH0p--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

* [PATCH 2/2] REPACK: do not require LOGIN privileges
@ 2026-04-20 11:19  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 218+ messages in thread

From: Álvaro Herrera @ 2026-04-20 11:19 UTC (permalink / raw)

Normally, starting a background worker does require LOGIN, which is
fine.  However, the bgworker used for REPACK has no business requiring
it.  It's just user-unfriendly and prevents repacking tables
comfortably.
---
 src/backend/commands/repack_worker.c  | 5 +++--
 src/test/regress/expected/cluster.out | 2 +-
 src/test/regress/sql/cluster.sql      | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/repack_worker.c b/src/backend/commands/repack_worker.c
index e4a4860805b..c40f8c98e06 100644
--- a/src/backend/commands/repack_worker.c
+++ b/src/backend/commands/repack_worker.c
@@ -106,8 +106,9 @@ RepackWorkerMain(Datum main_arg)
 	pq_set_parallel_leader(shared->backend_pid,
 						   shared->backend_proc_number);
 
-	/* Connect to the database. */
-	BackgroundWorkerInitializeConnectionByOid(shared->dbid, shared->roleid, 0);
+	/* Connect to the database. LOGIN is not required. */
+	BackgroundWorkerInitializeConnectionByOid(shared->dbid, shared->roleid,
+											  BGWORKER_BYPASS_ROLELOGINCHECK);
 
 	/*
 	 * Transaction is needed to open relation, and it also provides us with a
diff --git a/src/test/regress/expected/cluster.out b/src/test/regress/expected/cluster.out
index e17bc91fae1..71270134985 100644
--- a/src/test/regress/expected/cluster.out
+++ b/src/test/regress/expected/cluster.out
@@ -546,7 +546,7 @@ DROP TABLE clstrpart;
 CREATE TABLE ptnowner(i int unique not null) PARTITION BY LIST (i);
 CREATE INDEX ptnowner_i_idx ON ptnowner(i);
 CREATE TABLE ptnowner1 PARTITION OF ptnowner FOR VALUES IN (1);
-CREATE ROLE regress_ptnowner LOGIN;
+CREATE ROLE regress_ptnowner;
 CREATE TABLE ptnowner2 PARTITION OF ptnowner FOR VALUES IN (2);
 ALTER TABLE ptnowner1 OWNER TO regress_ptnowner;
 SET SESSION AUTHORIZATION regress_ptnowner;
diff --git a/src/test/regress/sql/cluster.sql b/src/test/regress/sql/cluster.sql
index 1f471a8821a..6746236ffec 100644
--- a/src/test/regress/sql/cluster.sql
+++ b/src/test/regress/sql/cluster.sql
@@ -257,7 +257,7 @@ DROP TABLE clstrpart;
 CREATE TABLE ptnowner(i int unique not null) PARTITION BY LIST (i);
 CREATE INDEX ptnowner_i_idx ON ptnowner(i);
 CREATE TABLE ptnowner1 PARTITION OF ptnowner FOR VALUES IN (1);
-CREATE ROLE regress_ptnowner LOGIN;
+CREATE ROLE regress_ptnowner;
 CREATE TABLE ptnowner2 PARTITION OF ptnowner FOR VALUES IN (2);
 ALTER TABLE ptnowner1 OWNER TO regress_ptnowner;
 SET SESSION AUTHORIZATION regress_ptnowner;
-- 
2.47.3


--m6zy3l65ushq557m--





^ permalink  raw  reply  [nested|flat] 218+ messages in thread

end of thread, other threads:[~2026-04-20 11:19 UTC | newest]

Thread overview: 218+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2025-08-07 07:58 [PATCH v1] Add more debugging information when dropping twice pgstats entry Bertrand Drouvot <[email protected]>
2026-04-20 11:19 [PATCH 2/2] REPACK: do not require LOGIN privileges Álvaro Herrera <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox