agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH 2/2] Remove dsm_seg from DecodingWorkerShared. 298+ messages / 2 participants [nested] [flat]
* [PATCH 2/2] Remove dsm_seg from DecodingWorkerShared. @ 2026-04-13 09:36 Antonin Houska <ah@cybertec.at> 0 siblings, 0 replies; 298+ messages in thread From: Antonin Houska @ 2026-04-13 09:36 UTC (permalink / raw) The value is only needed by te worker, so there is no need to store it in shared memory. --- src/backend/commands/repack_worker.c | 5 +++-- src/include/commands/repack_internal.h | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/commands/repack_worker.c b/src/backend/commands/repack_worker.c index 5bd020e0184..a594d6db25f 100644 --- a/src/backend/commands/repack_worker.c +++ b/src/backend/commands/repack_worker.c @@ -51,6 +51,7 @@ static XLogSegNo repack_current_segment = 0; static RelFileLocator repacked_rel_locator = {.relNumber = InvalidOid}; static RelFileLocator repacked_rel_toast_locator = {.relNumber = InvalidOid}; +static dsm_segment *worker_dsm_segment = NULL; /* REPACK decoding worker entry point */ void @@ -78,9 +79,9 @@ RepackWorkerMain(Datum main_arg) ereport(ERROR, errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), errmsg("could not map dynamic shared memory segment")); + worker_dsm_segment = seg; shared = (DecodingWorkerShared *) dsm_segment_address(seg); - shared->dsm_seg = seg; /* Arrange to signal the leader if we exit. */ before_shmem_exit(RepackWorkerShutdown, PointerGetDatum(shared)); @@ -176,7 +177,7 @@ RepackWorkerShutdown(int code, Datum arg) PROCSIG_REPACK_MESSAGE, shared->backend_proc_number); - dsm_detach(shared->dsm_seg); + dsm_detach(worker_dsm_segment); } bool diff --git a/src/include/commands/repack_internal.h b/src/include/commands/repack_internal.h index 3ff64444351..6a85cee8910 100644 --- a/src/include/commands/repack_internal.h +++ b/src/include/commands/repack_internal.h @@ -107,7 +107,6 @@ typedef struct DecodingWorkerShared PGPROC *backend_proc; pid_t backend_pid; ProcNumber backend_proc_number; - dsm_segment *dsm_seg; /* * Memory the queue is located in. -- 2.47.3 --=-=-=-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 298+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 298+ messages in thread
end of thread, other threads:[~2026-05-26 10:45 UTC | newest] Thread overview: 298+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-13 09:36 [PATCH 2/2] Remove dsm_seg from DecodingWorkerShared. Antonin Houska <ah@cybertec.at> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox