agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH v24 4/7] default to --with-lz4 4+ messages / 2 participants [nested] [flat]
* [PATCH v24 4/7] default to --with-lz4 @ 2021-02-14 04:11 Justin Pryzby <pryzbyj@telsasoft.com> 0 siblings, 0 replies; 4+ messages in thread From: Justin Pryzby @ 2021-02-14 04:11 UTC (permalink / raw) this is meant to excercize the new feature in the CIs, and not meant to be merged --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 63940b78a0..1fb0f07323 100644 --- a/configure.ac +++ b/configure.ac @@ -990,8 +990,8 @@ AC_SUBST(with_zlib) # LZ4 # AC_MSG_CHECKING([whether to build with LZ4 support]) -PGAC_ARG_BOOL(with, lz4, no, [build with LZ4 support], - [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build with LZ4 support. (--with-lz4)])]) +PGAC_ARG_BOOL(without, lz4, no, [build without LZ4 support], + [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build without LZ4 support. (--without-lz4)])]) AC_SUBST(with_lz4) # -- 2.17.0 --YZ5djTAD1cGYuMQK Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v24-0005-fixups.patch.patch" ^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH v4 3/3] Remove short sleep from 001_start_stop.pl @ 2023-10-24 05:47 Kyotaro Horiguchi <horikyota.ntt@gmail.com> 0 siblings, 0 replies; 4+ messages in thread From: Kyotaro Horiguchi @ 2023-10-24 05:47 UTC (permalink / raw) Previous commits ensures reliable detection whether the postmaster has really started or not, so the short sleep in a test is not needed anymore. It was originally introduced by 6bcce258. --- src/bin/pg_ctl/t/001_start_stop.pl | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/bin/pg_ctl/t/001_start_stop.pl b/src/bin/pg_ctl/t/001_start_stop.pl index f019fe1703..590a82338f 100644 --- a/src/bin/pg_ctl/t/001_start_stop.pl +++ b/src/bin/pg_ctl/t/001_start_stop.pl @@ -46,11 +46,6 @@ my $ctlcmd = [ ]; command_like($ctlcmd, qr/done.*server started/s, 'pg_ctl start'); -# sleep here is because Windows builds can't check postmaster.pid exactly, -# so they may mistake a pre-existing postmaster.pid for one created by the -# postmaster they start. Waiting more than the 2 seconds slop time allowed -# by wait_for_postmaster() prevents that mistake. -sleep 3 if ($windows_os); command_fails([ 'pg_ctl', 'start', '-D', "$tempdir/data" ], 'second pg_ctl start fails'); command_ok([ 'pg_ctl', 'stop', '-D', "$tempdir/data" ], 'pg_ctl stop'); -- 2.39.3 ----Next_Part(Tue_Oct_24_15_00_27_2023_044)---- ^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH v5 3/3] Remove short sleep from 001_start_stop.pl @ 2023-10-24 05:47 Kyotaro Horiguchi <horikyota.ntt@gmail.com> 0 siblings, 0 replies; 4+ messages in thread From: Kyotaro Horiguchi @ 2023-10-24 05:47 UTC (permalink / raw) Previous commits ensures reliable detection whether the postmaster has really started or not, so the short sleep in a test is not needed anymore. It was originally introduced by 6bcce258. --- src/bin/pg_ctl/t/001_start_stop.pl | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/bin/pg_ctl/t/001_start_stop.pl b/src/bin/pg_ctl/t/001_start_stop.pl index f019fe1703..590a82338f 100644 --- a/src/bin/pg_ctl/t/001_start_stop.pl +++ b/src/bin/pg_ctl/t/001_start_stop.pl @@ -46,11 +46,6 @@ my $ctlcmd = [ ]; command_like($ctlcmd, qr/done.*server started/s, 'pg_ctl start'); -# sleep here is because Windows builds can't check postmaster.pid exactly, -# so they may mistake a pre-existing postmaster.pid for one created by the -# postmaster they start. Waiting more than the 2 seconds slop time allowed -# by wait_for_postmaster() prevents that mistake. -sleep 3 if ($windows_os); command_fails([ 'pg_ctl', 'start', '-D', "$tempdir/data" ], 'second pg_ctl start fails'); command_ok([ 'pg_ctl', 'stop', '-D', "$tempdir/data" ], 'pg_ctl stop'); -- 2.39.3 ----Next_Part(Tue_Oct_24_17_25_36_2023_034)---- ^ permalink raw reply [nested|flat] 4+ messages in thread
* [PATCH v6 2/2] Remove short sleep from 001_start_stop.pl @ 2023-10-24 05:47 Kyotaro Horiguchi <horikyota.ntt@gmail.com> 0 siblings, 0 replies; 4+ messages in thread From: Kyotaro Horiguchi @ 2023-10-24 05:47 UTC (permalink / raw) Previous commits ensures reliable detection whether the postmaster has really started or not, so the short sleep in a test is not needed anymore. It was originally introduced by 6bcce258. --- src/bin/pg_ctl/t/001_start_stop.pl | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/bin/pg_ctl/t/001_start_stop.pl b/src/bin/pg_ctl/t/001_start_stop.pl index fd56bf7706..b50bd30a12 100644 --- a/src/bin/pg_ctl/t/001_start_stop.pl +++ b/src/bin/pg_ctl/t/001_start_stop.pl @@ -46,11 +46,6 @@ my $ctlcmd = [ ]; command_like($ctlcmd, qr/done.*server started/s, 'pg_ctl start'); -# sleep here is because Windows builds can't check postmaster.pid exactly, -# so they may mistake a pre-existing postmaster.pid for one created by the -# postmaster they start. Waiting more than the 2 seconds slop time allowed -# by wait_for_postmaster() prevents that mistake. -sleep 3 if ($windows_os); command_fails([ 'pg_ctl', 'start', '-D', "$tempdir/data" ], 'second pg_ctl start fails'); command_ok([ 'pg_ctl', 'stop', '-D', "$tempdir/data" ], 'pg_ctl stop'); -- 2.39.3 ----Next_Part(Thu_Jan_11_17_33_22_2024_691)---- ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-10-24 05:47 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-02-14 04:11 [PATCH v24 4/7] default to --with-lz4 Justin Pryzby <pryzbyj@telsasoft.com> 2023-10-24 05:47 [PATCH v4 3/3] Remove short sleep from 001_start_stop.pl Kyotaro Horiguchi <horikyota.ntt@gmail.com> 2023-10-24 05:47 [PATCH v5 3/3] Remove short sleep from 001_start_stop.pl Kyotaro Horiguchi <horikyota.ntt@gmail.com> 2023-10-24 05:47 [PATCH v6 2/2] Remove short sleep from 001_start_stop.pl Kyotaro Horiguchi <horikyota.ntt@gmail.com>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox