agora inbox for [email protected]help / color / mirror / Atom feed
[PATCH v8 5/7] Row pattern recognition patch (docs). 180+ messages / 2 participants [nested] [flat]
* [PATCH v8 5/7] Row pattern recognition patch (docs). @ 2023-09-25 05:01 Tatsuo Ishii <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Tatsuo Ishii @ 2023-09-25 05:01 UTC (permalink / raw) --- doc/src/sgml/advanced.sgml | 52 ++++++++++++++++++++++++++++++++++ doc/src/sgml/func.sgml | 54 ++++++++++++++++++++++++++++++++++++ doc/src/sgml/ref/select.sgml | 38 +++++++++++++++++++++++-- 3 files changed, 142 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/advanced.sgml b/doc/src/sgml/advanced.sgml index 755c9f1485..f39ec8f2d5 100644 --- a/doc/src/sgml/advanced.sgml +++ b/doc/src/sgml/advanced.sgml @@ -537,6 +537,58 @@ WHERE pos < 3; <literal>rank</literal> less than 3. </para> + <para> + Row pattern common syntax can be used with row pattern common syntax to + perform row pattern recognition in a query. Row pattern common syntax + includes two sub clauses. <literal>DEFINE</literal> defines definition + variables along with an expression. The expression must be a logical + expression, which means it must + return <literal>TRUE</literal>, <literal>FALSE</literal> + or <literal>NULL</literal>. Moreover if the expression comprises a column + reference, it must be the argument of <function>rpr</function>. An example + of <literal>DEFINE</literal> is as follows. + +<programlisting> +DEFINE + LOWPRICE AS price <= 100, + UP AS price > PREV(price), + DOWN AS price < PREV(price) +</programlisting> + + Note that <function>PREV</function> returns price column in the previous + row if it's called in a context of row pattern recognition. So in the + second line means the definition variable "UP" is <literal>TRUE</literal> + when price column in the current row is greater than the price column in + the previous row. Likewise, "DOWN" is <literal>TRUE</literal> when when + price column in the current row is lower than the price column in the + previous row. + </para> + <para> + Once <literal>DEFINE</literal> exists, <literal>PATTERN</literal> can be + used. <literal>PATTERN</literal> defines a sequence of rows that satisfies + certain conditions. For example following <literal>PATTERN</literal> + defines that a row starts with the condition "LOWPRICE", then one or more + rows satisfy "UP" and finally one or more rows satisfy "DOWN". If a + sequence of rows found, rpr returns the column at the starting row. + Example of a <literal>SELECT</literal> using the <literal>DEFINE</literal> + and <literal>PATTERN</literal> clause is as follows. + +<programlisting> +SELECT company, tdate, price, max(price) OVER w FROM stock + WINDOW w AS ( + PARTITION BY company + ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING + AFTER MATCH SKIP PAST LAST ROW + INITIAL + PATTERN (LOWPRICE UP+ DOWN+) + DEFINE + LOWPRICE AS price <= 100, + UP AS price > PREV(price), + DOWN AS price < PREV(price) +); +</programlisting> + </para> + <para> When a query involves multiple window functions, it is possible to write out each one with a separate <literal>OVER</literal> clause, but this is diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 24ad87f910..9c99dda4ae 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -21780,6 +21780,7 @@ SELECT count(*) FROM sometable; returns <literal>NULL</literal> if there is no such row. </para></entry> </row> + </tbody> </tgroup> </table> @@ -21819,6 +21820,59 @@ SELECT count(*) FROM sometable; Other frame specifications can be used to obtain other effects. </para> + <para> + Row pattern recognition navigation functions are listed in + <xref linkend="functions-rpr-navigation-table"/>. These functions + can be used to describe DEFINE clause of Row pattern recognition. + </para> + + <table id="functions-rpr-navigation-table"> + <title>Row Pattern Navigation Functions</title> + <tgroup cols="1"> + <thead> + <row> + <entry role="func_table_entry"><para role="func_signature"> + Function + </para> + <para> + Description + </para></entry> + </row> + </thead> + + <tbody> + <row> + <entry role="func_table_entry"><para role="func_signature"> + <indexterm> + <primary>prev</primary> + </indexterm> + <function>prev</function> ( <parameter>value</parameter> <type>anyelement</type> ) + <returnvalue>anyelement</returnvalue> + </para> + <para> + Returns the column value at the previous row; + returns NULL if there is no previous row in the window frame. + </para></entry> + </row> + + <row> + <entry role="func_table_entry"><para role="func_signature"> + <indexterm> + <primary>next</primary> + </indexterm> + <function>next</function> ( <parameter>value</parameter> <type>anyelement</type> ) + <returnvalue>anyelement</returnvalue> + </para> + <para> + Returns the column value at the next row; + returns NULL if there is no next row in the window frame. + </para></entry> + </row> + + </tbody> + </tgroup> + </table> + <note> <para> The SQL standard defines a <literal>RESPECT NULLS</literal> or diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/select.sgml index 0ee0cc7e64..056768b330 100644 --- a/doc/src/sgml/ref/select.sgml +++ b/doc/src/sgml/ref/select.sgml @@ -966,8 +966,8 @@ WINDOW <replaceable class="parameter">window_name</replaceable> AS ( <replaceabl The <replaceable class="parameter">frame_clause</replaceable> can be one of <synopsis> -{ RANGE | ROWS | GROUPS } <replaceable>frame_start</replaceable> [ <replaceable>frame_exclusion</replaceable> ] -{ RANGE | ROWS | GROUPS } BETWEEN <replaceable>frame_start</replaceable> AND <replaceable>frame_end</replaceable> [ <replaceable>frame_exclusion</replaceable> ] +{ RANGE | ROWS | GROUPS } <replaceable>frame_start</replaceable> [ <replaceable>frame_exclusion</replaceable> ] [row_pattern_common_syntax] +{ RANGE | ROWS | GROUPS } BETWEEN <replaceable>frame_start</replaceable> AND <replaceable>frame_end</replaceable> [ <replaceable>frame_exclusion</replaceable> ] [row_pattern_common_syntax] </synopsis> where <replaceable>frame_start</replaceable> @@ -1074,6 +1074,40 @@ EXCLUDE NO OTHERS a given peer group will be in the frame or excluded from it. </para> + <para> + The + optional <replaceable class="parameter">row_pattern_common_syntax</replaceable> + defines the <firstterm>row pattern recognition condition</firstterm> for + this + window. <replaceable class="parameter">row_pattern_common_syntax</replaceable> + includes following subclauses. <literal>AFTER MATCH SKIP PAST LAST + ROW</literal> or <literal>AFTER MATCH SKIP TO NEXT ROW</literal> controls + how to proceed to next row position after a match + found. With <literal>AFTER MATCH SKIP PAST LAST ROW</literal> (the + default) next row position is next to the last row of previous match. On + the other hand, with <literal>AFTER MATCH SKIP TO NEXT ROW</literal> next + row position is always next to the last row of previous + match. <literal>DEFINE</literal> defines definition variables along with a + boolean expression. <literal>PATTERN</literal> defines a sequence of rows + that satisfies certain conditions using variables defined + in <literal>DEFINE</literal> clause. If the variable is not defined in + the <literal>DEFINE</literal> clause, it is implicitly assumed + following is defined in the <literal>DEFINE</literal> clause. + +<synopsis> +<literal>variable_name</literal> AS TRUE +</synopsis> + + Note that the maximu number of variables defined + in <literal>DEFINE</literal> clause is 26. + +<synopsis> +[ AFTER MATCH SKIP PAST LAST ROW | AFTER MATCH SKIP TO NEXT ROW ] +PATTERN <replaceable class="parameter">pattern_variable_name</replaceable>[+] [, ...] +DEFINE <replaceable class="parameter">definition_varible_name</replaceable> AS <replaceable class="parameter">expression</replaceable> [, ...] +</synopsis> + </para> + <para> The purpose of a <literal>WINDOW</literal> clause is to specify the behavior of <firstterm>window functions</firstterm> appearing in the query's -- 2.25.1 ----Next_Part(Mon_Sep_25_14_26_30_2023_752)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="v8-0006-Row-pattern-recognition-patch-tests.patch" ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
* [PATCH] POC: syslogger: add Boolean state indicating readiness @ 2026-05-26 10:45 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 180+ messages in thread From: Álvaro Herrera @ 2026-05-26 10:45 UTC (permalink / raw) This replaces a comparison of MyBackendType, which was made obsolete by commit 0c8e082fba8d. --- src/backend/postmaster/syslogger.c | 5 +++++ src/backend/utils/error/elog.c | 6 +++--- src/include/postmaster/syslogger.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index acfe0a01715..d736f6a4fab 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -76,6 +76,9 @@ char *Log_filename = NULL; bool Log_truncate_on_rotation = false; int Log_file_mode = S_IRUSR | S_IWUSR; +/* for elog.c */ +bool syslogger_setup_done = false; + /* * Private state */ @@ -195,6 +198,8 @@ SysLoggerMain(const void *startup_data, size_t startup_data_len) Assert(startup_data_len == 0); #endif + syslogger_setup_done = true; + /* * Now that we're done reading the startup data, release postmaster's * working memory context. diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c index 50c53b571a0..a6936a0c664 100644 --- a/src/backend/utils/error/elog.c +++ b/src/backend/utils/error/elog.c @@ -3831,7 +3831,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) write_csvlog(edata); else fallback_to_stderr = true; @@ -3845,7 +3845,7 @@ send_message_to_server_log(ErrorData *edata) * pipe). If this is not possible, fallback to an entry written to * stderr. */ - if (redirection_done || MyBackendType == B_LOGGER) + if (redirection_done || syslogger_setup_done) { write_jsonlog(edata); } @@ -3885,7 +3885,7 @@ send_message_to_server_log(ErrorData *edata) } /* If in the syslogger process, try to write messages direct to file */ - if (MyBackendType == B_LOGGER) + if (syslogger_setup_done) write_syslogger_file(buf.data, buf.len, LOG_DESTINATION_STDERR); /* No more need of the message formatted for stderr */ diff --git a/src/include/postmaster/syslogger.h b/src/include/postmaster/syslogger.h index 30c4b2daf3f..44409fc2542 100644 --- a/src/include/postmaster/syslogger.h +++ b/src/include/postmaster/syslogger.h @@ -85,6 +85,7 @@ extern PGDLLIMPORT int syslogPipe[2]; extern PGDLLIMPORT HANDLE syslogPipe[2]; #endif +extern bool syslogger_setup_done; extern int SysLogger_Start(int child_slot); -- 2.47.3 --oji7a74ejnbtd35k-- ^ permalink raw reply [nested|flat] 180+ messages in thread
end of thread, other threads:[~2026-05-26 10:45 UTC | newest] Thread overview: 180+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-09-25 05:01 [PATCH v8 5/7] Row pattern recognition patch (docs). Tatsuo Ishii <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]> 2026-05-26 10:45 [PATCH] POC: syslogger: add Boolean state indicating readiness Álvaro Herrera <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox