($INBOX_DIR/description missing)help / color / mirror / Atom feed
[PATCH] Highlight that pg_receivewal doesn't apply WAL, and as such synchronous-commit needs to be remote_write or lower. 3+ messages / 3 participants [nested] [flat]
* [PATCH] Highlight that pg_receivewal doesn't apply WAL, and as such synchronous-commit needs to be remote_write or lower. @ 2019-07-09 17:14 jesperpedersen <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: jesperpedersen @ 2019-07-09 17:14 UTC (permalink / raw) Authors: Álvaro Herrera, Laurenz Albe and Jesper Pedersen Review-by: Álvaro Herrera, Laurenz Albe and Jesper Pedersen --- doc/src/sgml/ref/pg_receivewal.sgml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/src/sgml/ref/pg_receivewal.sgml b/doc/src/sgml/ref/pg_receivewal.sgml index 0506120c00..16f9c41ff1 100644 --- a/doc/src/sgml/ref/pg_receivewal.sgml +++ b/doc/src/sgml/ref/pg_receivewal.sgml @@ -207,6 +207,14 @@ PostgreSQL documentation server as a synchronous standby, to ensure that timely feedback is sent to the server. </para> + + <para> + Note that while WAL will be flushed with this setting, + <application>pg_receivewal</application> never applies it, so + <xref linkend="guc-synchronous-commit"/> must not be set to + <literal>remote_apply</literal> if <application>pg_receivewal</application> + is the only synchronous standby. + </para> </listitem> </varlistentry> -- 2.21.0 --------------2AC79BB0843BAB51DC6FC758-- ^ permalink raw reply [nested|flat] 3+ messages in thread
* [PATCH v1 4/9] ci: switch tasks to debugoptimized build @ 2023-08-08 00:27 Andres Freund <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Andres Freund @ 2023-08-08 00:27 UTC (permalink / raw) In aggregate the CI tasks burn a lot of cpu hours. Compared to that easy to read backtraces aren't as important. Still use -ggdb where appropriate, as that does make backtraces more reliable, particularly in the face of optimization. Author: Reviewed-by: Discussion: https://postgr.es/m/ Backpatch: --- .cirrus.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index f3d63ff3fb0..bfe251f48e8 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -140,7 +140,7 @@ task: CCACHE_DIR: /tmp/ccache_dir CPPFLAGS: -DRELCACHE_FORCE_RELEASE -DCOPY_PARSE_PLAN_TREES -DWRITE_READ_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS - CFLAGS: -Og -ggdb + CFLAGS: -ggdb depends_on: SanityCheck only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*freebsd.*' @@ -181,7 +181,7 @@ task: configure_script: | su postgres <<-EOF meson setup \ - --buildtype=debug \ + --buildtype=debugoptimized \ -Dcassert=true -Duuid=bsd -Dtcl_version=tcl86 -Ddtrace=auto \ -DPG_TEST_EXTRA="$PG_TEST_EXTRA" \ -Dextra_lib_dirs=/usr/local/lib -Dextra_include_dirs=/usr/local/include/ \ @@ -275,7 +275,7 @@ task: ASAN_OPTIONS: print_stacktrace=1:disable_coredump=0:abort_on_error=1:detect_leaks=0 # SANITIZER_FLAGS is set in the tasks below - CFLAGS: -Og -ggdb -fno-sanitize-recover=all $SANITIZER_FLAGS + CFLAGS: -ggdb -fno-sanitize-recover=all $SANITIZER_FLAGS CXXFLAGS: $CFLAGS LDFLAGS: $SANITIZER_FLAGS CC: ccache gcc @@ -364,7 +364,7 @@ task: configure_script: | su postgres <<-EOF meson setup \ - --buildtype=debug \ + --buildtype=debugoptimized \ -Dcassert=true \ ${LINUX_MESON_FEATURES} \ -DPG_TEST_EXTRA="$PG_TEST_EXTRA" \ @@ -377,7 +377,7 @@ task: su postgres <<-EOF export CC='ccache gcc -m32' meson setup \ - --buildtype=debug \ + --buildtype=debugoptimized \ -Dcassert=true \ ${LINUX_MESON_FEATURES} \ -Dllvm=disabled \ @@ -434,8 +434,8 @@ task: CC: ccache cc CXX: ccache c++ - CFLAGS: -Og -ggdb - CXXFLAGS: -Og -ggdb + CFLAGS: -ggdb + CXXFLAGS: -ggdb depends_on: SanityCheck only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*(macos|darwin|osx).*' @@ -487,7 +487,7 @@ task: configure_script: | export PKG_CONFIG_PATH="/opt/local/lib/pkgconfig/" meson setup \ - --buildtype=debug \ + --buildtype=debugoptimized \ -Dextra_include_dirs=/opt/local/include \ -Dextra_lib_dirs=/opt/local/lib \ -Dcassert=true \ -- 2.38.0 --uu4yojthqnm7ulmd Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0005-ci-Move-use-of-Dsegsize_blocks-6-from-macos-to-li.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
* [PATCH v1] More Fix accidentally cast away qualifiers @ 2026-01-20 10:57 Bertrand Drouvot <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Bertrand Drouvot @ 2026-01-20 10:57 UTC (permalink / raw) --- src/backend/access/spgist/spgquadtreeproc.c | 8 ++++---- src/common/unicode/case_test.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) 66.9% src/backend/access/spgist/ 33.0% src/common/unicode/ diff --git a/src/backend/access/spgist/spgquadtreeproc.c b/src/backend/access/spgist/spgquadtreeproc.c index 1b907d9186b..430e802cf80 100644 --- a/src/backend/access/spgist/spgquadtreeproc.c +++ b/src/backend/access/spgist/spgquadtreeproc.c @@ -145,8 +145,8 @@ spg_quad_choose(PG_FUNCTION_ARGS) static int x_cmp(const void *a, const void *b, void *arg) { - Point *pa = *(Point **) a; - Point *pb = *(Point **) b; + Point *pa = *(Point *const *) a; + Point *pb = *(Point *const *) b; if (pa->x == pb->x) return 0; @@ -156,8 +156,8 @@ x_cmp(const void *a, const void *b, void *arg) static int y_cmp(const void *a, const void *b, void *arg) { - Point *pa = *(Point **) a; - Point *pb = *(Point **) b; + Point *pa = *(Point *const *) a; + Point *pb = *(Point *const *) b; if (pa->y == pb->y) return 0; diff --git a/src/common/unicode/case_test.c b/src/common/unicode/case_test.c index 2144219e178..fb159c1c27c 100644 --- a/src/common/unicode/case_test.c +++ b/src/common/unicode/case_test.c @@ -55,7 +55,7 @@ initcap_wbnext(void *state) while (wbstate->offset < wbstate->len && wbstate->str[wbstate->offset] != '\0') { - char32_t u = utf8_to_unicode((unsigned char *) wbstate->str + + char32_t u = utf8_to_unicode((const unsigned char *) wbstate->str + wbstate->offset); bool curr_alnum = pg_u_isalnum(u, wbstate->posix); -- 2.34.1 --1ZnbfCRkwVrWsguI-- ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-01-20 10:57 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-07-09 17:14 [PATCH] Highlight that pg_receivewal doesn't apply WAL, and as such synchronous-commit needs to be remote_write or lower. jesperpedersen <[email protected]> 2023-08-08 00:27 [PATCH v1 4/9] ci: switch tasks to debugoptimized build Andres Freund <[email protected]> 2026-01-20 10:57 [PATCH v1] More Fix accidentally cast away qualifiers Bertrand Drouvot <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox