Feedback-ID: ia2694551:Fastmail
Date: Tue, 7 Apr 2026 13:19:17 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Antonin Houska <ah@cybertec.at>
Cc: Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	Noah Misch <noah@leadboat.com>, vignesh C <vignesh21@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
 Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Pg Hackers <pgsql-hackers@lists.postgresql.org>,
	Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Message-ID: <202604071117.jo3aywpalxvt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="j4ov4p7gfxgiujzz"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <188275.1775552266@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/202604071117.jo3aywpalxvt%40alvherre.pgsql>
Precedence: bulk


--j4ov4p7gfxgiujzz
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hi,

There's one more failure in thorntail
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=thorntail&dt=2026-04-07%2006%3A31%3A03
because it runs with wal_level=minimal.  I think we can make it work by
using a temp-config argument to run the tests, as in the attached.

I didn't actually try to run the buildfarm client though ...

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

--j4ov4p7gfxgiujzz
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-Fix-tests-under-wal_level-minimal.patch"

From eed9088aacb69187734875ae94a6f97a1143193b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=81lvaro=20Herrera?= <alvherre@kurilemu.de>
Date: Tue, 7 Apr 2026 13:16:25 +0200
Subject: [PATCH] Fix tests under wal_level=minimal

Buildfarm members which have specifically configured to use
wal_level=minimal fail the repack regression tests, which require
wal_level=replica.  Add a temp config file to fix that.
---
 src/test/modules/injection_points/Makefile       | 3 +++
 src/test/modules/injection_points/meson.build    | 4 ++++
 src/test/modules/injection_points/wal_level.conf | 1 +
 3 files changed, 8 insertions(+)
 create mode 100644 src/test/modules/injection_points/wal_level.conf

diff --git a/src/test/modules/injection_points/Makefile b/src/test/modules/injection_points/Makefile
index 2cd7d87c533..2c7abe93632 100644
--- a/src/test/modules/injection_points/Makefile
+++ b/src/test/modules/injection_points/Makefile
@@ -19,6 +19,9 @@ ISOLATION = basic \
 	    syscache-update-pruned \
 	    heap_lock_update
 
+# some isolation tests require wal_level=replica
+ISOLATION_OPTS = --temp-config $(top_srcdir)/src/test/modules/injection_points/wal_level.conf
+
 # The injection points are cluster-wide, so disable installcheck
 NO_INSTALLCHECK = 1
 
diff --git a/src/test/modules/injection_points/meson.build b/src/test/modules/injection_points/meson.build
index a414abb924b..7a838259685 100644
--- a/src/test/modules/injection_points/meson.build
+++ b/src/test/modules/injection_points/meson.build
@@ -53,5 +53,9 @@ tests += {
     'runningcheck': false, # see syscache-update-pruned
     # Some tests wait for all snapshots, so avoid parallel execution
     'runningcheck-parallel': false,
+    # some tests require wal_level=replica
+    'regress_args': [
+      '--temp-config', files('wal_level.conf'),
+    ],
   },
 }
diff --git a/src/test/modules/injection_points/wal_level.conf b/src/test/modules/injection_points/wal_level.conf
new file mode 100644
index 00000000000..010abb193a8
--- /dev/null
+++ b/src/test/modules/injection_points/wal_level.conf
@@ -0,0 +1 @@
+wal_level=replica
-- 
2.47.3


--j4ov4p7gfxgiujzz--