From: Andres Freund Date: Wed, 3 Jun 2026 02:24:28 -0400 Subject: [PATCH v8a 10/14] ci: windows: Check for errors, cmd/powershell don't have set -e behavior --- .github/workflows/pg-ci.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pg-ci.yml b/.github/workflows/pg-ci.yml index f2543689fe5..ad9bbf745fb 100644 --- a/.github/workflows/pg-ci.yml +++ b/.github/workflows/pg-ci.yml @@ -307,7 +307,7 @@ jobs: ${{env.ADDITIONAL_SETUP}} echo ::group::test_setup - meson test ${{env.MTEST_ARGS}} --suite setup --logbase setup + meson test ${{env.MTEST_ARGS}} --suite setup --logbase setup || exit 1 echo ::endgroup:: meson test ${{env.MTEST_ARGS}} --num-processes ${{env.TEST_JOBS}} ${{env.MTEST_TARGET}} @@ -781,6 +781,7 @@ jobs: run: | # meson + ninja aren't preinstalled on windows-2022. Install via pip python -m pip install --upgrade meson ninja + if (!$?) { throw 'cmdfail' } # Install IPC::Run. @@ -793,7 +794,9 @@ jobs: # the thread at # https://postgr.es/m/CAN55FZ06xanSbJdHe-CurjX_qNuBWZDEvS1kAk36L38YCtZXnw%40mail.gmail.com "o conf recommends_policy 0`no conf commit`nnotest install NJM/IPC-Run-20250809.0.tar.gz" | cpan + if (!$?) { throw 'cmdfail' } perl -mIPC::Run -e 1 + if (!$?) { throw 'cmdfail' } - name: Setup hosts file shell: pwsh @@ -821,7 +824,7 @@ jobs: - name: Build run: | call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 - ninja -C build ${{env.MBUILD_TARGET}} + ninja -C build ${{env.MBUILD_TARGET}} || exit 1 ninja -C build -t missingdeps - name: Test world -- 2.54.0.380.gc69baaf57b --vphnza2cz5zw5t4a Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v8a-0011-ci-windows-ninja-is-already-installed.patch"