Date: Wed, 22 Jul 2026 13:26:34 +0200
From: Christoph Berg <myon@debian.org>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>
Subject: Allow pg_read_all_stats to see database size in \l+
Message-ID: <amCo6qRmnfPVk4-V@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="bukXArRbhiisqidC"
Content-Disposition: inline
Archived-At: 
 <https://www.postgresql.org/message-id/amCo6qRmnfPVk4-V%40msg.df7cb.de>
Precedence: bulk

--bukXArRbhiisqidC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

psql \l+ didn't consider pg_read_all_stats when determining whether
the user was allowed to see the database size.

Split off from the "Available disk space per tablespace" patch since
it's really an independent fix. Thanks Zsolt for pointing that out.

This might be considered for backpatching.

Christoph

--bukXArRbhiisqidC
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename=v1-0001-Allow-pg_read_all_stats-to-see-database-size-in-l.patch

From 9e6f09d62ecd373d80b14a8da39feb9f968c14a0 Mon Sep 17 00:00:00 2001
From: Christoph Berg <myon@debian.org>
Date: Wed, 22 Jul 2026 13:16:16 +0200
Subject: [PATCH v1] Allow pg_read_all_stats to see database size in \l+

The server already allowed members of pg_read_all_stats to see the size
of all databases, but psql's \l+ was too restrictive.
---
 src/bin/psql/describe.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index a2f09c26369..ad9c8affb4f 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -986,7 +986,8 @@ listAllDbs(const char *pattern, bool verbose)
 	printACLColumn(&buf, "d.datacl");
 	if (verbose)
 		appendPQExpBuffer(&buf,
-						  ",\n  CASE WHEN pg_catalog.has_database_privilege(d.datname, 'CONNECT')\n"
+						  ",\n  CASE WHEN pg_catalog.has_database_privilege(d.datname, 'CONNECT') OR\n"
+						  "               pg_catalog.pg_has_role('pg_read_all_stats', 'USAGE')\n"
 						  "       THEN pg_catalog.pg_size_pretty(pg_catalog.pg_database_size(d.datname))\n"
 						  "       ELSE 'No Access'\n"
 						  "  END as \"%s\""
-- 
2.53.0


--bukXArRbhiisqidC--