pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feed[PATCH 2/2] memory free simplify
1+ messages / 1 participants
[nested] [flat]
* [PATCH 2/2] memory free simplify
@ 2026-07-05 12:10 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 1+ messages in thread
From: Álvaro Herrera @ 2026-07-05 12:10 UTC (permalink / raw)
---
src/backend/utils/error/elog.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
inline patch 1: src/backend/utils/error/elog.c (+5/-5 lines) download inline-1.patch
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 80d4eef755a..7d229279dbe 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -2364,6 +2364,7 @@ bool
check_log_min_messages(char **newval, void **extra, GucSource source)
{
char *rawstring;
+ int rawstring_len;
List *elemlist;
StringInfoData buf;
char *result;
@@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
guc_free(rawstring);
return false;
}
+ rawstring_len = strlen(rawstring);
+ guc_free(rawstring);
/* Validate and assign log level and process type. */
foreach_ptr(char, elem, elemlist)
@@ -2478,7 +2481,6 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
continue;
lmm_fail:
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2489,7 +2491,6 @@ lmm_fail:
if (defaultlevel == -1)
{
GUC_check_errdetail("Default log level was not defined.");
- guc_free(rawstring);
list_free(elemlist);
return false;
}
@@ -2507,7 +2508,7 @@ lmm_fail:
*/
list_sort(elemlist, log_min_messages_cmp);
- initStringInfoExt(&buf, strlen(rawstring) + 1);
+ initStringInfoExt(&buf, rawstring_len + 1);
foreach_ptr(char, elem, elemlist)
{
if (foreach_current_index(elem) == 0)
@@ -2515,6 +2516,7 @@ lmm_fail:
else
appendStringInfo(&buf, ", %s", elem);
}
+ list_free(elemlist);
result = guc_strdup(LOG, buf.data);
if (!result)
@@ -2526,8 +2528,6 @@ lmm_fail:
guc_free(*newval);
*newval = result;
- guc_free(rawstring);
- list_free(elemlist);
pfree(buf.data);
/*
--
2.47.3
only message in thread
Thread overview: 1+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-05 12:10 [PATCH 2/2] memory free simplify Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox