Feedback-ID: id4a34324:Fastmail
Date: Sun, 5 Apr 2026 16:03:49 -0400
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
	Japin Li <japinli@hotmail.com>, Zsolt Parragi <zsolt.parragi@percona.com>,
	Euler Taveira <euler@eulerto.com>,
 =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_get__*_ddl consolidation
Message-ID: <ocjzhjrnhagzimxo3jz42e3liybwed5nijnw7uadm5yyjurlux@kt3q6szjapre>
References: <202603201311.yhtqmvektawm@alvherre.pgsql>
 <bf49721a-a56f-4bdc-ac48-5d4dc1d01805@dunslane.net>
 <8ec9b67d-939e-4b22-8d56-a5129f92d32d@app.fastmail.com>
 <CAN4CZFNYM5jNA_gLu9miAXg_7c8Z2zf-ePc+0rzidAV3CBs=cw@mail.gmail.com>
 <555cdee4-c024-4872-9d96-82ef4216239c@dunslane.net>
 <SY7PR01MB10921A6E1E08A48F3426FE529B651A@SY7PR01MB10921.ausprd01.prod.outlook.com>
 <CAKFQuwYcppypeGBwa7ZbDAfoUXSv+kLhJuAXsdwBmKrvy8wDFw@mail.gmail.com>
 <a533fb1b-0f2c-4fc9-ab3b-6fb5ddac1800@dunslane.net>
 <a1c4dd3e-6694-4b7b-8432-f3b584735ff3@dunslane.net>
 <ptyiexyhmtxf4lm524s7o7w64r26ra237uusv4tjav4yhpmeoo@vfwwllz7tivb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ptyiexyhmtxf4lm524s7o7w64r26ra237uusv4tjav4yhpmeoo@vfwwllz7tivb>
Archived-At: 
 <https://www.postgresql.org/message-id/ocjzhjrnhagzimxo3jz42e3liybwed5nijnw7uadm5yyjurlux%40kt3q6szjapre>
Precedence: bulk

Hi,

On 2026-04-05 11:40:33 -0400, Andres Freund wrote:
> On 2026-04-05 11:06:09 -0400, Andrew Dunstan wrote:
> > Pushed. I have moved the remaining get_*_ddl items to PG20-1
> 
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=longfin&dt=2026-04-05%2015%3A04%3A04
> 
> diff -U3 /Users/buildfarm/bf-data/HEAD/pgsql.build/src/test/regress/expected/database_ddl.out /Users/buildfarm/bf-data/HEAD/pgsql.build/src/test/regress/results/database_ddl.out
> --- /Users/buildfarm/bf-data/HEAD/pgsql.build/src/test/regress/expected/database_ddl.out	2026-04-05 11:04:08
> +++ /Users/buildfarm/bf-data/HEAD/pgsql.build/src/test/regress/results/database_ddl.out	2026-04-05 11:05:57
> @@ -22,6 +22,7 @@
>  CREATE DATABASE regress_database_ddl
>      ENCODING utf8 LC_COLLATE "C" LC_CTYPE "C" TEMPLATE template0
>      OWNER regress_datdba;
> +WARNING:  databases created by regression test cases should have names including "regression"
>  ALTER DATABASE regress_database_ddl CONNECTION_LIMIT 123;
>  ALTER DATABASE regress_database_ddl SET random_page_cost = 2.0;
>  ALTER ROLE regress_datdba IN DATABASE regress_database_ddl SET random_page_cost = 1.1;

Pushed a fixup for this and the pgindent failure, as it doesn't seem like a
great time to have CI/BF fail.

It is pretty odd that the naming restrictions for databases (regression*) is
different than for all the other object types...


> But do we really have to create a new database and a new tablespace for these?
> Database and tablespace creations are quite heavyweight operations.
> 
> We already have an existing tablespace and an existing database as part of the
> regression tests. Couldn't you make do with those?

Didn't do anything about that.

Greetings,

Andres Freund