Feedback-ID: id4a34324:Fastmail
Date: Thu, 2 Apr 2026 12:27:12 -0400
From: Andres Freund <andres@anarazel.de>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: some more include removal from headers
Message-ID: <olxypm44m2bqzicr7biie37swt7c5uevpq3sbf7pzcykd2mirw@nw5pydkpjgeg>
References: <202603131240.ihwqdxnj7w2o@alvherre.pgsql>
 <202604021044.rnr2ympmbghc@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="jmpqp62znaydqx65"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202604021044.rnr2ympmbghc@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/olxypm44m2bqzicr7biie37swt7c5uevpq3sbf7pzcykd2mirw%40nw5pydkpjgeg>
Precedence: bulk


--jmpqp62znaydqx65
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hi,

On 2026-04-02 12:52:13 +0200, Álvaro Herrera wrote:
> Here's low-hanging fruit I noticed while eyeballing a patch in the
> commitfest.  This removes pg_publication.h from utils/rel.h, which is
> really nice because pg_publication includes objectaddress.h which in
> turn includes parsenodes.h (an absolute disaster we have there, harder
> to cleanup; not in the mood).  But this here is nice and well contained.

These days including rel.h (indirectly) including objectaddress.h is
quite the disaster, because objectaddress.h recently grew an include of
syscache.h, as I complain about in [1].


I got pretty annoyed this cycle with how much rebuilding a simple change to
bufmgr.h triggers (due to hacking on it a lot).  I started to write a series
to improve that, but didn't get around to posting that yet due to encountering
the issue 771fe0948ca fixed while improving the situation.

During that I encountered the objectaddress.h include, as part of which I then
complained about the issue in [1].


After the attached patches, a change to bufmgr.h triggers rebuilding 213
files, before it was 323.  Not perfect, but better.

Would be nice to get rid of the bufmgr.h includes in access/nbtree.h and such,
but it looks like that'd be a bit more work.

I included your catalog/publication.h in it, as my version had surprisingly
extensive bitrot...

Greetings,

Andres Freund

[1] https://postgr.es/m/vlcexdcimsmvu3aplt2yxpfndkgtuvjsrms2fdl46rbw3k2kug%40drspkoxlaije

--jmpqp62znaydqx65
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v2-0001-wip-Don-t-include-read_stream.h-in-tableam.h.patch"