Feedback-ID: id4a34324:Fastmail
Date: Thu, 9 Apr 2026 10:40:30 -0400
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: s/pg_attribute_always_inline/pg_always_inline/?
Message-ID: <ovpakrvg3mfwyumhkrxjgnwfb75jo534booip7pqrq7cjt4orj@vydvdlbscnx4>
References: <bqqdehahpoa36igpictuqyn2s2mexk3t3ehidh2ffd2slb35e5@rzgksuiszgbg>
 <56def459-2b95-42bc-b4e4-26e57f08b064@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56def459-2b95-42bc-b4e4-26e57f08b064@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ovpakrvg3mfwyumhkrxjgnwfb75jo534booip7pqrq7cjt4orj%40vydvdlbscnx4>
Precedence: bulk

Hi,

On 2026-04-09 02:00:37 +0200, Peter Eisentraut wrote:
> On 08.04.26 23:09, Andres Freund wrote:
> > Hi,
> > 
> > When reviewing the index prefetching patch I got a bit dismayed at how long
> > pg_attribute_always_inline is due to the way it triggers pgindent to format
> > stuff.
> > 
> > I propose that we remove the _attribute_ part of the name.
> > 
> > Given that it is implemented for compilers that don't use the
> > __attribute__((always_inline)) spelling, so the shorter name seems better
> > anyway.
> 
> Yes, and the existing name is also kind of wrong even on GCC because the
> macro does not expand to only an attribute but also includes the "inline".

It didn't start out that way, that only came in a bit later, in
434e6e148441...

Created a CF entry, to reduce the chances of me forgetting about committing
this early in the 20 cycle.

Greetings,

Andres Freund