Feedback-ID: id4a34324:Fastmail
Date: Wed, 18 Mar 2026 13:26:26 -0400
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
 Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
Message-ID: <pvwv3lp7te6nxbmb2mr6oiyxcwf5fq4vjbbtf5s2yu6bpyqn6z@k3gc2bjmlcbu>
References: <aa73q1aT0A3/vke/@ip-10-97-1-34.eu-west-3.compute.internal>
 <44885d54-0376-46b3-b574-59e0e3098580@eisentraut.org>
 <dfb1373e-258f-42b7-ac76-0f5858936dfa@eisentraut.org>
 <CAN55FZ1VDwJ-ZD092ChYf++huP+-S3Cg45tJ8jNH5wx2c4BHAg@mail.gmail.com>
 <784253.1773853383@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <784253.1773853383@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/pvwv3lp7te6nxbmb2mr6oiyxcwf5fq4vjbbtf5s2yu6bpyqn6z%40k3gc2bjmlcbu>
Precedence: bulk

Hi,

On 2026-03-18 13:03:03 -0400, Tom Lane wrote:
> Nazir Bilal Yavuz <byavuz81@gmail.com> writes:
> > I got this warning while running headerscheck after this commit:
> 
> > ~/Desktop/projects/postgres/src/interfaces/ecpg/ecpglib/ecpglib_extern.h:221:40:
> > warning: function declaration isn’t a prototype [-Wstrict-prototypes]
> >   221 | void            ecpg_init_sqlca(struct sqlca_t *sqlca)
> 
> Yeah, I see that too.  I believe the problem is that headerscheck
> doesn't cause POSTGRES_ECPG_INTERNAL to become defined, so that
> what the compiler is seeing is (from sqlca.h):
> 
> 	#ifndef POSTGRES_ECPG_INTERNAL
> 	#define sqlca (*ECPGget_sqlca())
> 	#endif
> 
> and then
> 
> 	void		ecpg_init_sqlca(struct sqlca_t *sqlca);
> 
> Kinda surprising that that's not a syntax error.

Indeed.


I don't even really understand what that POSTGRES_ECPG_INTERNAL business is
about. Is that really just so we can use a local "sqlca" variable in some of
our own ecpglib code while code using ecpg can't do that?  Please tell me it
ain't so.


> We could plausibly fix this either by
> 
> (1) renaming ecpg_init_sqlca's parameter to something else;
> 
> (2) ensuring that POSTGRES_ECPG_INTERNAL is defined.  I'd be inclined
> to make ecpglib_extern.h do that rather than expecting headerscheck
> to know about it.

> Neither of these options are beautiful, but perhaps #1 is slightly
> less ugly.  Any preferences?

1) seems to be the preferrable approach. It's what code using ecpg already has
to do, right?

Greetings,

Andres Freund