DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=s7TmYsBW3RaCg400J/18c4G/4wdtHXN3iPAn4DzWPQVPgKfCJ2B+WqOGuortDUuO0K
	1tdm49DqUx82fgMaHOn4IC0Ws/YfvKbEgDffS17KuoIffbB3sd3kDL+nkPlIR6HdO/zD
	SUjamaOXtAV5GoE1wZxmjtHFIPm0OXF4EZMXc=
MIME-Version: 1.0
In-Reply-To: <1272310247.4161.5081.camel@ebony>
References: <u2o603c8f071004231952i36642ae6u9d6a7eae6eb6ff32@mail.gmail.com>
	<1272148142.4161.1598.camel@ebony>
	<g2x603c8f071004241601qbca333edmd384f9a0df596417@mail.gmail.com>
	<1272181795.4161.1604.camel@ebony>
	<i2z603c8f071004250350p35754194pd7821ce29c4461b3@mail.gmail.com>
	<1272200241.4161.1670.camel@ebony>
	<n2p603c8f071004250835x138a5924t47008cc91da09ddf@mail.gmail.com>
	<1272310247.4161.5081.camel@ebony>
Date: Mon, 26 Apr 2010 16:02:53 -0400
Message-ID: <q2v603c8f071004261302waf6a2eaeyf7956586a0d4e443@mail.gmail.com>
Subject: Re: global temporary tables
From: Robert Haas <robertmhaas@gmail.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Apr 26, 2010 at 3:30 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On Sun, 2010-04-25 at 11:35 -0400, Robert Haas wrote:
>
>> And I don't
>> think you can even get that far, because I don't think too many people
>> here are going to say that we shouldn't add global temporary tables
>> unless we can also make them work with Hot Standby.
>
> The policy round here for some time has been that when we implement
> things we make them work fully and seamlessly. I don't see why Hot
> Standby would be singled out any more than any other feature, say
> Windows support or tablespaces should be occasionally ignored.
>
> People need to get used to the new feature set, just as we had to with
> HOT, subtransactions, prepared transactions, Gist etc.. That may require
> a thwack from various people, but the responsibility lies with the new
> feature implementor, not the person supporting existing code.
>
> I fully understand your wish to implement a partial feature with caveats
> because I have argued that many times myself. But I've come to realise
> that the best way is to build things so they work cleanly across the
> board. Other developers can plan projects in the knowledge that they can
> build directly on firm foundations, not fill in the cracks. In the end
> this comes down to a choice as developers, do we help each other by
> doing a full job, or do we leave unexploded bombs for each other through
> short-termism? Now I understand this better myself, I act differently
> and accept objections if people think a fuller, more complete design is
> what is needed. Recent demonstrations of that available, both objecting
> and accepting.
>
> Don't see this as an extra task, just see it as one of the many aspects
> that will need to be considered when developing it. If you do that it
> need not be additional work.

I think you're looking at this the wrong way.  If temporary tables
have to work with Hot Standby in order for it to be committable, then
we should never have committed Hot Standby in the first place because
our current flavor of temporary tables doesn't.  Was that an oversight
on your part, or a recognition that you can't solve every problem in
one commit?

...Robert