public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: shihao zhong <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
Date: Fri, 20 Mar 2026 12:27:49 -0400
Message-ID: <rzxpxod4c4la62yvutyrvgoyilrl2fx55djaf2suidy7np5m6c@3l2ln476eadh> (raw)
In-Reply-To: <[email protected]>
References: <aFRzYhOTZcRgKPLu@nathan>
	<[email protected]>
	<aFWznvZtYZ3VJxgi@nathan>
	<[email protected]>
	<aFl1AB9ofnQrrckV@nathan>
	<[email protected]>
	<aFrSlSz9fi47j5Sr@nathan>
	<[email protected]>
	<aFwT31Rw-Oj-bgO9@nathan>
	<[email protected]>

Hi,

On 2025-06-30 15:49:49 +0900, Michael Paquier wrote:
> On Wed, Jun 25, 2025 at 10:21:03AM -0500, Nathan Bossart wrote:
> > On Wed, Jun 25, 2025 at 10:31:35AM +0900, Michael Paquier wrote:
> >> Attached is the remaining patch for HEAD, planned once v19 opens, and
> >> the tests I have used on the back-branches as a txt to not confuse the
> >> CI, for reference.
> >
> > Looks reasonable to me.
>
> Thanks.  Applied on HEAD, then.

I was just looking at the includes for tableam.h - a quite widely included
header - and got rather sad seeing vacuum.h in there, as it has a quite large
dependency tree and tableam.h is obviously widely included.

I was surprised that I would have added such a wide include when working on
tableam. Turns out I hadn't - it was 2252fcd4276c.


I think this change was quite ill considered. Look at the dependency tree of
vacuum.h:

https://doxygen.postgresql.org/vacuum_8h.html


That's a *lot* of headers to pull into something as widely included as
tableam.h


Why wasn't it enough to add const markers and keep passing by pointer?


Greetings,

Andres

view thread (32+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
  In-Reply-To: <rzxpxod4c4la62yvutyrvgoyilrl2fx55djaf2suidy7np5m6c@3l2ln476eadh>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox