Feedback-ID: id4a34324:Fastmail
Date: Tue, 13 May 2025 09:37:30 -0400
From: Andres Freund <andres@anarazel.de>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: using index to speedup add not null constraints to a table
Message-ID: <tdmg6thywajp6y4tgsqdygjpmh2ahdonbujry25s753hzrlbym@mljo45t6wemv>
References: 
 <CACJufxFiW=4k1is=F1J=r-Cx1RuByXQPUrWB331U47rSnGz+hw@mail.gmail.com>
 <CACJufxFcYL+XU-f+HP4Zi1h5tDhJ+rYSTvPui2W2bMR7p-eJ-Q@mail.gmail.com>
 <CACJufxE_Q3qbjsf9fjg_j8oQwYRyADerJPQXuiVOP7HPPWHz_w@mail.gmail.com>
 <CACJufxEqdgwUTo3xmUR3Bs49dHvD9VZW+T1D8sVdBV4-UdDcrg@mail.gmail.com>
 <CACJufxHdR0Rd4-v78XhH+xNungof=zQrcTZK0GSN16zoNHWdHg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACJufxHdR0Rd4-v78XhH+xNungof=zQrcTZK0GSN16zoNHWdHg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/tdmg6thywajp6y4tgsqdygjpmh2ahdonbujry25s753hzrlbym%40mljo45t6wemv>
Precedence: bulk

Hi,

On 2025-04-28 12:36:14 +0800, jian he wrote:
> On Fri, Apr 18, 2025 at 4:07 PM jian he <jian.universality@gmail.com> wrote:
> >
> > I don't have any good ideas to do the regress tests.
> > I use
> >                 ereport(NOTICE,
> >                         errmsg("all not-null constraints on relation
> > \"%s\" are validated by index scan",
> >                                 RelationGetRelationName(oldrel)));
> > to do the tests.
> >
> for tests, just found out i can imitate
> src/test/modules/test_misc/t/001_constraint_validation.pl,
> 
> So I created a file:
> src/test/modules/test_misc/t/008_indexscan_validate_notnull.pl
> for TAP tests.

The tests have not passed in a few weeks:
https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5444

Greetings,

Andres Freund