public inbox for [email protected]  

help / color / mirror / Atom feed

From: =?gb18030?B?emVuZ21hbg==?= <[email protected]>
To: =?gb18030?B?cGdzcWwtaGFja2Vycw==?= <[email protected]>
Subject: [PATCH] backup: Fix trivial typo and error message issues
Date: Thu, 15 Jan 2026 21:02:42 +0800
Message-ID: <[email protected]> (raw)

Hi all,

I noticed two trivial issues in backup-related code:
1. backup_manifest.c: The timeline mismatch error message uses `starttli` instead of `endtli`.
2. basebackup_copy.c: There is a spelling error (sine → since) in the comment above the `PROGRESS_REPORT_BYTE_INTERVAL` macro.

```
--- a/src/backend/backup/backup_manifest.c
+++ b/src/backend/backup/backup_manifest.c
@@ -253,7 +253,7 @@ AddWALInfoToBackupManifest(backup_manifest_info *manifest, XLogRecPtr startptr,
                if (first_wal_range && endtli != entry->tli)
                        ereport(ERROR,
                                        errmsg("expected end timeline %u but found timeline %u",
-                                                  starttli, entry->tli));
+                                                  endtli, entry->tli));
```

```
- * So we only check it after the number of bytes sine the last check reaches
+ * So we only check it after the number of bytes since the last check reaches
```

--
Regards,
Man Zeng
www.openhalo.org

Attachments:

  [application/octet-stream] 0001-Update-error-message-in-AddWALInfoToBackupManifest-f.patch (1.7K, ../[email protected]/2-0001-Update-error-message-in-AddWALInfoToBackupManifest-f.patch)
  download | inline diff:
From 70c9f769bf914e983a46ecbe61acbb34dcbea49e Mon Sep 17 00:00:00 2001
From: Man Zeng <[email protected]>
Date: Thu, 15 Jan 2026 20:44:36 +0800
Subject: [PATCH] Update error message in AddWALInfoToBackupManifest for
 clarity Fix typo in comment for progress reporting in basebackup_copy.c

---
 src/backend/backup/backup_manifest.c | 2 +-
 src/backend/backup/basebackup_copy.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/backup/backup_manifest.c b/src/backend/backup/backup_manifest.c
index 85bc96914dc..c697caef895 100644
--- a/src/backend/backup/backup_manifest.c
+++ b/src/backend/backup/backup_manifest.c
@@ -253,7 +253,7 @@ AddWALInfoToBackupManifest(backup_manifest_info *manifest, XLogRecPtr startptr,
 		if (first_wal_range && endtli != entry->tli)
 			ereport(ERROR,
 					errmsg("expected end timeline %u but found timeline %u",
-						   starttli, entry->tli));
+						   endtli, entry->tli));
 
 		/*
 		 * If this timeline entry matches with the timeline on which the
diff --git a/src/backend/backup/basebackup_copy.c b/src/backend/backup/basebackup_copy.c
index fecfad9ab7b..07f58b39d8c 100644
--- a/src/backend/backup/basebackup_copy.c
+++ b/src/backend/backup/basebackup_copy.c
@@ -66,7 +66,7 @@ typedef struct bbsink_copystream
  * frequently. Ideally, we'd like to send a message when the time since the
  * last message reaches PROGRESS_REPORT_MILLISECOND_THRESHOLD, but checking
  * the system time every time we send a tiny bit of data seems too expensive.
- * So we only check it after the number of bytes sine the last check reaches
+ * So we only check it after the number of bytes since the last check reaches
  * PROGRESS_REPORT_BYTE_INTERVAL.
  */
 #define	PROGRESS_REPORT_BYTE_INTERVAL				65536
-- 
2.45.2

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCH] backup: Fix trivial typo and error message issues
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox