pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedMinor adjustment: Update the range of the commit_siblings parameter.
3+ messages / 3 participants
[nested] [flat]
* Minor adjustment: Update the range of the commit_siblings parameter.
@ 2025-11-10 11:04 =?ISO-8859-1?B?emVuZ21hbg==?= <zengman@halodbtech.com>
0 siblings, 1 reply; 3+ messages in thread
From: zengman @ 2025-11-10 11:04 UTC (permalink / raw)
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Hi, hackers
When reviewing the postgresql.conf.sample file, I noticed that the range of the commit_siblings parameter appears to have been incorrect for quite some time. Attached is a simple patch to update it.
--
Regrads,
Man Zeng
Attachments:
[application/octet-stream] 001_update_postgresql_conf_sample.patch (454B, ../../tencent_53B70BA72303AE9C6889E78E@qq.com/2-001_update_postgresql_conf_sample.patch)
download | inline diff:
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index f62b61967ef..08bcef50c19 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -256,7 +256,7 @@
#wal_skip_threshold = 2MB
#commit_delay = 0 # range 0-100000, in microseconds
-#commit_siblings = 5 # range 1-1000
+#commit_siblings = 5 # range 0-1000
# - Checkpoints -
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Minor adjustment: Update the range of the commit_siblings parameter.
@ 2025-11-10 13:53 Chao Li <li.evan.chao@gmail.com>
parent: =?ISO-8859-1?B?emVuZ21hbg==?= <zengman@halodbtech.com>
0 siblings, 1 reply; 3+ messages in thread
From: Chao Li @ 2025-11-10 13:53 UTC (permalink / raw)
To: zengman <zengman@halodbtech.com>; +Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
> On Nov 10, 2025, at 19:04, zengman <zengman@halodbtech.com> wrote:
>
> Hi, hackers
>
> When reviewing the postgresql.conf.sample file, I noticed that the range of the commit_siblings parameter appears to have been incorrect for quite some time. Attached is a simple patch to update it.
>
> --
> Regrads,
> Man Zeng<001_update_postgresql_conf_sample.patch>
Yes, the definition in guc_parameters.dat shows min as 0 and max as 1000, so the fix is correct:
```
{ name => 'commit_siblings', type => 'int', context => 'PGC_USERSET', group => 'WAL_SETTINGS',
short_desc => 'Sets the minimum number of concurrent open transactions required before performing "commit_delay".',
variable => 'CommitSiblings',
boot_val => '5',
min => '0',
max => '1000',
},
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Minor adjustment: Update the range of the commit_siblings parameter.
@ 2025-11-10 14:21 Daniel Gustafsson <daniel@yesql.se>
parent: Chao Li <li.evan.chao@gmail.com>
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Gustafsson @ 2025-11-10 14:21 UTC (permalink / raw)
To: Chao Li <li.evan.chao@gmail.com>; +Cc: zengman <zengman@halodbtech.com>; pgsql-hackers <pgsql-hackers@lists.postgresql.org>
> On 10 Nov 2025, at 14:53, Chao Li <li.evan.chao@gmail.com> wrote:
>> On Nov 10, 2025, at 19:04, zengman <zengman@halodbtech.com> wrote:
>> When reviewing the postgresql.conf.sample file, I noticed that the range of the commit_siblings parameter appears to have been incorrect for quite some time. Attached is a simple patch to update it.
>
> Yes, the definition in guc_parameters.dat shows min as 0 and max as 1000, so the fix is correct:
Agreed, and MinimumActiveBackends() has a fast-path to handle a value of zero
as well (in all supported back-branches).
We are currently in release freeze for the backbranches, but will commit this
once the tree opens up again backpatched to all supported branches.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-11-10 14:21 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-11-10 11:04 Minor adjustment: Update the range of the commit_siblings parameter. =?ISO-8859-1?B?emVuZ21hbg==?= <zengman@halodbtech.com>
2025-11-10 13:53 ` Chao Li <li.evan.chao@gmail.com>
2025-11-10 14:21 ` Daniel Gustafsson <daniel@yesql.se>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox