public inbox for [email protected]  

help / color / mirror / Atom feed

From: wangpeng <[email protected]>
To: [email protected]
Subject: Fix wrong log in pgstat_report_checksum_failures_in_db()
Date: Wed, 11 Feb 2026 17:22:27 +0800
Message-ID: <[email protected]> (raw)

Hi hackers,

The function pgstat_report_checksum_failures_in_db(), file 
pgstat_database.c,
currently emits a log message referring to "conflicts", which seems wrong.
As the function name suggesting, the log message should refer to 
"checksum failures".


Best regards,
Wang Peng


From baaa034639ecd4bb08edd7563a9ee4016fad765b Mon Sep 17 00:00:00 2001
From: Wang Peng <[email protected]>
Date: Tue, 10 Feb 2026 22:16:24 -0500
Subject: [PATCH v1] Fix wrong log in pgstat_report_checksum_failures_in_db()

Author: Wang Peng <[email protected]>
---
 src/backend/utils/activity/pgstat_database.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/activity/pgstat_database.c b/src/backend/utils/activity/pgstat_database.c
index 6309909..0ccb170 100644
--- a/src/backend/utils/activity/pgstat_database.c
+++ b/src/backend/utils/activity/pgstat_database.c
@@ -200,7 +200,7 @@ pgstat_report_checksum_failures_in_db(Oid dboid, int failurecount)
 	Assert(entry_ref);
 	if (!entry_ref)
 	{
-		elog(WARNING, "could not report %d conflicts for DB %u",
+		elog(WARNING, "could not report %d checksum failures for DB %u",
 			 failurecount, dboid);
 		return;
 	}
-- 
1.8.3.1



Attachments:

  [text/plain] v1-0001-Fix-wrong-log-in-pgstat_report_checksum_failures.patch (914B, ../[email protected]/2-v1-0001-Fix-wrong-log-in-pgstat_report_checksum_failures.patch)
  download | inline diff:
From baaa034639ecd4bb08edd7563a9ee4016fad765b Mon Sep 17 00:00:00 2001
From: Wang Peng <[email protected]>
Date: Tue, 10 Feb 2026 22:16:24 -0500
Subject: [PATCH v1] Fix wrong log in pgstat_report_checksum_failures_in_db()

Author: Wang Peng <[email protected]>
---
 src/backend/utils/activity/pgstat_database.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/activity/pgstat_database.c b/src/backend/utils/activity/pgstat_database.c
index 6309909..0ccb170 100644
--- a/src/backend/utils/activity/pgstat_database.c
+++ b/src/backend/utils/activity/pgstat_database.c
@@ -200,7 +200,7 @@ pgstat_report_checksum_failures_in_db(Oid dboid, int failurecount)
 	Assert(entry_ref);
 	if (!entry_ref)
 	{
-		elog(WARNING, "could not report %d conflicts for DB %u",
+		elog(WARNING, "could not report %d checksum failures for DB %u",
 			 failurecount, dboid);
 		return;
 	}
-- 
1.8.3.1

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Fix wrong log in pgstat_report_checksum_failures_in_db()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox