public inbox for [email protected]  

help / color / mirror / Atom feed

From: =?utf-8?B?Y2NhNTUwNw==?= <[email protected]>
To: =?utf-8?B?Wml6aHVhbiBMaXU=?= <[email protected]>
To: =?utf-8?B?RGF2aWQgR2VpZXI=?= <[email protected]>
To: =?utf-8?B?cGdzcWwtaGFja2Vycw==?= <[email protected]>
Subject: Re: Avoid calling SetMatViewPopulatedState if possible
Date: Thu, 18 Jun 2026 17:28:17 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hi Zizhuan,

Thanks for your careful review!

> 5. A small suggestion
> After further consideration, I suggest using the condition:
>     if (RelationIsPopulated(matviewRel) != !skipData)
> This is much more readable and intuitive compared to the original:
>     if (RelationIsPopulated(matviewRel) == skipData)
> Especially when paired with the original call:
>     SetMatViewPopulatedState(matviewRel, !skipData);

Both are ok for me.

--
Regards,
ChangAo Chen

view thread (8+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Avoid calling SetMatViewPopulatedState if possible
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox