Date: Wed, 13 May 2026 20:08:02 +0200
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Zsolt Parragi <zsolt.parragi@percona.com>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>,
	Daniel Gustafsson <daniel@yesql.se>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add ssl_(supported|shared)_groups to sslinfo
Message-ID: <uy2ho4qzwzsm5zqi2s3po4iesgvzfybdq6vldqpsldeot6xkyn@repwtjoc63ok>
References: 
 <CAOYmi+nkT7rkbNd6que0wtz=epOikgBKSDR88DQ=cyNJwiUw8Q@mail.gmail.com>
 <srua2tidoiztaytmxlwjfpjhntxelmxpfta4lhulvlker444yg@sf232zqm3qvs>
 <CAOYmi+k7v6hP5nM7BQdKu37TJFi-X=d7_SDswZBV5q0awxPVYg@mail.gmail.com>
 <qyw7l5ztbqouluctxgbxc2aty43suulka2q4ybpaew4tey7rlw@l66rjb7vxxhk>
 <CAOYmi+=r50Kk1c7A7O8yXwJzALyyqDmQE7FiCZvZmt_3WRBGwQ@mail.gmail.com>
 <izopeja2suconbqpbswmtto5czajnc4p7rsml5gwwrs56lexaj@kmqdrqiepays>
 <rf5vuhdo4ub2qz3eivighhjs4tfkfclbosptnhzdpzibx5aq6z@faylol54ro5s>
 <slgx6krxgs2sb6m7j6z6qht25geaa2jbwwiizwimudrxqxxg3n@2qq5eslriowi>
 <tuobeew3dd3eubtelwroocwgac3jhlselwshs2km5ovei77tao@wghkpdvvthbi>
 <CAN4CZFMvnEPa2xpyvd7SYQ2U0os6gDucu_T_fsvM0q+xiqCD=w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="vt4heavyb5tqbgln"
Content-Disposition: inline
In-Reply-To: 
 <CAN4CZFMvnEPa2xpyvd7SYQ2U0os6gDucu_T_fsvM0q+xiqCD=w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/uy2ho4qzwzsm5zqi2s3po4iesgvzfybdq6vldqpsldeot6xkyn%40repwtjoc63ok>
Precedence: bulk


--vt4heavyb5tqbgln
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> On Tue, May 12, 2026 at 10:48:20PM +0100, Zsolt Parragi wrote:
> +#define HAVE_SSL_GROUPS \
> + defined(HAVE_DECL_SSL_GET1_GROUPS) && \
> + defined(HAVE_DECL_SSL_GET_NEGOTIATED_GROUP) && \
> + defined(HAVE_SSL_GROUP_TO_NAME)
> 
> I don't think this check works properly
> 1. autoconf/meson always defines HAVE_DECL to 0/1, so defined() always
> returns true
> 2. in practice it should work, but using defined() in a macro
> expansion is undefined behavior

That's indeed a faux pas. I was testing this on openssl 1.1.1w, which
was lacking both SSL_get_negotiated_group and SSL_group_to_name, and
this was hiding the problem. The new version should address this
problem, and includes documentation fix from Cary.

--vt4heavyb5tqbgln
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="v6-0001-contrib-sslinfo-Add-ssl_group_info.patch"