Feedback-ID: id4a34324:Fastmail
Date: Wed, 11 Mar 2026 14:10:54 -0400
From: Andres Freund <andres@anarazel.de>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Defend against -ffast-math in meson builds
Message-ID: <vjpqvlolycvkc3k6elcb3wchf7mjg6bn5ek7b352cvsnq77qln@nnjpkw3cykly>
References: <abFXfKC8zR0Oclon@ip-10-97-1-34.eu-west-3.compute.internal>
 <vwnxbsap65km373ghtqhhvhwnc35suwraegb7z5op4okxyuwzu@kpaumampogpe>
 <a9d82d5f-58c5-4252-960f-f91cb5bc5a99@eisentraut.org>
 <3316.1773242385@sss.pgh.pa.us>
 <abGPko4lPv/Bj6Bt@ip-10-97-1-34.eu-west-3.compute.internal>
 <3583.1773247555@sss.pgh.pa.us>
 <abGsWdCgAhKRJI2e@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <abGsWdCgAhKRJI2e@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: 
 <https://www.postgresql.org/message-id/vjpqvlolycvkc3k6elcb3wchf7mjg6bn5ek7b352cvsnq77qln%40nnjpkw3cykly>
Precedence: bulk

Hi,

On 2026-03-11 17:54:33 +0000, Bertrand Drouvot wrote:
> > But maybe we should move the
> > code-level tests out of the datetime files and into utils/float.h
> > or some such place.
> 
> But still, I'm not sure the code-level guard is enough for meson. I think we
> need to put a guard in meson.build for the "oddity" described in [1]:

I think you rather need to get to the bottom of that issue.


> it compiles fine with CFLAGS="-ffast-math" CC="gcc" meson setup meson_build but
> produces issues during the regression tests.

This fails to build here as expected.

Are you sure that you actually specified it during meson setup and then didn't
reconfigure while the CFLAGs aren't specified?


> I just had a closer look and it looks like that the reason is that it's being
> added at link time:
> 
> $ cat meson_build/build.ninja | grep LINK_ARGS | grep -c "ffast-math"
> 254

It's added to both, compile and link args, afaict?

andres@awork3:/tmp/pg-fast-math$ grep ffast-math build.ninja |awk '{print $1}'|sort|uniq -c
   1679 ARGS
    255 LINK_ARGS

Greetings,

Andres Freund