Feedback-ID: id4a34324:Fastmail
Date: Sun, 25 Jan 2026 11:50:28 -0500
From: Andres Freund <andres@anarazel.de>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Peter Eisentraut <peter@eisentraut.org>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: Make copyObject work in C++
Message-ID: <ztktlrqatfj4roqhdjurccb3b4mf5hrycybfrzwupt4xmbwjt4@alrtyxhz5sns>
References: <CAGECzQR21OnnKiZO_1rLWO0-16kg1JBxnVq-wymYW0-_1cUNtg@mail.gmail.com>
 <4d8b9e53-3f37-43f0-a4aa-5bda9c7961b3@eisentraut.org>
 <DFEUMBSUG8KA.XGY0CN9PFPR2@jeltef.nl>
 <DFKV26A4CHG2.CB7NJ1X62BKH@jeltef.nl>
 <fd1a4790-4fbc-43b4-a385-e3b98b9ed04d@eisentraut.org>
 <DFQYWIJD4L1J.3HQFOWSWKLFOR@jeltef.nl>
 <4e82f77b-acad-4356-94f6-8255135fb36b@eisentraut.org>
 <DFXOG2P1QMS8.3L7MCAL0E6MVJ@jeltef.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DFXOG2P1QMS8.3L7MCAL0E6MVJ@jeltef.nl>
Archived-At: <https://www.postgresql.org/message-id/ztktlrqatfj4roqhdjurccb3b4mf5hrycybfrzwupt4xmbwjt4%40alrtyxhz5sns>
Precedence: bulk

Hi,

On 2026-01-25 13:42:51 +0100, Jelte Fennema-Nio wrote:
> This reverts to using positional initializers in PG_MODULE_MAGIC_DATA so
> that its possible to write C++ extensions in standard C++11. Sadly that
> means that using designated initializers in C++20 is still not allowed
> in PG_MODULE_MAGIC_EXT because mixing designated an positional
> initializers is a C only feature. This restriction for C++ extensions is
> now documented and tested.

I'm pretty sceptical this is the right direction. We were going for designated
initializers for a reason, namely that we expect more arguments to be added
over time and perhaps eventually also to remove some. And this will just lead
to that being harder because we have to worry about C++ extensions.


But I'm also confused as to why it's needed - there's nomixing of designated
and non-designated initializers that I can see? If you use
PG_MODULE_MAGIC_EXT(.name = "whatnot"), it evaluates down to

extern __attribute__((visibility("default"))) const Pg_magic_struct *Pg_magic_func(void); const Pg_magic_struct * Pg_magic_func(void) { static const Pg_magic_struct Pg_magic_data = { .len = sizeof(Pg_magic_struct), .abi_fields = { 190000 / 100, 100, 32, 64, true, "PostgreSQL", }, .name="whatnot"}; return &Pg_magic_data; } extern int no_such_variable;

And indeed, contra to what you reported upthread, I can't get clang to report
a warning about that.  I do obviously see warnings about the wrong order if I
pass the arguments in the wrong order, but that's a lot less problematic. And
omitted args don't trigger warnings, as you noted.


Greetings,

Andres Freund