Feedback-ID: id4a34324:Fastmail
Date: Fri, 13 Mar 2026 13:54:48 -0400
From: Andres Freund <andres@anarazel.de>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
 Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: tid_blockno() and tid_offset() accessor functions
Message-ID: <zzsoruna42ab5rsdsdoahw6v33pa62afclvg4cqd55azsdizgc@bt27dd5b7hn4>
References: 
 <CAJTYsWUzok2+mvSYkbVUwq_SWWg-GdHqCuYumN82AU97SjwjCA@mail.gmail.com>
 <CAD21AoBdgM+4X=Wg0T==C9ahenm2nUb=q5AxxeEb_JVoKOzbgw@mail.gmail.com>
 <fe2ay3acydk6sd3iwkvol7t3kgswzfsuaz2vdgqornx4hg7ji2@dpwilwuzq7a2>
 <CAD21AoC48MQ4W5vU1ZPaXXtFPtiacEREN_XXrn3SRRku5cighg@mail.gmail.com>
 <8a2e78c3-2f63-455f-80a9-cbd9eebaa245@eisentraut.org>
 <CAEze2Wgg=HyBqOLOYh_1Nx8GcLWRKvrwPVOE6iqi=9D8mMCACg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAEze2Wgg=HyBqOLOYh_1Nx8GcLWRKvrwPVOE6iqi=9D8mMCACg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/zzsoruna42ab5rsdsdoahw6v33pa62afclvg4cqd55azsdizgc%40bt27dd5b7hn4>
Precedence: bulk

Hi,

On 2026-03-13 18:08:04 +0100, Matthias van de Meent wrote:
> As for naming; I'd personally prefer to have 'heap' included in the
> names here (e.g. heaptid_blkno(tid) or heap_blkno[_of](tid)), because
> not all AMs may map tid.blkno exactly to a block number in the main
> fork. While PostgreSQL (in core) currently only knows about the heap
> AM, we should probably keep clear of pretending that all tableAMs
> produce TIDs that behave exactly like heap's do.

Meh. As long as tids themselves are split like they are, without any
variability of the amount of space dedicated for either component, I don't see
any advantage in that.

Greetings,

Andres Freund