From: "Andrew C.R. Martin" <a.c.r.martin@reading.ac.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Re: [HACKERS] Re: Bugs: Programming Language Functions
Date: Thu, 13 Apr 2000 10:31:58 +0100
Content-Type: text/plain
Cc: interfaces@postgresql.org, docs@postgresql.org, hackers@postgresql.org
References: <00041308564200.29884@sapc13.rdg.ac.uk>
MIME-Version: 1.0
Message-Id: <00041310400304.29884@sapc13.rdg.ac.uk>
Content-Transfer-Encoding: 8bit

On Thu, 13 Apr 2000, Andrew C.R. Martin wrote:
> On Tue, 11 Apr 2000, Tom Lane wrote:
> > "Andrew C.R. Martin" <a.c.r.martin@reading.ac.uk> writes:
> > >> Hm.  I'm not too clear on why that would need to worry about either
> > >> TupleTableSlot or GetAttributeByName ... shouldn't it be a simple
> > >> function consuming a text Datum and producing another?
> > 
> > > Errrmmm, just following the instructions in the docs:
> > 
> > > Programmer's Manual, Chapter 4. Extensing SQL: Functins (page
> > > x414.htm), under the C examples.
> > 

Eeek! Forget my idea of #define'ing TupleTableSlot as TUPLE for backwards
compatibility. I've just realised that GetAttributeByName() now takes
a TupleTableSlot *pointer* whereas it used to take a TUPLE structure (not a
pointer).

Personally whenever I make a code change like this I try to create a new
function with the altered parameters and then make a wrapper with the old name
and calling style for backwards compatibility :-)

It seems that the .../src/tutorial/func.* examples have been updated correctly
The create_function man page however has not been updated (it even refers to
libpq-fe.h still as well as to TUPLE) and the main printable manual needs to be
updated.

Best wishes,

Andrew

--
Dr. Andrew C.R. Martin          EMail:  a.c.r.martin@reading.ac.uk  (work)
Lecturer in Bioinformatics              andrew@stagleys.demon.co.uk (home)
University of Reading
Tel.: +44 (0)118 987 5123x7022  Fax:    +44 (0)118 931 0180