Received: from inje.iskon.hr (inje.iskon.hr [213.191.128.16])
	by postgresql.org (8.11.3/8.11.1) with ESMTP id f6NHo7f87084
	for <pgsql-interfaces@postgresql.org>;
	Mon, 23 Jul 2001 13:50:07 -0400 (EDT)
	(envelope-from Darko.Prenosil@finteh.hr)
Received: from darko (zg03-019.dialin.iskon.hr [213.191.135.20])
	by mail.iskon.hr (8.11.4/8.11.3/Iskon 8.11.3-1) with SMTP id
	f6NHmE427379; Mon, 23 Jul 2001 19:48:15 +0200 (MEST)
Message-ID: <002801c1139f$cdb19660$1700a8c0@darko>
From: "Darko Prenosil" <Darko.Prenosil@finteh.hr>
To: "pgsql interfaces" <pgsql-interfaces@postgresql.org>,
	"Tom Lane" <tgl@sss.pgh.pa.us>
References: <200107211602.f6LG2kU15578@candle.pha.pa.us>
	<000701c1121f$3908f8e0$1700a8c0@darko>
	<14935.995898612@sss.pgh.pa.us>
Subject: Re: [BUGS] WIN32 MULTIBYTE
Date: Mon, 23 Jul 2001 19:47:14 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-2"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4522.1200
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200
X-Archive-Number: 200107/94
X-Sequence-Number: 1848

> "Darko Prenosil" <darko_prenosil@yahoo.com> writes:
> > In src/include/miscadmin.h there is declared external function
GetUserName.
>
> > I think that this header should not be imported in libpq at all,
>
> It isn't --- at least I can't see any inclusion path for it in current
> sources.
>
> regards, tom lane

Maybe You can not see it in build for Linux (I did not check),
but in WIN32.MAK file there is section
that looks like this:

!IFDEF MULTIBYTE
"$(INTDIR)\common.obj" : ..\..\backend\utils\mb\common.c
    $(CPP) @<<
    $(CPP_PROJ) /I "." ..\..\backend\utils\mb\common.c
<<

And there are first few lines from common.c :

/*
 * This file contains some public functions
 * usable for both the backend and the frontend.
 * Tatsuo Ishii
 * $Id: common.c,v 1.13 2001/04/16 02:42:01 tgl Exp $
 */
#include "postgres.h"

#ifdef WIN32
#include "win32.h"
#else
#include <unistd.h>
#endif

#include "miscadmin.h"
#include "mb/pg_wchar.h"
#include "utils/builtins.h"
...etc...

When I try to compile without correction I mentioned in previous message I
got this error:

..\..\include\miscadmin.h(206) : error C2373: 'GetUserNameA' : redefinition;
different type modifiers !

I'm shore that this header is imported, but I do not know if it can be
skipped in this way:

/*
 * This file contains some public functions
 * usable for both the backend and the frontend.
 * Tatsuo Ishii
 * $Id: common.c,v 1.13 2001/04/16 02:42:01 tgl Exp $
 */
#include "postgres.h"

#ifdef WIN32
#include "win32.h"
#else
#include <unistd.h>
#include "miscadmin.h"
#endif

#include "mb/pg_wchar.h"
#include "utils/builtins.h"
...etc...

I supose that this should not impact some other builds?
Is this part of code used by ODBC driver for example, and this change can
corrupt this build ?
I'm quite new in this, so I do not know those answers.

Darko.Prenosil@finteh.hr