X-Original-To: pgsql-interfaces@postgresql.org
Received: from sss.pgh.pa.us (unknown [192.204.191.242])
	by postgresql.org (Postfix) with ESMTP id 412DC475CBC
	for <pgsql-interfaces@postgresql.org>;
	Fri, 21 Mar 2003 00:41:40 -0500 (EST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.12.8/8.12.8) with ESMTP id h2L5fYub010178;
	Fri, 21 Mar 2003 00:41:35 -0500 (EST)
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: =?ISO-8859-1?Q?Gerhard_H=E4ring?= <lists@ghaering.de>,
	pgsql-interfaces@postgresql.org
Subject: Re: I want to send comments to the backend! 
In-reply-to: <200303210516.h2L5Gq104398@candle.pha.pa.us> 
References: <200303210516.h2L5Gq104398@candle.pha.pa.us>
Comments: In-reply-to Bruce Momjian <pgman@candle.pha.pa.us>
	message dated "Fri, 21 Mar 2003 00:16:52 -0500"
Date: Fri, 21 Mar 2003 00:41:34 -0500
Message-ID: <10177.1048225294@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Archive-Number: 200303/110
X-Sequence-Number: 3859

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> OK, this patch fixes the comment passing bug.  I remove the strspn() and
> added a boolean to test if any parsetree had been generated --- if not,
> I call NullCommand().

Seems like the hard way.  I had in mind a quick

	if (parsetree_list == NIL)
	{
		NullCommand(dest);
		return;
	}

before entering the main loop.  It'd take a small amount of reordering
of the existing code to make this happen without adding any more code
than that, but it looked doable.

			regards, tom lane