To: Michael Fuhr <mike@fuhr.org>, Oliver Elphick <olly@lfix.co.uk>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [INTERFACES] PL/Python: How do I use result methods? 
In-reply-to: <18394.1102277733@sss.pgh.pa.us> 
References: <1097937269.12716.28.camel@linda>
	<20041016165600.GA71873@winnie.fuhr.org>
	<20041204221858.GA73013@winnie.fuhr.org>
	<18394.1102277733@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sun, 05 Dec 2004 15:15:33 -0500"
Date: Thu, 16 Dec 2004 21:17:43 -0500
Message-ID: <13490.1103249863@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

I wrote:
> Michael Fuhr <mike@fuhr.org> writes:
>> Any comments on this?  The 8.0.0rc1 PL/Python documentation,
>> Section 39.3 "Database Access", still mentions the nrows and
>> status methods, but they don't work.  Here's Oliver's original
>> message and my followup:

>> http://archives.postgresql.org/pgsql-interfaces/2004-10/msg00019.php
>> http://archives.postgresql.org/pgsql-interfaces/2004-10/msg00020.php

> It looks like someone #ifdef'd out those sections after observing that
> the PLy_result_methods table isn't used anyplace.  Perhaps the place
> where it should have been used got lost in some earlier patch?

> Just out of curiosity, what sort of patch would it take to enable these
> functions?  If it's at all nontrivial I'd vote to hold over to 8.1,
> but if it's a line or two of code that got lost at some point, it would
> seem like a reasonable bug fix ...

Comparing the result and plan method types made it pretty obvious how
those methods are supposed to be hooked up, and it was indeed a
one-liner omission in the original source code.  So I've fixed it.

			regards, tom lane