Received: from sss.pgh.pa.us (sss.pgh.pa.us [209.114.132.154]) by mail.postgresql.org (8.11.1/8.11.1) with ESMTP id f18NT5x44801; Thu, 8 Feb 2001 18:29:06 -0500 (EST) (envelope-from tgl@sss.pgh.pa.us) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.11.1/8.11.1) with ESMTP id f18NT2913525; Thu, 8 Feb 2001 18:29:02 -0500 (EST) To: Alex Pilosov cc: pgsql-hackers@postgresql.org, pgsql-interfaces@postgresql.org Subject: Re: Plan for straightening out the include-file mess In-reply-to: References: Comments: In-reply-to Alex Pilosov message dated "Thu, 08 Feb 2001 18:11:30 -0500" Date: Thu, 08 Feb 2001 18:29:02 -0500 Message-ID: <13522.981674942@sss.pgh.pa.us> From: Tom Lane X-Archive-Number: 200102/300 X-Sequence-Number: 4431 Alex Pilosov writes: > when I include files needed for SPI, it drags also a lot of other > garbage in, which conflicts with other things (namely, trying to get a > file to simultaneously include SPI and perl headers is impossible). > I realise it might be a lot of pain to clean up, but, you may consider > having a separate top-level include for SPI, which would not define (by > default) things like DEBUG, USE_LOCALE, union semun, etc. Unless you want to write SPI code that never calls elog(), it's gonna be tough to avoid the conflict on DEBUG. I suppose sooner or later we'll have to rename the elog severity symbols ... but it's not a change that I'm looking forward to making. In any case there's too much time pressure to consider wide-ranging code changes for 7.1. Right now I don't want to do more than rearrange the contents of a small number of include files. regards, tom lane