X-Original-To: pgsql-interfaces-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [64.117.224.130]) by svr1.postgresql.org (Postfix) with ESMTP id 5FD1ED1C4CA for ; Thu, 7 Aug 2003 13:51:39 +0000 (GMT) Received: from svr1.postgresql.org ([64.117.224.193]) by localhost (neptune.hub.org [64.117.224.130]) (amavisd-new, port 10024) with ESMTP id 81672-06 for ; Thu, 7 Aug 2003 10:50:18 -0300 (ADT) Received: from sss.pgh.pa.us (unknown [192.204.191.242]) by svr1.postgresql.org (Postfix) with ESMTP id 6DF83D1C4BF for ; Thu, 7 Aug 2003 10:51:28 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.9/8.12.9) with ESMTP id h77DpLSa014916; Thu, 7 Aug 2003 09:51:24 -0400 (EDT) To: Bruce Momjian Cc: PostgreSQL-interfaces , Peter Eisentraut Subject: Re: ecpg problem in 7.4 beta In-reply-to: <200308070443.h774hW211357@candle.pha.pa.us> References: <200308070443.h774hW211357@candle.pha.pa.us> Comments: In-reply-to Bruce Momjian message dated "Thu, 07 Aug 2003 00:43:31 -0400" Date: Thu, 07 Aug 2003 09:51:21 -0400 Message-ID: <14915.1060264281@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200308/29 X-Sequence-Number: 4383 Bruce Momjian writes: > OK, I think I can fix this. The include of postgres_fe.h was done > recently: > revision 1.54 > date: 2003/08/01 13:53:36; author: petere; state: Exp; lines: +4 -2 > Make ecpg SQLSTATE-aware. Map existing SQLCODE assignments to SQLSTATEs, > rather than parsing the message. Add some documentation about embedded > SQL. > It seems like doing postgres_fe.h rather than postgres_ext.h was just an > oversight, so I will make the change in CVS. I think you will break things if you do. It's unlikely Peter changed that on a whim --- ecpg probably now requires more than it did before. I am not sure that we want to start treating postgres_fe.h as a public header though --- if we do, that means also c.h and perhaps other stuff. This needs some thought. regards, tom lane