Received: from sss.pgh.pa.us ([192.204.191.242]) by postgresql.org (8.11.3/8.11.1) with ESMTP id f624Lma35458 for ; Mon, 2 Jul 2001 00:21:48 -0400 (EDT) (envelope-from tgl@sss.pgh.pa.us) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.11.4/8.11.4) with ESMTP id f624Lj401601; Mon, 2 Jul 2001 00:21:45 -0400 (EDT) To: Christian Ullrich cc: pgsql-interfaces@postgresql.org Subject: Re: libpq++ on Windows In-reply-to: <20010702002319.A1387@christian.chrullrich.de> References: <20010701174549.A976@christian.chrullrich.de> <20010702002319.A1387@christian.chrullrich.de> Comments: In-reply-to Christian Ullrich message dated "Mon, 02 Jul 2001 00:23:19 +0200" Date: Mon, 02 Jul 2001 00:21:45 -0400 Message-ID: <1598.994047705@sss.pgh.pa.us> From: Tom Lane X-Archive-Number: 200107/6 X-Sequence-Number: 1759 Christian Ullrich writes: > * Peter Eisentraut wrote on Sunday, 2001-07-01: >> Why not put the addition to config.h.in into config.h.win32? When doing a >> native Win32 build config.h.in isn't used anyway. > Because the '#define DLLAPI' in config.h.in -- from which the > config.h for Unix and Cygwin/Win32 builds is generated -- is > necessary to make the compiler happy about the modifications > to the class declarations. config.h.in is absolutely NOT the right place for platform-specific defines. I'd put this in the same category as DLLIMPORT, which is in c.h (and just as ugly an example of Microsoft cultural imperialism, but I suppose there's no point in arguing about it). regards, tom lane