X-Original-To: pgsql-interfaces-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 38BB75360F for ; Fri, 8 Apr 2005 21:41:58 +0100 (BST) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 38519-01 for ; Fri, 8 Apr 2005 20:41:53 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id 683735359C for ; Fri, 8 Apr 2005 21:41:52 +0100 (BST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.1/8.13.1) with ESMTP id j38KfbiY016763; Fri, 8 Apr 2005 16:41:38 -0400 (EDT) To: Vlad Cc: Brandon Metcalf , dbdpg-general@gborg.postgresql.org, pgsql-interfaces@postgresql.org Subject: Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg In-reply-to: References: <16221.1112987509@sss.pgh.pa.us> Comments: In-reply-to Vlad message dated "Fri, 08 Apr 2005 16:24:17 -0400" Date: Fri, 08 Apr 2005 16:41:37 -0400 Message-ID: <16762.1112992897@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.11 tagged_above=0 required=5 tests=AWL, UPPERCASE_25_50 X-Spam-Level: X-Archive-Number: 200504/37 X-Sequence-Number: 5453 Vlad writes: > diff -ru DBD-Pg-1.41/types.c DBD-Pg-1.41-patched/types.c > --- DBD-Pg-1.41/types.c Fri Apr 8 16:06:23 2005 > +++ DBD-Pg-1.41-patched/types.c Fri Apr 8 15:46:37 2005 > @@ -55,7 +55,7 @@ > {ABSTIMEOID, "abstime", DBDPG_TRUE, null_quote, null_dequote, {0}}, > {RELTIMEOID, "reltime", DBDPG_TRUE, null_quote, null_dequote, {0}}, > {TINTERVALOID, "tinterval", DBDPG_TRUE, null_quote, null_dequote, {0}}, > - {UNKNOWNOID, "unknown", DBDPG_FALSE, null_quote, null_dequote, {0}}, > + {UNKNOWNOID, "unknown", DBDPG_FALSE, quote_varchar, null_dequote, {0}}, > {CIRCLEOID, "circle", DBDPG_FALSE, null_quote, null_dequote, {0}}, > {CASHOID, "money", DBDPG_TRUE, null_quote, null_dequote, {0}}, > {MACADDROID, "MAC address", DBDPG_TRUE, > quote_varchar,dequote_varchar, {0}}, Hmm ... if those columns mean what it looks like they mean, quite a few of the other entries seem wrong too. All of the types visible in that fragment ought to be quoted when used as SQL literals. Also, if the MACADDROID entry is any precedent, shouldn't you be changing the dequote field too? regards, tom lane