To: "Brett W. McCoy" <bmccoy@chapelperilous.net>
cc: pgsql-interfaces@postgresql.org
Subject: Re: DBD::Pg 0.96 and DBI 1.15 ignoring username and password 
In-Reply-To: Message from "Brett W. McCoy" <bmccoy@chapelperilous.net>
	of "Sat, 14 Apr 2001 20:41:09 -0400."
	<Pine.LNX.4.30.0104142018080.12687-100000@chapelperilous.net>
Date: Sun, 15 Apr 2001 10:59:26 +1000
Message-ID: <17239.987296366@nemeton.com.au>
From: Giles Lean <giles@nemeton.com.au>


> If I change pg_hba.conf to 'trust' on localhost, (and unset $PGHOST) and I
> run the same script, it tells me that 'bmccoy' (who I am logged in as)
> does not exist as a user (which is true).  It looks like the user and
> password fields are being completely ignored by DBD::Pg.
>
> What happened?

New bug introduced.  Here's an (unofficial) fix.  I just sent it to the
dbi-users list and Edmund Mergl in reply to a message on the dbi-users
list, so I've dropped that list from this reply.

Regards,

Giles

*** DBD-Pg-0.96/Pg.pm-orig	Tue Apr 10 03:44:18 2001
--- DBD-Pg-0.96/Pg.pm	Sun Apr 15 10:26:16 2001
***************
*** 79,89 ****
          $Name =~ s/^.*dbname\s*=\s*//;
          $Name =~ s/\s*;.*$//;
  
!         $user = "" unless defined($user);
!         $auth = "" unless defined($auth);
! 
!         $user = $ENV{DBI_USER} unless $user eq "";
!         $auth = $ENV{DBI_PASS} unless $auth eq "";
  
          my($dbh) = DBI::_new_dbh($drh, {
              'Name' => $Name,
--- 79,88 ----
          $Name =~ s/^.*dbname\s*=\s*//;
          $Name =~ s/\s*;.*$//;
  
!         $user ||= $ENV{DBI_USER};
!         $auth ||= $ENV{DBI_PASS};
! 	$user ||= "";
! 	$auth ||= "";
  
          my($dbh) = DBI::_new_dbh($drh, {
              'Name' => $Name,