pg.ddx.io pgsql-interfaces@postgresql.org mailing list archive
help / color / mirror / Atom feedRe: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/libpq++/
8+ messages / 4 participants
[nested] [flat]
* Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/libpq++/
@ 1999-05-14 21:59 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 8+ messages in thread
From: Tom Lane @ 1999-05-14 21:59 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: pgsql-hackers@postgreSQL.org; pgsql-interfaces
Oleg Bartunov <oleg@sai.msu.su> writes:
> To compile postgres using gcc 2.7.2.1 I had to modify 2 files
> src/interfaces/libpq++/pgconnection.cc
> src/interfaces/libpq++/pgenv.h
> Particularly,
> #include <iostream> to #include <iostream.h>
> #include <strstream> to #include <strstream.h>
I am seeing the same thing here with gcc 2.7.2.2. We need to adopt
a considered policy about whether libpq++ will still support gcc 2.7.*,
not just break it without thinking.
I'd vote for still supporting 2.7.*, but I know that the C++ library
shipped with this gcc release is not real up-to-date. It may not be
practical to support both latest-C++-spec compilers and the older
generation; I'm not sure what the issues are.
If the conclusion is "no", then the configure script ought to be
changed to not try to build libpq++ unless up-to-date libraries
are available.
regards, tom lane
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/libpq++/
@ 1999-05-15 09:12 Bruce Momjian <maillist@candle.pha.pa.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 8+ messages in thread
From: Bruce Momjian @ 1999-05-15 09:12 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Oleg Bartunov <oleg@sai.msu.su>; pgsql-hackers@postgreSQL.org; pgsql-interfaces
> Oleg Bartunov <oleg@sai.msu.su> writes:
> > To compile postgres using gcc 2.7.2.1 I had to modify 2 files
> > src/interfaces/libpq++/pgconnection.cc
> > src/interfaces/libpq++/pgenv.h
> > Particularly,
> > #include <iostream> to #include <iostream.h>
> > #include <strstream> to #include <strstream.h>
>
> I am seeing the same thing here with gcc 2.7.2.2. We need to adopt
> a considered policy about whether libpq++ will still support gcc 2.7.*,
> not just break it without thinking.
>
> I'd vote for still supporting 2.7.*, but I know that the C++ library
> shipped with this gcc release is not real up-to-date. It may not be
> practical to support both latest-C++-spec compilers and the older
> generation; I'm not sure what the issues are.
>
> If the conclusion is "no", then the configure script ought to be
> changed to not try to build libpq++ unless up-to-date libraries
> are available.
The addition/removal of '.h' has happened before. Some need it, some
can't handle it.
--
Bruce Momjian | http://www.op.net/~candle
maillist@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/libpq++/
@ 1999-05-15 11:47 Patrick Welche <prlw1@cam.ac.uk>
0 siblings, 2 replies; 8+ messages in thread
From: prlw1@cam.ac.uk @ 1999-05-15 11:47 UTC (permalink / raw)
To: oleg@sai.msu.su; tgl@sss.pgh.pa.us; maillist@candle.pha.pa.us; +Cc: pgsql-interfaces; pgsql-hackers@postgresql.org
Oleg Bartunov <oleg@sai.msu.su> writes:
> To compile postgres using gcc 2.7.2.1 I had to modify 2 files
> src/interfaces/libpq++/pgconnection.cc
> src/interfaces/libpq++/pgenv.h
> Particularly,
> #include <iostream> to #include <iostream.h>
> #include <strstream> to #include <strstream.h>
My fault. I was using
gcc version egcs-2.91.60 19981201 (egcs-1.1.1 release)
when creating the above patches. However, please make the above
correct change, as all <iostream> does is to include <iostream.h> and
similarly <strstream> just includes <strstream.h>. I think the meaning
is deeper with other compilers, but with egcs they are just aliases. I
did, as Tom Lane puts it, just break it without thinking.
Cheers,
Patrick
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [INTERFACES] Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/libpq++/
@ 1999-05-16 14:36 Tom Lane <tgl@sss.pgh.pa.us>
parent: Patrick Welche <prlw1@cam.ac.uk>
1 sibling, 0 replies; 8+ messages in thread
From: Tom Lane @ 1999-05-16 14:36 UTC (permalink / raw)
To: prlw1@cam.ac.uk; +Cc: oleg@sai.msu.su; pgsql-interfaces
prlw1@cam.ac.uk (Patrick Welche) writes:
> Oleg Bartunov <oleg@sai.msu.su> writes:
>> To compile postgres using gcc 2.7.2.1 I had to modify 2 files
>> src/interfaces/libpq++/pgconnection.cc
>> src/interfaces/libpq++/pgenv.h
>> Particularly,
>> #include <iostream> to #include <iostream.h>
>> #include <strstream> to #include <strstream.h>
> My fault. I was using
> gcc version egcs-2.91.60 19981201 (egcs-1.1.1 release)
> when creating the above patches. However, please make the above
> correct change, as all <iostream> does is to include <iostream.h> and
> similarly <strstream> just includes <strstream.h>.
Applied.
regards, tom lane
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/l
@ 1999-05-17 16:00 Vince Vielhaber <vev@michvhf.com>
parent: Patrick Welche <prlw1@cam.ac.uk>
1 sibling, 1 reply; 8+ messages in thread
From: Vince Vielhaber @ 1999-05-17 16:00 UTC (permalink / raw)
To: (Patrick Welche) <prlw1@cam.ac.uk>; +Cc: pgsql-hackers@postgreSQL.org, pgsql-interfaces@postgreSQL.org, (Bruce Momjian) <maillist@candle.pha.pa.us>; (Tom Lane) <tgl@sss.pgh.pa.us>; (Oleg Bartunov) <oleg@sai.msu.su>
On 15-May-99 Patrick Welche wrote:
> Oleg Bartunov <oleg@sai.msu.su> writes:
>> To compile postgres using gcc 2.7.2.1 I had to modify 2 files
>> src/interfaces/libpq++/pgconnection.cc
>> src/interfaces/libpq++/pgenv.h
>> Particularly,
>> #include <iostream> to #include <iostream.h>
>> #include <strstream> to #include <strstream.h>
>
> My fault. I was using
>
> gcc version egcs-2.91.60 19981201 (egcs-1.1.1 release)
>
> when creating the above patches. However, please make the above
> correct change, as all <iostream> does is to include <iostream.h> and
> similarly <strstream> just includes <strstream.h>. I think the meaning
> is deeper with other compilers, but with egcs they are just aliases. I
> did, as Tom Lane puts it, just break it without thinking.
>
libpq++ is being redone. Since 6.5 is under code freeze right now it'll
be 6.5.1 before the new stuff can show up. pgenv.h is already history
as it uses pretty much all deprecated functions.
Vince.
--
==========================================================================
Vince Vielhaber -- KA8CSH email: vev@michvhf.com flame-mail: /dev/null
# include <std/disclaimers.h> TEAM-OS2
Online Campground Directory http://www.camping-usa.com
Online Giftshop Superstore http://www.cloudninegifts.com
==========================================================================
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/l
@ 1999-05-17 16:12 Bruce Momjian <maillist@candle.pha.pa.us>
parent: Vince Vielhaber <vev@michvhf.com>
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Momjian @ 1999-05-17 16:12 UTC (permalink / raw)
To: Vince Vielhaber <vev@michvhf.com>; +Cc: prlw1@cam.ac.uk; pgsql-hackers@postgreSQL.org; pgsql-interfaces; tgl@sss.pgh.pa.us; oleg@sai.msu.su
> libpq++ is being redone. Since 6.5 is under code freeze right now it'll
> be 6.5.1 before the new stuff can show up. pgenv.h is already history
> as it uses pretty much all deprecated functions.
>
> Vince.
I think we may be able to put libpq++ into 6.5 at this point. It is
pretty limited now. I certainly don't think you are going to get it
into 6.5.1, because those are mostly fix releases.
--
Bruce Momjian | http://www.op.net/~candle
maillist@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/l
@ 1999-05-17 16:32 Vince Vielhaber <vev@michvhf.com>
parent: Bruce Momjian <maillist@candle.pha.pa.us>
0 siblings, 1 reply; 8+ messages in thread
From: Vince Vielhaber @ 1999-05-17 16:32 UTC (permalink / raw)
To: Bruce Momjian <maillist@candle.pha.pa.us>; +Cc: oleg@sai.msu.su, (Oleg Bartunov) <tgl@sss.pgh.pa.us>; pgsql-interfaces; pgsql-hackers@postgreSQL.org; prlw1@cam.ac.uk
On 17-May-99 Bruce Momjian wrote:
>> libpq++ is being redone. Since 6.5 is under code freeze right now it'll
>> be 6.5.1 before the new stuff can show up. pgenv.h is already history
>> as it uses pretty much all deprecated functions.
>>
>> Vince.
>
> I think we may be able to put libpq++ into 6.5 at this point. It is
> pretty limited now. I certainly don't think you are going to get it
> into 6.5.1, because those are mostly fix releases.
Don't have it on this machine, but I'll send it along tomorrow or the
next day. Right now the only thing that's not working with the examples
is the large object stuff with binaries and I haven't tracked that down.
But it doesn't work with the example in the docs for libpq either...
Still alot I want to do but it's in alot better shape now than it was.
Dmitry's suggestions aren't in yet but will be soon.
Vince.
--
==========================================================================
Vince Vielhaber -- KA8CSH email: vev@michvhf.com flame-mail: /dev/null
# include <std/disclaimers.h> TEAM-OS2
Online Campground Directory http://www.camping-usa.com
Online Giftshop Superstore http://www.cloudninegifts.com
==========================================================================
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/l
@ 1999-05-17 16:34 Bruce Momjian <maillist@candle.pha.pa.us>
parent: Vince Vielhaber <vev@michvhf.com>
0 siblings, 0 replies; 8+ messages in thread
From: Bruce Momjian @ 1999-05-17 16:34 UTC (permalink / raw)
To: Vince Vielhaber <vev@michvhf.com>; +Cc: oleg@sai.msu.su; tgl@sss.pgh.pa.us; pgsql-interfaces; pgsql-hackers@postgreSQL.org; prlw1@cam.ac.uk
> Don't have it on this machine, but I'll send it along tomorrow or the
> next day. Right now the only thing that's not working with the examples
> is the large object stuff with binaries and I haven't tracked that down.
> But it doesn't work with the example in the docs for libpq either...
> Still alot I want to do but it's in alot better shape now than it was.
> Dmitry's suggestions aren't in yet but will be soon.
Yes, I would like to get something new in libpq++.
--
Bruce Momjian | http://www.op.net/~candle
maillist@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~1999-05-17 16:34 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
1999-05-14 21:59 Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/libpq++/ Tom Lane <tgl@sss.pgh.pa.us>
1999-05-15 09:12 ` Bruce Momjian <maillist@candle.pha.pa.us>
1999-05-15 11:47 Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/libpq++/ Patrick Welche <prlw1@cam.ac.uk>
1999-05-16 14:36 ` Tom Lane <tgl@sss.pgh.pa.us>
1999-05-17 16:00 ` Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/l Vince Vielhaber <vev@michvhf.com>
1999-05-17 16:12 ` Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/l Bruce Momjian <maillist@candle.pha.pa.us>
1999-05-17 16:32 ` Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/l Vince Vielhaber <vev@michvhf.com>
1999-05-17 16:34 ` Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/l Bruce Momjian <maillist@candle.pha.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox