Received: from sss.pgh.pa.us (sss.pgh.pa.us [209.114.132.154]) by mail.postgresql.org (8.11.1/8.11.1) with ESMTP id f1SJ2Wx70721 for ; Wed, 28 Feb 2001 14:02:32 -0500 (EST) (envelope-from tgl@sss.pgh.pa.us) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.11.1/8.11.1) with ESMTP id f1SJ2E919056; Wed, 28 Feb 2001 14:02:14 -0500 (EST) To: Bruce Momjian cc: Peter Eisentraut , Dan Lyke , pgsql-interfaces@postgresql.org Subject: Re: Double newline bug with DBD::Pg: Where best to fix? In-reply-to: <200102281806.NAA05912@candle.pha.pa.us> References: <200102281806.NAA05912@candle.pha.pa.us> Comments: In-reply-to Bruce Momjian message dated "Wed, 28 Feb 2001 13:06:55 -0500" Date: Wed, 28 Feb 2001 14:02:13 -0500 Message-ID: <19053.983386933@sss.pgh.pa.us> From: Tom Lane X-Archive-Number: 200102/194 X-Sequence-Number: 1158 Bruce Momjian writes: > Peter, I have thought about this some more. Seems we either add the > 'quote' check, or remove the optimizations completely. Because we have > to change it one way or the other for 7.1, it seems we should just > remove the tests totally. It's kind of handy that, for example, you can hit return a few times without causing psql to think that something's been put into the query buffer. I'm worried that removing this code entirely might lead to problems like failure to recognize backslash commands preceded by whitespace. Peter's patch looks like the most conservative fix to me ... regards, tom lane