From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200002141232.HAA15711@candle.pha.pa.us>
Subject: Re: Postgres ODBC
In-Reply-To: <38A7DB02.2E73492D@easysoft.com> from Nick Gorham at "Feb 14,
 2000
	10:37:54 am"
To: Nick Gorham <nick@easysoft.com>
Date: Mon, 14 Feb 2000 07:32:40 -0500 (EST)
CC: PostgreSQL-development <pgsql-hackers@postgreSQL.org>,
	PostgreSQL-interfaces <pgsql-interfaces@postgreSQL.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Patch applied.  Thanks.

> Hi,
> 
> I suspect that you are not the person to send this to, but I wasn't sure
> where else to mail it. I am the maintainer of unixODBC, and we have a
> set of code in our project that started life as the Postgres windows
> ODBC driver, which has been ported back to unix. Anyway I have just
> fixed a memory leak in the driver, and I cant see any mention of the fix
> being done in the main Postgres code, so I thougth I would let you know.
> 
> Its in the statement.c module, after the COMMIT statement has been
> executed in SC_Execute, the code was
> 
>         /*//    If we are in autocommit, we must send the commit. */
>         if ( ! self->internal && CC_is_in_autocommit(conn) &&
> STMT_UPDATE(self)) {
>             CC_send_query(conn, "COMMIT", NULL);
>             CC_set_no_trans(conn);
>         }
> 
> I have changed it to
> 
> 
>         /*//    If we are in autocommit, we must send the commit. */
>         if ( ! self->internal && CC_is_in_autocommit(conn) &&
> STMT_UPDATE(self)) {
>             res = CC_send_query(conn, "COMMIT", NULL);
>             QR_Destructor(res);
>             CC_set_no_trans(conn);
>         }
> 
> Nick Gorham
> 
> 


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026