Received: from bajor.mug.org (bajor.mug.org [207.158.132.10]) by hub.org (8.9.3/8.9.3) with ESMTP id BAA56718 for ; Sun, 4 Jun 2000 01:40:00 -0400 (EDT) (envelope-from bga@bajor.mug.org) Received: from bajor.mug.org (localhost [127.0.0.1]) by bajor.mug.org (8.8.7/UW7.0.1) with ESMTP id BAA13726; Sun, 4 Jun 2000 01:40:47 -0400 (EDT) Message-Id: <200006040540.BAA13726@bajor.mug.org> X-Mailer: exmh version 2.1.1 10/15/1999 From: "Billy G. Allie" Reply-To: "Billy G. Allie" To: pygresql@vex.net Cc: pgsql-interfaces@postgresql.org Subject: PyGreSQL-3.0 bug + patch Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_-1380580192P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Sun, 04 Jun 2000 01:40:47 -0400 X-Archive-Number: 200006/15 --==_Exmh_-1380580192P Content-Type: multipart/mixed ; boundary="==_Exmh_-13817334400" This is a multipart MIME message. --==_Exmh_-13817334400 Content-Type: text/plain; charset=us-ascii The fetch() function in pgmodule.c contains an error where it does not return the next row each time it is called. It always returns the first row of the result set. The following patch corrects the problem. It also replaces the call to bzero() with a call to memset(). Both memset (twice) and bzero (once) were used in pgmodule.c. I changed bzero to memset to be consistant in usage. Finally, a string with an embedded newline is fixed. --==_Exmh_-13817334400 Content-Type: text/plain ; name="patch.20000604-1"; charset=us-ascii Content-Description: patch.20000604-1 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch.20000604-1" KioqIHBnbW9kdWxlLmMub3JpZwlTdW4gSnVuICA0IDAxOjIxOjEyIDIwMDAK LS0tIHBnbW9kdWxlLmMJU3VuIEp1biAgNCAwMToxNDowMyAyMDAwCioqKioq KioqKioqKioqKgoqKiogNTUwLDU1NiAqKioqCiAgCQkJCXN0ciA9IFB5X05v bmU7CiAgCQkJfQogIAkJCWVsc2UKISAJCQkJc3RyID0gUHlTdHJpbmdfRnJv bVN0cmluZyhQUWdldHZhbHVlKHNlbGYtPmxhc3RfcmVzdWx0LCBpLCBqKSk7 CiAgCiAgCQkJUHlUdXBsZV9TRVRfSVRFTShyb3d0dXBsZSwgaiwgc3RyKTsK ICAJCX0KLS0tIDU1MCw1NTcgLS0tLQogIAkJCQlzdHIgPSBQeV9Ob25lOwog IAkJCX0KICAJCQllbHNlCiEgCQkJCXN0ciA9IFB5U3RyaW5nX0Zyb21TdHJp bmcoUFFnZXR2YWx1ZShzZWxmLT5sYXN0X3Jlc3VsdCwKISAJCQkJCQkJCQkJ CXNlbGYtPmN1cnJlbnRfcm93LCBqKSk7CiAgCiAgCQkJUHlUdXBsZV9TRVRf SVRFTShyb3d0dXBsZSwgaiwgc3RyKTsKICAJCX0KKioqKioqKioqKioqKioq CioqKiAxNTAyLDE1MDggKioqKgogIAogIAlpZiAocGdwb3J0ICE9IC0xKQog IAl7CiEgCQliemVybyhwb3J0X2J1ZmZlciwgc2l6ZW9mKHBvcnRfYnVmZmVy KSk7CiAgCQlzcHJpbnRmKHBvcnRfYnVmZmVyLCAiJWQiLCBwZ3BvcnQpOwog IAkJbnBnb2JqLT5jbnggPSBQUXNldGRiTG9naW4ocGdob3N0LCBwb3J0X2J1 ZmZlciwgcGdvcHQsIHBndHR5LCBwZ2RibmFtZSwKICAJCQkJCXBndXNlciwg cGdwYXNzd2QpOwotLS0gMTUwMywxNTA5IC0tLS0KICAKICAJaWYgKHBncG9y dCAhPSAtMSkKICAJewohIAkJbWVtc2V0KHBvcnRfYnVmZmVyLCAwLCBzaXpl b2YocG9ydF9idWZmZXIpKTsKICAJCXNwcmludGYocG9ydF9idWZmZXIsICIl ZCIsIHBncG9ydCk7CiAgCQlucGdvYmotPmNueCA9IFBRc2V0ZGJMb2dpbihw Z2hvc3QsIHBvcnRfYnVmZmVyLCBwZ29wdCwgcGd0dHksIHBnZGJuYW1lLAog IAkJCQkJcGd1c2VyLCBwZ3Bhc3N3ZCk7CioqKioqKioqKioqKioqKgoqKiog Mjk3NiwyOTgzICoqKioKICAJaWYgKCFQeUFyZ19QYXJzZVR1cGxlKGFyZ3Ms ICJ6IiwgJnRlbXApKQogIAl7CiAgCQlQeUVycl9TZXRTdHJpbmcoUHlFeGNf VHlwZUVycm9yLAohIAkJCQkic2V0X2RlZnBhc3N3ZChwYXNzd29yZCksIHdp dGggcGFzc3dvcmQgKHN0cmluZy8KISBOb25lKS4iKTsKICAJCXJldHVybiBO VUxMOwogIAl9CiAgCi0tLSAyOTc3LDI5ODMgLS0tLQogIAlpZiAoIVB5QXJn X1BhcnNlVHVwbGUoYXJncywgInoiLCAmdGVtcCkpCiAgCXsKICAJCVB5RXJy X1NldFN0cmluZyhQeUV4Y19UeXBlRXJyb3IsCiEgCQkJCSJzZXRfZGVmcGFz c3dkKHBhc3N3b3JkKSwgd2l0aCBwYXNzd29yZCAoc3RyaW5nL05vbmUpLiIp OwogIAkJcmV0dXJuIE5VTEw7CiAgCX0KICAK --==_Exmh_-13817334400 Content-Type: text/plain; charset=us-ascii ____ | Billy G. Allie | Domain....: Bill.Allie@mug.org | /| | 7436 Hartwell | Compuserve: 76337,2061 |-/-|----- | Dearborn, MI 48126| MSN.......: B_G_Allie@email.msn.com |/ |LLIE | (313) 582-1540 | --==_Exmh_-13817334400-- --==_Exmh_-1380580192P Content-Type: application/pgp-signature -----BEGIN PGP MESSAGE----- Version: PGPfreeware 5.0i for non-commercial use MessageID: DMvgQR8yWgCDYrJPz9Ac6L3ciajrIHxH owGdVkuP40oVHkAsiIjgCsS6NBqkbmmStuOkezyj1uA4LzuPnrycxEK0/Kg4NSmX PbbTjlu9Y8XqSiyQWIC46G5ZsYCfcNmzuhvEenawRuKUnXTP3Jm7GautqOvUOef7 vnPquH7z6OX3vv8dWX77ry9+5T+J//P53z777pf/ePTHi3+3L7/2//vz33/x+e/+ /qjy8uWXX//v0R9+Vjr9559/8jZ98lVd/er07V9//acf/fYvP3yS/PQs8cMzoerH XlWSpfMq3vubH382+KUasASzpDLLQvwc+TuakNCKkjOf7LGLXpRLP7CDHXOtKLt8 fHl53Qa364ooPRMvJKleF4TH5VK5NNuQGMGf9RAADbVhG/k4ji0PV/mmSuVj/uXS +wgSvE/OQmoR9gI5GyuKcXK5iytW7BBSpMJojRNnc3KK1jvmJCRgiDAUen7g7iiu OsiBgOAPcBjCURREKN3gCCOSIDfAMWJBgiKc7CKGyqUE4jHIiaIgRdhyNighfr4X +DgWpditIqQlyKKplcUHxxhxvzWJ4sIxWOcL5VKEY1AAAWrwyrEGlAYpYR4KLUAN 4KIIO0kRIIwCm2L/mCAOIDxwd3BhLpc4AJQEyL7FUQCMU5JsQOXjso99yHRyCgGa AViK/9FJkhIHnwJ/t/BEJwHjC+VSyoXYxVDa9zTjCLjczMNHl/vweX7MVY1JnFgs 4a67Q1k7hAGW7CmAipOI0ywggvK+jV0XwjGcUsIw13PNm+qTmgG9QMzy8eXjXMVq TYDnXKhXxMcfa5NjlBaOnYiEvEeeF/q/4/mwbRZZLF7jqNJmTuACiefItmJ8Xn/Y 0iJxGMSkiGQlCTSKD+svgBLF34KM8+yT4I3WazJ7IW/dxZ4O/OHOlvTQTOnMXdS9 KTN2mqoIWkvZX73W4G1nWktLhy2lP5gKydG3XDp463MJPNqhaBPFG6lKOpwF+1Er SIeZkoFXqkJGnvW918t/vdFsnpZLg9ZcHBElt6gQRR1vdXU5EhyiyFqn2VgKjRvb n18cbetx4GkK7FkYsVOb97WpovN1aE9pAmgFb94DNj09tH13PWH6jW1ANJ/uzGwz ni9c6vbMjd0zaL83onZ3lbzy9xvwXTu+cQu8oO4DtRnC+6Y/3RZ5D7kh8txdNmPT kGcTY7KeGpPObLrJbMkV8vVp6lkk9TiS/izul0ugJrARCvWA6VBNxdHM8fj/gyOT Mb11e5r3atocY0O+smsNepUebODLY0Dtx5TagFgl7Q80mkM+a9FgS8HM7Jp4YO8E 806HmctJbbXYi+Z0c2su9j6wmzXiFXgvJZ06khG7anqv4v27PGozEh2mU5txfWTp XVUA0yfqclTl2BFFZx7fomeU/WimZINWWxy2PC+3eVwT/tLQJErgdN0UulfQ1Las qcK+D3qC4gq9KDSiBPtGZmebfNeypoumb1KH46jRc3Mh+/1e88YBZitm+CbsPTLj FYF+4iqyyQe7BqpC9MWYgBapKXHbODzWy2ZwQmr6G9D4tc28vKbl0hzUdLsTMuvK zFrUOfLAlkYCj/ABtq574/TGMT9rbm/SyLPUJsT2O0m5BEoW6uU1gh0Q+eCVQk1v 3VqOJYH+8oZwvoZZynVsgD58jfse+slarDxgxpyunLmqsnk1VZLhdJtbcRpscjYL I3FqhvARBVLAdWstQ1ou2bVVkEfpyMRdAI+lFj5UeZTys+d2P9gTa6pGTVXLmXIb TBX1Xv8d12HlB7wDd1jN+3zCsZhdfWjX3NAmG9Blc+NIuVbv4ctPMFjlFHqbayO4 vW2eB7x3q4VIB3kfFb0OdhEiZ7mP1IRZMJLMHMk3O/PQhfzXG77eSiOSZlcz71ZT 87Wcca6r2hnjeSczRXm8Wuq3pjGBAe9097TfhVVpCNz1cw3qprMJtZdKyHu36Nyc PXgbmUPlGZzeh9Pcox3cHa3LJaNHU5Pv8OUMmOS1AiaE67OsTajJjiw2h66QM2AE Crih2/VAkc6tI7k3gMkfQxcc5+MzmAPNfP70p3XyUEMdZiacJNK8Mub7YdHrVM6x Et5XCih+NXOkQUtrXLWG70y34qRqRrMxXupsKQIuNqJGz0jt7jwAbZiTpZ7GAjhN iu92DehxR92GeezlIT94T5Z6thThFHWOWDdco/pKlOd42aTcbktafD8dpzqcYFBv bXYN/8B3C32c6wJnbtuHmeTWqGBB1R80gqlymKWD4rsTDogWArvD+YZvBEw0Hb55 DWPWTot6FTO6/yk3iY/dF8qla3hQ8dyhJoErDepWkUJhohVrrcAH5yo8z3N7Nbf9 wt951SCCIXiH0Nkd38o3X9Slc9SDW3CK4aJWrKmBH8LFK7oBNBfnknTxtCacQ4/e Vc4qdxX+8CzYiuwgYk/h+ozqz8Ta+R0aTkc8bTXPfN29LhJjgEPhOs+qTgBfmLsz yDEYaG2e6kQSpVPUeFariI26UKT/dqkqFW4rl/4P =IrJV -----END PGP MESSAGE----- --==_Exmh_-1380580192P--