pg.ddx.io  pgsql-interfaces@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Re: no meaningful way to determine fe or be version?
8+ messages / 4 participants
[nested] [flat]

* Re: no meaningful way to determine fe or be version?
@ 2000-11-16 20:52  Paul M. Aoki <aoki@acm.org>
  0 siblings, 2 replies; 8+ messages in thread

From: aoki@acm.org @ 2000-11-16 20:52 UTC (permalink / raw)
  To: Bruce Momjian <pgman@candle.pha.pa.us>; +Cc: pgsql-bugs@postgresql.org

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Yes, should we return the client or server version from the interface? 
> If we return the server version, how does someone query the client version?

sorry, yes.  the client-side interfaces (DatabaseMetaData.getDriver*) 
are actually fine - they return a major/minor version that have been
getting manually updated (they're much more visible, being in 
org/postgresql/Driver.java).  the server-side interfaces 
(DatabaseMetaData.getDatabase{Name,Version}) are the ones that aren't
tied to the server, return hardcoded strings and haven't been getting
updated regularly.
--
 Paul M. Aoki / Xerox Palo Alto Research Center / 3333 Coyote Hill Road
 aoki@acm.org / Computer Science Laboratory     / Palo Alto, CA 94304-1314



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: no meaningful way to determine fe or be version?
@ 2000-11-16 20:58  Bruce Momjian <pgman@candle.pha.pa.us>
  parent: Paul M. Aoki <aoki@acm.org>
  1 sibling, 2 replies; 8+ messages in thread

From: Bruce Momjian @ 2000-11-16 20:58 UTC (permalink / raw)
  To: Paul M. Aoki <aoki@acm.org>; +Cc: pgsql-interfaces

> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Yes, should we return the client or server version from the interface? 
> > If we return the server version, how does someone query the client version?
> 
> sorry, yes.  the client-side interfaces (DatabaseMetaData.getDriver*) 
> are actually fine - they return a major/minor version that have been
> getting manually updated (they're much more visible, being in 
> org/postgresql/Driver.java).  the server-side interfaces 
> (DatabaseMetaData.getDatabase{Name,Version}) are the ones that aren't
> tied to the server, return hardcoded strings and haven't been getting
> updated regularly.

Oh, really.  I didn't know there was that distinction.  Sounds like they
should be callling SELECT version().  Comments, Java folks?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [INTERFACES] Re: no meaningful way to determine fe or be version?
@ 2000-11-17 00:17  Joseph Shraibman <jks@selectacast.net>
  parent: Bruce Momjian <pgman@candle.pha.pa.us>
  1 sibling, 0 replies; 8+ messages in thread

From: Joseph Shraibman @ 2000-11-17 00:17 UTC (permalink / raw)
  To: Bruce Momjian <pgman@candle.pha.pa.us>; +Cc: Paul M. Aoki <aoki@acm.org>; pgsql-interfaces

Bruce Momjian wrote:
> 
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > Yes, should we return the client or server version from the interface?
> > > If we return the server version, how does someone query the client version?
> >
> > sorry, yes.  the client-side interfaces (DatabaseMetaData.getDriver*)
> > are actually fine - they return a major/minor version that have been
> > getting manually updated (they're much more visible, being in
> > org/postgresql/Driver.java).  the server-side interfaces
> > (DatabaseMetaData.getDatabase{Name,Version}) are the ones that aren't
> > tied to the server, return hardcoded strings and haven't been getting
> > updated regularly.
> 
> Oh, really.  I didn't know there was that distinction.  Sounds like they
> should be callling SELECT version().  Comments, Java folks?
> 
I remember someone posting a patch saying that he changed the code to do
that.  Or saying he was going to post a patch, I forget.

Anyway, I just checked and it isn't in the cvs.

-- 
Joseph Shraibman
jks@selectacast.net
Increase signal to noise ratio.  http://www.targabot.com



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [INTERFACES] Re: no meaningful way to determine fe or be version?
@ 2000-11-17 09:34  Anders Bengtsson <anders@lecando.com>
  parent: Bruce Momjian <pgman@candle.pha.pa.us>
  1 sibling, 2 replies; 8+ messages in thread

From: Anders Bengtsson @ 2000-11-17 09:34 UTC (permalink / raw)
  To: ; +Cc: pgsql-interfaces

Bruce Momjian wrote:
> 
> > sorry, yes.  the client-side interfaces (DatabaseMetaData.getDriver*)
> > are actually fine - they return a major/minor version that have been
> > getting manually updated (they're much more visible, being in
> > org/postgresql/Driver.java).  the server-side interfaces
> > (DatabaseMetaData.getDatabase{Name,Version}) are the ones that aren't
> > tied to the server, return hardcoded strings and haven't been getting
> > updated regularly.
> 
> Oh, really.  I didn't know there was that distinction.  Sounds like they
> should be callling SELECT version().  Comments, Java folks?

I posted a patch for the JDBC driver to pgsql-interfaces to do just that
some time ago. Don't know what happened to it, though .. 

/Anders
________________________________________________________________________
A n d e r s  B e n g t s s o n                        anders@lecando.com
http://www.lecando.com



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [INTERFACES] Re: no meaningful way to determine fe or be version?
@ 2000-11-17 17:20  Bruce Momjian <pgman@candle.pha.pa.us>
  parent: Anders Bengtsson <anders@lecando.com>
  1 sibling, 0 replies; 8+ messages in thread

From: Bruce Momjian @ 2000-11-17 17:20 UTC (permalink / raw)
  To: Anders Bengtsson <anders@lecando.com>; +Cc: pgsql-interfaces

This concerns me.  Did we lose a patch here?  Can you send it again?

> Bruce Momjian wrote:
> > 
> > > sorry, yes.  the client-side interfaces (DatabaseMetaData.getDriver*)
> > > are actually fine - they return a major/minor version that have been
> > > getting manually updated (they're much more visible, being in
> > > org/postgresql/Driver.java).  the server-side interfaces
> > > (DatabaseMetaData.getDatabase{Name,Version}) are the ones that aren't
> > > tied to the server, return hardcoded strings and haven't been getting
> > > updated regularly.
> > 
> > Oh, really.  I didn't know there was that distinction.  Sounds like they
> > should be callling SELECT version().  Comments, Java folks?
> 
> I posted a patch for the JDBC driver to pgsql-interfaces to do just that
> some time ago. Don't know what happened to it, though .. 
> 
> /Anders
> ________________________________________________________________________
> A n d e r s  B e n g t s s o n                        anders@lecando.com
> http://www.lecando.com
> 


-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [INTERFACES] Re: no meaningful way to determine fe or be version?
@ 2000-11-20 19:54  Joseph Shraibman <jks@selectacast.net>
  parent: Anders Bengtsson <anders@lecando.com>
  1 sibling, 1 reply; 8+ messages in thread

From: Joseph Shraibman @ 2000-11-20 19:54 UTC (permalink / raw)
  To: Anders Bengtsson <anders@lecando.com>; +Cc: pgsql-interfaces

Try submitting it to the psgsl-patches list.

Anders Bengtsson wrote:
> 
> Bruce Momjian wrote:
> >
> > > sorry, yes.  the client-side interfaces (DatabaseMetaData.getDriver*)
> > > are actually fine - they return a major/minor version that have been
> > > getting manually updated (they're much more visible, being in
> > > org/postgresql/Driver.java).  the server-side interfaces
> > > (DatabaseMetaData.getDatabase{Name,Version}) are the ones that aren't
> > > tied to the server, return hardcoded strings and haven't been getting
> > > updated regularly.
> >
> > Oh, really.  I didn't know there was that distinction.  Sounds like they
> > should be callling SELECT version().  Comments, Java folks?
> 
> I posted a patch for the JDBC driver to pgsql-interfaces to do just that
> some time ago. Don't know what happened to it, though ..
> 
> /Anders
> ________________________________________________________________________
> A n d e r s  B e n g t s s o n                        anders@lecando.com
> http://www.lecando.com

-- 
Joseph Shraibman
jks@selectacast.net
Increase signal to noise ratio.  http://www.targabot.com



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [INTERFACES] Re: no meaningful way to determine fe or be version?
@ 2000-11-25 04:30  Bruce Momjian <pgman@candle.pha.pa.us>
  parent: Joseph Shraibman <jks@selectacast.net>
  0 siblings, 0 replies; 8+ messages in thread

From: Bruce Momjian @ 2000-11-25 04:30 UTC (permalink / raw)
  To: Joseph Shraibman <jks@selectacast.net>; +Cc: Anders Bengtsson <anders@lecando.com>; pgsql-interfaces

Sorry, I am just now catching up to the fact that this problem was
already discussed.  I have gotten the patch from the URL supplied by the
author, and have applied it to the CVS tree.  It will appear in
tomorrow's snapshot, and in 7.1.


Thanks for the patch.  Someone else we complaining about this also just
last week.  I will let him know it will be fixed in 7.1.


> Try submitting it to the psgsl-patches list.
> 
> Anders Bengtsson wrote:
> > 
> > Bruce Momjian wrote:
> > >
> > > > sorry, yes.  the client-side interfaces (DatabaseMetaData.getDriver*)
> > > > are actually fine - they return a major/minor version that have been
> > > > getting manually updated (they're much more visible, being in
> > > > org/postgresql/Driver.java).  the server-side interfaces
> > > > (DatabaseMetaData.getDatabase{Name,Version}) are the ones that aren't
> > > > tied to the server, return hardcoded strings and haven't been getting
> > > > updated regularly.
> > >
> > > Oh, really.  I didn't know there was that distinction.  Sounds like they
> > > should be callling SELECT version().  Comments, Java folks?
> > 
> > I posted a patch for the JDBC driver to pgsql-interfaces to do just that
> > some time ago. Don't know what happened to it, though ..
> > 
> > /Anders
> > ________________________________________________________________________
> > A n d e r s  B e n g t s s o n                        anders@lecando.com
> > http://www.lecando.com
> 
> -- 
> Joseph Shraibman
> jks@selectacast.net
> Increase signal to noise ratio.  http://www.targabot.com
> 


-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: no meaningful way to determine fe or be version?
@ 2000-11-25 04:31  Bruce Momjian <pgman@candle.pha.pa.us>
  parent: Paul M. Aoki <aoki@acm.org>
  1 sibling, 0 replies; 8+ messages in thread

From: Bruce Momjian @ 2000-11-25 04:31 UTC (permalink / raw)
  To: Paul M. Aoki <aoki@acm.org>; +Cc: pgsql-bugs@postgresql.org

> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Yes, should we return the client or server version from the interface? 
> > If we return the server version, how does someone query the client version?
> 
> sorry, yes.  the client-side interfaces (DatabaseMetaData.getDriver*) 
> are actually fine - they return a major/minor version that have been
> getting manually updated (they're much more visible, being in 
> org/postgresql/Driver.java).  the server-side interfaces 
> (DatabaseMetaData.getDatabase{Name,Version}) are the ones that aren't
> tied to the server, return hardcoded strings and haven't been getting
> updated regularly.

Good news.  Someone supplied a patch to getDatabaseProductVersion() that
properly does the SELECT version(); and returns the result.  It will
appear in 7.1.


-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026



^ permalink  raw  reply  [nested|flat] 8+ messages in thread


end of thread, other threads:[~2000-11-25 04:31 UTC | newest]

Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2000-11-16 20:52 Re: no meaningful way to determine fe or be version? Paul M. Aoki <aoki@acm.org>
2000-11-16 20:58 ` Bruce Momjian <pgman@candle.pha.pa.us>
2000-11-17 00:17   ` Joseph Shraibman <jks@selectacast.net>
2000-11-17 09:34   ` Anders Bengtsson <anders@lecando.com>
2000-11-17 17:20     ` Bruce Momjian <pgman@candle.pha.pa.us>
2000-11-20 19:54     ` Joseph Shraibman <jks@selectacast.net>
2000-11-25 04:30       ` Bruce Momjian <pgman@candle.pha.pa.us>
2000-11-25 04:31 ` Bruce Momjian <pgman@candle.pha.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox