Received: from candle.pha.pa.us (candle.navpoint.com [162.33.245.46])
	by mail.postgresql.org (8.11.1/8.11.1) with ESMTP id eBSNvIL42472;
	Thu, 28 Dec 2000 18:57:18 -0500 (EST)
	(envelope-from pgman@candle.pha.pa.us)
Received: (from pgman@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id
 SAA21967;
	Thu, 28 Dec 2000 18:56:58 -0500 (EST)
From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200012282356.SAA21967@candle.pha.pa.us>
Subject: Re: Two minor fixes to reduce resource usage in JDBC drivers
In-Reply-To: <3A49032E.BBD063FF@xythos.com> "from Barry Lind at Dec 26, 2000
	12:44:30 pm"
To: Barry Lind <barry@xythos.com>
Date: Thu, 28 Dec 2000 18:56:58 -0500 (EST)
CC: pgsql-patches@postgresql.org, pgsql-interfaces@postgresql.org
X-Mailer: ELM [version 2.4ME+ PL77 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Archive-Number: 200012/239
X-Sequence-Number: 584

Thanks.  Applied.
---------------------------------------------------------------------------


*** ./org/postgresql/jdbc1/PreparedStatement.java.orig	Tue Dec 26 11:50:03 2000
--- ./org/postgresql/jdbc1/PreparedStatement.java	Tue Dec 26 11:15:52 2000
***************
*** 164,170 ****
  	 */
  	public void setByte(int parameterIndex, byte x) throws SQLException
  	{
! 		set(parameterIndex, (new Integer(x)).toString());
  	}
  
  	/**
--- 164,170 ----
  	 */
  	public void setByte(int parameterIndex, byte x) throws SQLException
  	{
! 		set(parameterIndex, Integer.toString(x));
  	}
  
  	/**
***************
*** 177,183 ****
  	 */
  	public void setShort(int parameterIndex, short x) throws SQLException
  	{
! 		set(parameterIndex, (new Integer(x)).toString());
  	}
  
  	/**
--- 177,183 ----
  	 */
  	public void setShort(int parameterIndex, short x) throws SQLException
  	{
! 		set(parameterIndex, Integer.toString(x));
  	}
  
  	/**
***************
*** 190,196 ****
  	 */
  	public void setInt(int parameterIndex, int x) throws SQLException
  	{
! 		set(parameterIndex, (new Integer(x)).toString());
  	}
  
  	/**
--- 190,196 ----
  	 */
  	public void setInt(int parameterIndex, int x) throws SQLException
  	{
! 		set(parameterIndex, Integer.toString(x));
  	}
  
  	/**
***************
*** 203,209 ****
  	 */
  	public void setLong(int parameterIndex, long x) throws SQLException
  	{
! 		set(parameterIndex, (new Long(x)).toString());
  	}
  
  	/**
--- 203,209 ----
  	 */
  	public void setLong(int parameterIndex, long x) throws SQLException
  	{
! 		set(parameterIndex, Long.toString(x));
  	}
  
  	/**
***************
*** 216,222 ****
  	 */
  	public void setFloat(int parameterIndex, float x) throws SQLException
  	{
! 		set(parameterIndex, (new Float(x)).toString());
  	}
  
  	/**
--- 216,222 ----
  	 */
  	public void setFloat(int parameterIndex, float x) throws SQLException
  	{
! 		set(parameterIndex, Float.toString(x));
  	}
  
  	/**
***************
*** 229,235 ****
  	 */
  	public void setDouble(int parameterIndex, double x) throws SQLException
  	{
! 		set(parameterIndex, (new Double(x)).toString());
  	}
  
  	/**
--- 229,235 ----
  	 */
  	public void setDouble(int parameterIndex, double x) throws SQLException
  	{
! 		set(parameterIndex, Double.toString(x));
  	}
  
  	/**
*** ./org/postgresql/jdbc1/ResultSet.java.orig	Tue Dec 26 11:50:03 2000
--- ./org/postgresql/jdbc1/ResultSet.java	Tue Dec 26 11:22:41 2000
***************
*** 127,133 ****
     */
    public void close() throws SQLException
    {
!     // No-op
    }
    
    /**
--- 127,134 ----
     */
    public void close() throws SQLException
    {
!     //release resources held (memory for tuples)
!     rows.setSize(0);
    }
    
    /**
*** ./org/postgresql/jdbc2/PreparedStatement.java.orig	Tue Dec 26 11:50:04 2000
--- ./org/postgresql/jdbc2/PreparedStatement.java	Tue Dec 26 11:14:33 2000
***************
*** 164,170 ****
  	 */
  	public void setByte(int parameterIndex, byte x) throws SQLException
  	{
! 		set(parameterIndex, (new Integer(x)).toString());
  	}
  
  	/**
--- 164,170 ----
  	 */
  	public void setByte(int parameterIndex, byte x) throws SQLException
  	{
! 		set(parameterIndex, Integer.toString(x));
  	}
  
  	/**
***************
*** 177,183 ****
  	 */
  	public void setShort(int parameterIndex, short x) throws SQLException
  	{
! 		set(parameterIndex, (new Integer(x)).toString());
  	}
  
  	/**
--- 177,183 ----
  	 */
  	public void setShort(int parameterIndex, short x) throws SQLException
  	{
! 		set(parameterIndex, Integer.toString(x));
  	}
  
  	/**
***************
*** 190,196 ****
  	 */
  	public void setInt(int parameterIndex, int x) throws SQLException
  	{
! 		set(parameterIndex, (new Integer(x)).toString());
  	}
  
  	/**
--- 190,196 ----
  	 */
  	public void setInt(int parameterIndex, int x) throws SQLException
  	{
! 		set(parameterIndex, Integer.toString(x));
  	}
  
  	/**
***************
*** 203,209 ****
  	 */
  	public void setLong(int parameterIndex, long x) throws SQLException
  	{
! 		set(parameterIndex, (new Long(x)).toString());
  	}
  
  	/**
--- 203,209 ----
  	 */
  	public void setLong(int parameterIndex, long x) throws SQLException
  	{
! 		set(parameterIndex, Long.toString(x));
  	}
  
  	/**
***************
*** 216,222 ****
  	 */
  	public void setFloat(int parameterIndex, float x) throws SQLException
  	{
! 		set(parameterIndex, (new Float(x)).toString());
  	}
  
  	/**
--- 216,222 ----
  	 */
  	public void setFloat(int parameterIndex, float x) throws SQLException
  	{
! 		set(parameterIndex, Float.toString(x));
  	}
  
  	/**
***************
*** 229,235 ****
  	 */
  	public void setDouble(int parameterIndex, double x) throws SQLException
  	{
! 		set(parameterIndex, (new Double(x)).toString());
  	}
  
  	/**
--- 229,235 ----
  	 */
  	public void setDouble(int parameterIndex, double x) throws SQLException
  	{
! 		set(parameterIndex, Double.toString(x));
  	}
  
  	/**
*** ./org/postgresql/jdbc2/ResultSet.java.orig	Tue Dec 26 11:50:04 2000
--- ./org/postgresql/jdbc2/ResultSet.java	Tue Dec 26 11:22:46 2000
***************
*** 128,134 ****
     */
    public void close() throws SQLException
    {
!     // No-op
    }
    
    /**
--- 128,135 ----
     */
    public void close() throws SQLException
    {
!     //release resources held (memory for tuples)
!     rows.setSize(0);
    }
    
    /**
[ Charset UTF-8 unsupported, skipping... ]

[ Charset UTF-8 unsupported, skipping... ]


-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026